Time  Nick       Message
11:36 rubenwardy sofar: entityai, when?
16:02 Krock      rubenwardy: would you please be so nice and review #9263 when you've got spare 5 minutes?
16:02 ShadowBot  https://github.com/minetest/minetest/issues/9263 -- Add allowed_mapgens option in game.conf. by wt
16:02 Krock      will merge #9307 in 10 minutes
16:02 rubenwardy Sure, request a review
16:02 ShadowBot  https://github.com/minetest/minetest/issues/9307 -- Increase star count to 1000 and decrease radius slightly. by lhofhansl
16:02 Krock      200 OK
16:02 rubenwardy Jordach will be pissed lol
16:03 rubenwardy Probably not too hard to rebase from
16:07 Krock      how difficult can it be to rebase two lines?
16:12 Krock      merging
18:18 rubenwardy I'm happy to tag 5.1.1, unless anyone has any objections
18:18 rubenwardy Krock:
18:19 Krock      checking pr
18:20 rubenwardy well, there is one thing of note: https://rwdy.uk/UK9Ai.png
18:20 rubenwardy pretty sure this will happen on master too
18:20 rubenwardy text cropping
18:21 rubenwardy huh, I remember it cropping more
18:22 Krock      Unavoidable for now
18:23 Krock      did you increase the Android version?
18:23 Krock      I cannot find it in the diff
18:23 rubenwardy ah
18:23 rubenwardy well, does that need to be done if android isn't released?
18:24 rubenwardy I guess it'll be released on F-Droid
18:25 rubenwardy I'll use the bump version script
18:25 rubenwardy forgot that existed
18:26 Krock      for the sake of F-Droid, please increase it
18:29 rubenwardy https://github.com/minetest/minetest/pull/9252/commits/c2fc168151877193a1c5763e4a99e0f30924df12
18:33 rubenwardy merging #9262 sometime within 5 minutes and 24 hours
18:33 ShadowBot  https://github.com/minetest/minetest/issues/9262 -- Make clipping behavior of certain formspec elements more consistent by Df458
18:33 rubenwardy depending on when I remember
18:34 rubenwardy also, if a PR is approved and has been sitting there for months, is there a minimum time to announce the merge?
18:34 Krock      always announce a merge
18:34 rubenwardy hmmm, there's no rules about even notifying that I can see
18:35 Krock      only for trivial commits, but it's easier to track the actions when they're announced
18:36 rubenwardy *trivial bugs
18:39 Krock      right
18:46 rubenwardy so people ever test PRs
18:46 rubenwardy :D
18:46 rubenwardy https://github.com/minetest/minetest/commit/39a1e6660ecfa5a102b00ca305ebf929821f7214#diff-3254677a7917c6c01f55212f86c57fbfL19
18:47 Krock      huh?
18:47 rubenwardy syntax error
18:53 p_gimeno   --depth 1 raises syntax error?
18:54 rubenwardy lack of \
18:54 Krock      L18. You linked the wrong line
20:17 Wuzzy      one approval for #9205. Any chance for the 2nd one?
20:17 ShadowBot  https://github.com/minetest/minetest/issues/9205 -- Falling nodes: Add support for facedir, colorfacedirr, wallmounted, colorwallmounted, color, airlike, signlike, torchlike and glow by Wuzzy2
20:24 rubenwardy I don't understand this error message: https://gitlab.com/minetest/minetest/-/jobs/406002672
20:26 Krock      /usr/local/share/minetest apparently doesn't exist
20:26 rubenwardy from=0  refers to the first `FROM` I guess
20:28 Krock      Wuzzy: meanwhile my +8/-3 LOC PR #8873 is waiting for another approval since last august
20:28 ShadowBot  https://github.com/minetest/minetest/issues/8873 -- Add default stack size setting by SmallJoker
20:29 rubenwardy well: https://github.com/minetest/minetest/tree/gltest
20:29 Wuzzy      Krock: but your feature is "controversial" ?
20:29 Krock      rubenwardy:  && \
20:29 Wuzzy      22 comments wow!!
20:30 rubenwardy aha!
20:30 Wuzzy      the smallest changes always generate the most discussion /s
20:30 rubenwardy thanks Krock
20:30 Krock      !next
20:30 ShadowBot  Another satisfied customer. Next!
20:30 Krock      Wuzzy: well in this case sarcasm isn't needed because it's true
20:30 rubenwardy nnoooo
20:30 rubenwardy I accidentally closed my client
20:31 Krock      alias Ctrl+S to Alt+F4
20:31 rubenwardy looool
20:31 rubenwardy evil