Time  Nick       Message
00:47 ANAND      ~tell Krock I see. Thanks for letting me know. If only a solution is that simple... :P
00:47 ShadowBot  ANAND: O.K.
11:51 Krock      #9177
11:52 ShadowBot  https://github.com/minetest/minetest/issues/9177 -- Add core.get_player_or_load by SmallJoker
12:23 rubenwardy I suggest forbidding the player refs from being stored, meaning they could be invalidated between callbacks. This way mods don't need to care about when a player is loaded, it's handled by the engine
12:24 Krock      you may not store ObjectRefs anyway
12:24 Krock      s/store/keep them referenced after leaving a callback/
12:25 rubenwardy Yeah
12:26 rubenwardy Therefore it's fine for the engine to unload players outside of callbacks
12:26 rubenwardy Players may only join when packets are being received, which is outside of callbacks
12:29 Krock      hmm.. hooking runCallbacks()
12:29 Krock      tbh I'm not very happy about this approach
12:30 Krock      what if the player is modified on mod load?
12:42 rubenwardy No need to hook run callbacks
12:43 rubenwardy I haven't looked at the pr yet
12:43 rubenwardy But defining using a playerred between callbacks as undefined behaviour
12:44 rubenwardy And then forcefully closing references between a player joins is fine to me
17:52 sfan5      merging #8996 in 5 minutes
17:52 ShadowBot  https://github.com/minetest/minetest/issues/8996 -- Formspec: make bgcolor element less confusing and allow setting fullscreen color by DS-Minetest
22:22 Fixer      this may be a serious bug linked to outdated translation not letting players to connect to servers: https://github.com/minetest/minetest/issues/8568