Time  Nick      Message
00:40 ANAND     sfan5: I haven't reverted all of the previous PR in #9025
00:40 ShadowBot https://github.com/minetest/minetest/issues/9025 -- Revert Client::sendPlayerPos optimization (part of 81c7f0a) by ClobberXD
00:41 ANAND     I've only commented out the two lines that prevent sending the TOSERVER_PLAYERPOS if the player is dead client-side
18:26 paramat   celeron55 can you remember why 'insure' has to be used, and why it is so large, when the radius of a tunnel is already compensated for? https://github.com/minetest/minetest/blob/038529c7638ce48525df9c0ae610d99f2e58aedc/src/mapgen.cpp#L1478
18:26 Krock     will merge #9025 in 10 minutes
18:26 ShadowBot https://github.com/minetest/minetest/issues/9025 -- Revert Client::sendPlayerPos optimization (part of 81c7f0a) by ClobberXD
18:27 Krock     paramat: why does this comment even exist?
18:28 celeron55 paramat: i don't recall anything about that code anymore
18:30 Krock     I'd also love to see somebody who still knows about what the code does after 6 years (or more)
18:36 Krock     merging
18:39 paramat   ok thanks
18:39 paramat   i might test to find out
18:40 paramat   Krock well, that comment only exists in old code, it is now removed
18:42 paramat   the randomwalk caves extend beyond a mapchunk edge, i am interested in maximising this extension to increase overlap and cave intersection
20:02 paramat   hm, i'm 6 commits behind master and just had a crash on world start "ERROR[Main]: /home/matstandard/minetestf/gitmods/minetest/src/client/localplayer.cpp:2c7: bool LocalPlayer::isDead() const: A fatal error occurred: LocalPlayer's CAO isn't initialized" interesting
20:03 paramat   thought i would mention it as is topical
20:04 sfan5     I did suggest entirely reverting any changes related to the autoforward-fix/sendPlayerPos stuff
20:12 sfan5     which would preclude any breakage biting us after release
20:12 sfan5     of course this would mean that autoforward continues to be enabled when you die (which is just a minor annoyance)
20:24 paramat   yes and i would be fine with that. i do not understand this issue much but i am assuming what was merged today did not do that. i'll file an issue for my crash
20:25 paramat   i think a full revert is the best thing to do
20:26 sfan5     there are two placed where isDead() can be called
20:26 sfan5     one was commented out with the revert today
20:26 sfan5     the other is still there (for disabling autoforward when dead)
20:34 paramat   #9030
20:34 ShadowBot https://github.com/minetest/minetest/issues/9030 -- isDead() related crash on new world start
21:04 paramat   in testing turned out 'insure' only needed to be 2, so we can have more cave overlap and connection, commit made
21:07 paramat   ah, i can reproduce the crash, leave then re-enter a world with autoforward enabled
21:09 paramat   so the fix seems clear
22:11 paramat   (... that is, another commenting-out of the call)
22:16 sfan5     a proper fix would be to also check m_activeobjects_received there