Time  Nick       Message
00:07 jas_       +1 paramat
00:18 Lone_Wolf  +1 if you also change the regular soil desc.
15:58 sfan5      oh god who's gonna review all these mtg translations
16:03 rubenwardy Using a custom format was a terrible decision
16:05 sfan5      writing a custom gettext parser is a worse decision
16:05 rubenwardy Is it though?
16:05 rubenwardy What license is gettext under?
16:07 sfan5      oh Calinou was nice enough to review the french TL
16:08 sfan5      I guess we can just merge the others after a sanity check, it's not like we do quality control on engine translations
16:10 Calinou    writing a custom gettext parser isn't too difficult if you don't care about complex features like pluralization
16:10 Calinou    still, even JSON will play better with translation platforms and the like
16:11 Calinou    https://github.com/godotengine/godot/blob/master/core/io/translation_loader_po.cpp :)
16:12 Calinou    that one is only 200 lines of code, it supports multiline strings, comments and all that
16:12 Calinou    it's not standalone of course, but it shows you that it's possible with a reasonable amount of code
17:25 paramat    i see no rush to merge particular MTG translations for 5.1.0, it's a feature
17:25 rubenwardy Updating translations isn't a feature
17:26 rubenwardy It's done for the engine just before releasing
17:26 rubenwardy If there are problems then the pr can be not included
17:58 paramat    i agree it's not a feature, i worded that wrong