Time Nick Message 15:19 rubenwardy feature freeze should start soon:tm: 15:20 rubenwardy any urgent features remaining? 15:20 rubenwardy I don't think so 16:10 Krock no features awaiting according to the milestone 16:10 Krock please adjust the /topic 16:16 rubenwardy It's worth updating the translated strings. Does anyone have experience with that? 16:31 rubenwardy paramat o/ 16:39 Krock rubenwardy: 1) uncomment the bottom two comments in dlg_advanced_settings.lua (builtin/mainmenu/) and run minetest 16:39 Krock 2) ./util/update_po.sh 16:39 rubenwardy Oh really 16:39 Krock 3) grab the stuff from weblate 16:39 rubenwardy AHH, does that update the settings file? 16:40 Krock actually, grab the stuff first, then run the scripts 16:40 Krock yes 16:40 Krock doing the reverse (running scripts before weblate) might cause conflicts 16:43 Krock last time I just shallow cloned the weblate repo and moved the files over to "squash" the commits 16:45 Krock but I don't expect too many new translation strings, but rather many changed translation lines from weblate - last updated 3 weeks ago 16:49 Krock (Shiity) trick in Feature Freeze: Hide your feature PRs as bugfixes 17:04 paramat O/ 17:05 paramat no urgent features in MTG, have checked 17:08 Krock good to hear 17:09 paramat although ... we could perhaps add in the much more suitable new bar door sounds game#2497 17:09 ShadowBot https://github.com/minetest/minetest_game/issues/2497 -- xpanes add new steel bar door sounds by TumeniNodes 17:09 paramat the steel doorsounds currently used are somewhat unsuitable 17:10 paramat luckily, new sounds are simple and unlikely to cause bugs 17:11 paramat i'll review anyway then perhaps we can merge later 17:12 paramat the bar doors are a new feature, it would be good to have decent sounds from the start 17:22 sfan5 agree 17:33 Krock is #8996 needed for 5.1.0? 17:33 ShadowBot https://github.com/minetest/minetest/issues/8996 -- Formspec: make bgcolor element less confusing by using 3 parameters by DS-Minetest 17:34 rubenwardy yes 17:35 Krock #8922 is not needed any more since FORMSPEC_VERSION 2 17:35 ShadowBot https://github.com/minetest/minetest/issues/8922 -- Fix error message caused by adding new parameter to background by rubenwardy 17:35 rubenwardy the issue is fixes is a blocker 17:35 rubenwardy Krock: incorrect 17:35 rubenwardy the error still persists on 5.0.1 clients because most formspecs are still version 1 17:35 Krock which ones? 17:35 rubenwardy the background element is in the prepends string, so applies to all formspecs 17:36 Krock but 5.1.0 servers send the new version? 17:36 rubenwardy sfinv uses version 1, for example 17:36 Krock did you hardcode that already? 17:36 rubenwardy really? Doesn't version 2 force real coordinates? 17:36 Krock nvm 17:36 Krock yeah, it has to be explitic 17:37 Krock *explicit 17:38 Krock PITA to have it like this 17:41 Krock what if you specify formspec_version 2 in the gane prepends? 17:41 Krock *game (can't spell today) 17:41 Krock erm chances are that it won't display at the right position 17:42 DS-minetest mtg should maybe use version 2 if it uses 9-split background 17:42 Krock I hate prepends 17:42 DS-minetest can you disable real_coordinates in fs version 2? 17:42 Krock oh yes indeed you can 17:43 rubenwardy it won't work because 5.0.1 doesn't support versions only for prepends 17:43 Krock formspec_version[2]real_coodinates[false]background9.... 17:43 Krock aagh 17:44 Krock this kind of issue will hunt us for a while 17:44 DS-minetest is that a problem? 17:45 Krock none of the extended parameter elements will work for 5.0.1 inside prepends 17:45 Krock as long 5.0.1 is supported extended elements won't be usable inside prepends 17:47 DS-minetest is there anything broken in 5.0.1 client if fs version is 2? 17:47 Krock you cannot set fs version to 2 inside prepends there 17:47 DS-minetest oh 17:48 Krock in fact, just once before size[] 17:50 DS-minetest oh, prepends was parsed after size and co. 17:51 DS-minetest it might be worth mentioning https://github.com/minetest/minetest/commit/1cef09ff10515ae56884e766ddb4b27ef44a9572 somewhere (it's not specially documented in lua_api.txt) 17:51 DS-minetest !title 17:51 ShadowBot Fix inventory_overlay for nodes without inventory_image (#8433) · minetest/minetest@1cef09f · GitHub 17:57 Krock do you mean overlays in general? this is just a bugfix 17:58 DS-minetest but the bugfix opens new possibilities to modders 17:59 DS-minetest (so does https://github.com/minetest/minetest/commit/0b5c5499ec4be6d1d4349478d89edb793d36ec66) 17:59 DS-minetest !title 17:59 ShadowBot Trigger on_place in many situations even if prediction failed · minetest/minetest@0b5c549 · GitHub 18:01 * DS-minetest will add both to changelog is nobody has anything against that 18:01 rubenwardy things should be added in order 18:01 rubenwardy otherwise it gets confusing on what needs to be added to the change log 18:02 rubenwardy see the big warning at the top 18:03 * DS-minetest thought new would mean newly added to changelog. he will look for the merge time 18:04 rubenwardy DS-minetest: added in order, meaning don't add a change if there are changes before that change that haven't been added 18:05 rubenwardy ie: when it comes to update the changelog, you should only need to look at the commits newer than the newest commit on the changelog 18:05 rubenwardy the actual order of things in the changelog doesn't matter 18:05 rubenwardy typically they're sorted in order of notability 18:08 DS-minetest ah, I see. I won't change the changelog then, to not affect the history 18:21 paramat i'll merge game#2503 in 1 hour 18:21 ShadowBot https://github.com/minetest/minetest_game/issues/2503 -- Remove leaf decay/sneak key gotcha' by AlexYst 18:31 paramat ha the new bar door sounds are so good 18:34 paramat +1 levels in-game are good. please can we merge this today? 19:03 paramat back in 30 mins 19:23 Krock updating the changelog a bit 20:02 Krock updated 20:02 paramat merging game#2503 20:02 ShadowBot https://github.com/minetest/minetest_game/issues/2503 -- Remove leaf decay/sneak key gotcha' by AlexYst 20:03 paramat can anyone approve game#2497 ? 20:03 ShadowBot https://github.com/minetest/minetest_game/issues/2497 -- xpanes add new steel bar door sounds by TumeniNodes 20:12 Krock what's the "idle time" for contributors to move them to the "previous contributors" credits list? 20:12 Krock it would also be possible to sort them by year of last activity 20:49 paramat i doubt there is a chosen time. also seems a pain to check and sort, maybe just have 1 list for contributors? 20:52 paramat oh nice, merging game#2497 20:52 ShadowBot https://github.com/minetest/minetest_game/issues/2497 -- xpanes add new steel bar door sounds by TumeniNodes 21:17 paramat creak - clang!