Time Nick Message 12:30 sfan5 pushing trivial commit readding "waving = 3" to water to mtg in a few minutes 13:02 ANAND Does #8871 require two approvals? It's trivial-ish 13:02 ShadowBot https://github.com/minetest/minetest/issues/8871 -- Move Quicktune code to util/ by ClobberXD 13:02 ANAND It has been approved by Krock 13:03 ANAND Also, #8271 (bugfix) requires one more approval 13:03 ShadowBot https://github.com/minetest/minetest/issues/8271 -- Fix breath statbar scaling; defer breath_bar hiding by one second by ClobberXD 13:04 ANAND Ofc, how can I forget to mention that #7557 needs another approval too? ;) 13:04 ShadowBot https://github.com/minetest/minetest/issues/7557 -- Add support for per-player FOV overrides and multipliers by ClobberXD 14:48 DS-minetest some PR advertisement coming in: 14:49 DS-minetest Would someone who uses macOS or windows please be so kind and test #8665? 14:49 ShadowBot https://github.com/minetest/minetest/issues/8665 -- Formspec: change the appeareance of the cursor on fields and co. by DS-Minetest 14:50 DS-minetest #8448 has 5 :+1:s, hence it's pretty popular. 14:50 ShadowBot https://github.com/minetest/minetest/issues/8448 -- Allow to set the displayed item count and its offset via meta by DS-Minetest 14:53 DS-minetest Lua PRs #7712 and #8515 are already lying around for months. You don't have to read all the walls of text. 14:53 ShadowBot https://github.com/minetest/minetest/issues/7712 -- Add an item pick up callback (2) by DS-Minetest 14:53 ShadowBot https://github.com/minetest/minetest/issues/8515 -- Add matrix helpers to builtin by DS-Minetest 14:53 DS-minetest ^ dev decisions needed 14:54 DS-minetest I'd like #8640 (a bugfix) to be in 5.1. 14:54 ShadowBot https://github.com/minetest/minetest/issues/8640 -- Trigger on_place in many situations even if prediction failed by DS-Minetest 14:55 DS-minetest ^ to review use side-by-side mode 14:55 DS-minetest *split, not side-by-side 14:57 ANAND Split is side-by-side :) 14:57 DS-minetest yeah, but it's called "split" :) 14:58 * DS-minetest will describe the changed of that PR for easier reviewing 15:08 rubenwardy Two weeks until feature freeze 15:09 ANAND Really? :O 15:09 DS-minetest detailed description added to #8640, reviewing should be easier now 15:09 ShadowBot https://github.com/minetest/minetest/issues/8640 -- Trigger on_place in many situations even if prediction failed by DS-Minetest 15:10 ANAND #7557 is going to miss 5.1.0 too? This is nuts :( 15:10 ShadowBot https://github.com/minetest/minetest/issues/7557 -- Add support for per-player FOV overrides and multipliers by ClobberXD 15:11 DS-minetest #8716 needs a second approval (Krock called it "A beauty.") 15:11 ShadowBot https://github.com/minetest/minetest/issues/8716 -- Fix the bgcolor formspec element by DS-Minetest 15:12 DS-minetest #8752 needs more attention, modders and players might like it 15:12 ShadowBot https://github.com/minetest/minetest/issues/8752 -- Add a detailed_description to items by DS-Minetest 15:40 rubenwardy We should decide what to prioritise for 5.1.0, especially the formspec PRs 15:40 rubenwardy also, we need to determine whether the formspec reordering PR is a breaking change 15:41 DS-minetest i don't think it's that common that elements overlapp 15:42 DS-minetest if the formspec version PR gets merged I could move boxes to the back if the version is smaller than 2 15:42 DS-minetest (boxes do sometimes overlapp) 15:42 DS-minetest -p* 15:46 rubenwardy yeah, I think it's fine to accept this small breaking change if we can assess the scope of breakages 15:47 rubenwardy as it's undocumented, you could argue that it's not an API so the versioning isn't affected 15:47 rubenwardy however, this is probably troubling logic 15:51 rubenwardy #8923 is approved, Krock 15:51 ShadowBot https://github.com/minetest/minetest/issues/8923 -- Formspec version by SmallJoker 15:52 Krock yes right. I wanted to check whether the prepends "local" version works, but forgot to do so yet 15:52 rubenwardy ah ok 15:52 Krock should work (TM) anyway. it's fairly simple 15:52 rubenwardy well formspec_versions being in the wrong place throw errors in 5.0.1? 15:52 rubenwardy like, this may not fix the problem in that case 15:52 Krock no, they're jsut skipped 15:52 Krock like any other unknown element 15:53 rubenwardy will the extra parameter then give an error? 15:53 Krock only the first element matters 15:53 Krock yes. parseVersionDirect expects only one argument 15:54 Krock single `[` split 15:54 rubenwardy I'm wondering whether the following formspec would result in the background not giving an error on 5.0.1 15:55 rubenwardy size[1,2] (prepends) formspec_version[1]background[0,0;1,1;hello.png;true]background[0,0;1,1;hello.png;true;10] (prepends end) content 15:55 rubenwardy like, this PR is good for the future 15:55 rubenwardy but can it actually fix the background error from prepends issue? 16:05 Krock it would only fix that if prepends specify none or version 2 16:05 Krock it would require a server running 5.1.0-dev anyway since the version is errously included in the prepends now 16:07 rubenwardy sigh 16:07 rubenwardy what about a 5.0.1 client? 16:07 rubenwardy the issue is that 5.0.1 clients connecting to 5.1.0 servers will see error messages 16:08 rubenwardy I don't think this PR actually fixes that with 5.0.1 clients, because they don't support versions in prepends 16:08 rubenwardy and setting a version for the whole thing is a massive no, because it will force _all_ formspecs to use real coordinates 16:08 rubenwardy like, don't get me wrong, this doesn't make this PR bad 16:17 Krock 5.1.0 clients can be fixed by adding a version tag 16:18 rubenwardy right 16:18 Krock but that one must be before "size[" 16:18 Krock * 5.0.1 clients 16:19 Krock and only if the server is 5.1.0-dev+ because the version is added automatically in older versions 16:20 Krock thus resulting in totally wrecked formspecs because there would be two versions, but the formspec handler only accepts one 16:20 Krock ANAND: https://github.com/minetest/minetest/issues/8929#issuecomment-531492354 16:21 Krock if you have some more free time: please check whether it still happens with this patch/diff. I could not reproduce it, but better to have two independent results 16:23 ANAND Krock: I'll test tomorrow, thanks for the patch 16:24 Krock I don't know why it works but it does 16:24 Krock sends player movements if the parent isn't known to the client 16:24 ANAND Hacky, but makes sense :) 16:24 Krock so the nametags will move as they drive around 16:25 Krock the camera offset is some weird stuff I'd prefer not to touch, hence this workaround 16:39 Krock why does RemoteClient AND RemotePlayer exist? They should both contain the same data: peer_id, proto version, SAO pointer 16:40 rubenwardy player is probably a subclass of object, whereas client is a peer and exists before the player is emerged 16:40 Krock I'm well aware, but both could contain the same data, whereas it's created on TOSERVER_INIT, and completed loading in TOSERVER_INIT2 (load SAO) 16:41 Krock RemoteClient is owned by Server, RemotePlayer by ServerEnv 16:52 ANAND Krock: Does #8271 require another approval? 16:52 ShadowBot https://github.com/minetest/minetest/issues/8271 -- Fix breath statbar scaling; defer breath_bar hiding by one second by ClobberXD 16:53 ANAND and #8871? 16:53 ShadowBot https://github.com/minetest/minetest/issues/8871 -- Move Quicktune code to util/ by ClobberXD 16:58 Krock All PRs but those from core devs need two approvals (or more) 16:58 Krock an exception are "Trivial"-tagged PRs where one approval suffices 16:59 Krock see Git Rules @ dev wiki 16:59 ANAND Isn't #8871 trivial? 16:59 ShadowBot https://github.com/minetest/minetest/issues/8871 -- Move Quicktune code to util/ by ClobberXD 16:59 Krock well yes 16:59 ANAND Ik about two approvals, I was just wondering if those PRs needed a second approval :) 17:00 ANAND I'll try to fix #7924 before the freeze 17:00 ShadowBot https://github.com/minetest/minetest/issues/7924 -- Bind mouse buttons (Adopted from #6537) by ClobberXD 17:01 rubenwardy Core developers can self-approve a PR, but it's frowned upon for big PRs 17:02 rubenwardy what PRs should be prioritised for 5.1.0? 17:02 Krock those from the milestone 17:03 Krock creating 5.2.0 milestone to move unimportant ones there 17:03 rubenwardy ok cool 17:03 rubenwardy well, I'm looking through the milestone now 17:05 Krock replacing #8876 with #8834 there because it fixes the issue 17:05 ShadowBot https://github.com/minetest/minetest/issues/8876 -- 'Autoforward' broken when damage is disabled 17:05 ShadowBot https://github.com/minetest/minetest/issues/8834 -- [no squash] Send ActiveObjects along with definitions once connection is established by ClobberXD 17:05 Krock not replacing. latter 17:05 Krock *adding latter 17:05 ANAND https://github.com/minetest/minetest/pull/7557#event-2328766480 - Why was 7557 removed from the milestone? 17:07 Krock because it's not a bugfix 17:07 Krock it could still be merged, but the milestone is for PRs that should be priorized 17:07 ANAND I thought 5.1.0 isn't a bugfix release 17:08 rubenwardy it still should be bug fixes 17:08 rubenwardy wait, misready 17:08 rubenwardy it's not a bugfix release, but major issues and bugfixes should be prioritised now 17:08 Krock ^ 17:08 DS-minetest but bug fixes can be merged while feature freeze, can't they? 17:08 Krock deadline is sept 20th 17:08 rubenwardy yeah 17:08 Krock * 30 17:09 ANAND I understand. But that PR is older than me lol. I'm just hoping that it gets in. :) 17:09 Krock "older than me"? 17:09 DS-minetest #8640 is a bugfix and someone told me that they'd like to see it in 5.1 17:09 ShadowBot https://github.com/minetest/minetest/issues/8640 -- Trigger on_place in many situations even if prediction failed by DS-Minetest 17:10 Krock DS-minetest: how am I supposed to use the testing code? place it into other nodeboxes? 17:10 DS-minetest yes 17:10 ANAND That was an exaggeration, ofc 17:11 Krock I ended up specifying one node with a prediction and checked for errorously replaced nodes 17:11 DS-minetest Krock: look into the then fixed issue 17:11 Krock didn't quite get why the other chat_send_all calls are there 17:11 DS-minetest #_← (#=full node; _=slab) 17:12 DS-minetest uh, yeah, I should short it 17:12 Krock on_place was the only I needed there 17:13 DS-minetest updated 17:13 Krock (ItemGroupList) predicted_f.groups)["attached_node"] 17:14 Krock old code but still. this initializes a new pair in the map 17:14 Krock I assume the groups pushing code already handles that 17:15 Krock actually it can't. predicted_f is const 17:16 DS-minetest that line wasn't really changed 17:21 Krock will merge #8627 and #8923 in 15 minutes 17:21 ShadowBot https://github.com/minetest/minetest/issues/8627 -- [NO SQUASH] Load CSM environment after the restrictions are known by SmallJoker 17:21 ShadowBot https://github.com/minetest/minetest/issues/8923 -- Formspec version by SmallJoker 17:21 Krock thanks for the review 17:29 rubenwardy I wish that lhofhansl wasn't too cool for us, and hung around in IRC 17:29 ANAND lol 17:38 DS-minetest (15 mins are over) 17:39 Krock merging 17:39 Krock DS-minetest: to my defence I'm trying to call xfce4-notifyd with dbus to show up a timeout notification 17:39 Krock irony intensifies 18:00 rubenwardy Krock: formspec PR has forced the pause menu into real co-ordinates, which looks weird 18:06 Lone_Wolf https://github.com/minetest/minetest/issues/8932 18:06 sfan5 merging #8834 in 10 minutes 18:06 ShadowBot https://github.com/minetest/minetest/issues/8834 -- [no squash] Send ActiveObjects along with definitions once connection is established by ClobberXD 18:11 rubenwardy #8932 18:11 ShadowBot https://github.com/minetest/minetest/issues/8932 -- Built-in formspecs are forced to use real_coordinates, but haven't been converted 18:17 sfan5 done 18:19 Krock oof 18:24 sfan5 merging game#2477 in 5 minutes 18:24 ShadowBot https://github.com/minetest/minetest_game/issues/2477 -- Add missing infotext to nodes by An0n3m0us 18:31 Krock will push https://krock-works.uk.to/u/patches/0001-Built-in-formspecs-Force-version-1.patch in 10 minutes 18:33 DS-minetest updating to version 2 should be done at some point anyway 18:33 DS-minetest (but using "formspec_version[n]" instead of FORMSPEC_VERSION_STRING makes sense) 18:35 DS-minetest Krock: may I suggest that you remove the redundant std::string(...)? 18:35 DS-minetest (and the +) 18:37 Krock DS-minetest: you cannot concat char* 18:38 Krock string literals are pointers unless you concat it with strings 18:38 DS-minetest oh, sorry 18:39 Krock strings are needed due to the gettext call in between. if it were only literals there wouldn't be an issue 18:40 Krock s/oh, sorry/til: string literals are char* 18:41 Krock Minetest also has an educational purpose, especially in modding and core dev 18:41 Krock pushing 18:42 Krock this formspec issue actually makes me wonder why builtin isn't broken too 18:42 Krock nvm. there's no version specified 18:43 Krock done 18:49 p_gimeno I thought string.append was more optimal than + 18:50 Krock p_gimeno: yes, but performance does not matter in this case 18:50 p_gimeno ok 18:50 Krock that is because the original string is enlarged, instead of allocating a new combined string 22:01 paramat merging #8918 22:01 ShadowBot https://github.com/minetest/minetest/issues/8918 -- Dungeons: Clean up parameters, improve structure variety by paramat