Time Nick Message 09:33 ANAND Is it alright if I add a method to class Server that executes a Lua function? Or should that go to src/script/ ? 09:37 sfan5 that sounds like it would belong to the scriptapi 09:59 ANAND Alright, thanks! 10:17 p_gimeno @DS-Minetest: Looks good to me now :) Let's see what the core devs say. 20:13 p_gimeno VanessaE: in case you missed it, I can't reproduce #8532. It's working fine for me with minetest_menu_header.png / minetest_menu_overlay.png 20:13 ShadowBot https://github.com/minetest/minetest/issues/8532 -- Can't override menu background/overlay from a texture pack 20:15 VanessaE but are you supplying them as part of a texture pack, and using 5.0.1-release? 20:15 VanessaE fwiw: 20:15 p_gimeno I'm using current master and, well, I have tested with a texture pack that consists only of these two textures 20:16 VanessaE yeah, no. 20:16 VanessaE check with stable-5 20:16 VanessaE fwiw: the progress bar supplied by HDX *does* still work 20:17 VanessaE can I assume minetest_menu_logo.png would be correct for the game icon at the bottom of the display? 20:18 p_gimeno I don't think there have been any changes since stable-5 that justify any change in this area, but compiling anyway... 20:19 p_gimeno works all the same 20:19 VanessaE I don't understand why it isn't working for me. 20:19 VanessaE minetest_game is stable-5 also? 20:19 p_gimeno hm, probably not, let me change that 20:20 VanessaE from what I could gather, the bug as it happens for me is possibly centered there. 20:20 p_gimeno my game folder is named minetest_game if that matters 20:21 VanessaE I mean, I grepped my entire minetest tree for that table name, and only found refs in builtin where it's being read/accessed, but nothing remotely suggesting creation or modification. 20:22 VanessaE (said tree has the engine, several games, and shittons of mods) 20:25 p_gimeno no difference when using the stable-5 versino of minetest_game 20:26 VanessaE well, I guess I'll just have to re-clone both, recompile, and try again .. 20:27 p_gimeno re-clone? I *never* do that. But a clean compile sometimes helps, and for that, building in a subfolder help. 20:27 p_gimeno +s 20:27 VanessaE but, https://xkcd.com/1597/ 20:27 VanessaE :) 20:35 p_gimeno maybe give a shot to strace -f -e trace=open minetest 20:36 p_gimeno see what files it tries to open, and the result of the open 20:45 VanessaE ok, remind me again what overlay does vs header? 20:46 VanessaE just to make sure I don't have this screwed up somehow 20:46 p_gimeno overlay is the background, header is the top sign 20:46 VanessaE that's what I thought. 20:48 p_gimeno and again, in case it matters, my MTG is in games/minetest_game 20:49 VanessaE ok, new clones of both, stable-5, recompiled, made sure ~/.minetest/games/minetest_game points to the actual game...still not loading 20:50 p_gimeno hm, I'm using RUN_IN_PLACE=1, not sure if that makes a difference 20:50 p_gimeno give a shot to strace, at least it should tell you what path it is trying to open 20:50 VanessaE https://pastebin.ubuntu.com/p/2bMBMWgX2K/ 20:51 VanessaE and mine's not RUN_IN_PLACE 20:51 p_gimeno with the texture pack active, I presume 20:52 p_gimeno weird, it's not trying to open any 20:53 * p_gimeno scratches head 20:53 VanessaE correct 20:53 VanessaE the -hires conf has my 256x size as its texture pack setting. 20:54 VanessaE vanessa@rainbird:~$ find ~/Minetest-related/texture-packs/HDX/|grep menu/home/vanessa/Minetest-related/texture-packs/HDX/256px/minetest_menu_header.png 20:54 VanessaE grr 20:54 VanessaE stupid newlines. 20:54 VanessaE lemme try that again :) 20:54 VanessaE vanessa@rainbird:~$ find ~/Minetest-related/texture-packs/HDX/|grep menu 20:54 VanessaE /home/vanessa/Minetest-related/texture-packs/HDX/256px/minetest_menu_header.png 20:54 VanessaE /home/vanessa/Minetest-related/texture-packs/HDX/256px/minetest_menu_overlay.png 20:55 VanessaE there. 20:56 p_gimeno I'm running in place, my texture pack is in $MINETEST/textures/issue8352/ and I have these two files 20:57 VanessaE .minetest/textures has a bunch of symlinks; the one selected.....wait 20:57 VanessaE *thinks* 20:58 VanessaE vanessa@rainbird:~$ ls -la ~/.minetest/textures/ 20:58 VanessaE lrwxrwxrwx 1 vanessa vanessa 54 Dec 28 2015 HDX-256px -> /home/vanessa/Minetest-related/texture-packs/HDX/256px 20:58 VanessaE (...) 20:58 VanessaE so that's correct. 20:58 p_gimeno oh and the correct syscall appears to be lstat, can you try that? strace -f -e trace=lstat 20:59 VanessaE trying... 20:59 VanessaE https://pastebin.ubuntu.com/p/65XhNcF36S/ 21:00 p_gimeno fudge 21:00 p_gimeno try stat, please 21:00 VanessaE https://pastebin.ubuntu.com/p/tGkzsTGWNR/ 21:01 VanessaE could it be because HDX is behind a symlink? 21:02 p_gimeno I doubt it, mine is too 21:02 p_gimeno l textures/issue8352 21:02 p_gimeno lrwxrwxrwx 1 pgimeno users 28 May 15 14:03 textures/issue8352 -> ../../texturepacks/issue8352/ 21:03 p_gimeno minetest_menu_overlay.png is not a broken link, right? 21:03 VanessaE no 21:04 VanessaE it's a freshly just-now-saved file from GIMP directly into the target dir. 21:04 VanessaE vanessa@rainbird:~$ ls -la ~/Minetest-related/texture-packs/HDX/256px/|grep menu 21:04 VanessaE -rw-r--r-- 1 vanessa vanessa 387591 May 16 16:49 minetest_menu_header.png 21:04 VanessaE -rw-r--r-- 1 vanessa vanessa 1203953 May 16 16:47 minetest_menu_overlay.png 21:05 p_gimeno weirdest thing is that there's no stat, lstat or open of anything in ~/.minetest/textures 21:06 p_gimeno a bisect would be great, but I wonder if you will have enough patience :) 21:07 p_gimeno since I can't reproduce it, I can't bisect it either 21:07 VanessaE wouldn't help, I don't remember when it worked last.. just sometime in 0.4.x 21:07 VanessaE it's not something I pay much attention to :P 21:07 p_gimeno starting in 0.4.16 would not need too many bisects 21:08 VanessaE the aforementioned -hires config: https://pastebin.ubuntu.com/p/8kwRPNYVhf/ 21:08 VanessaE and fwiw, once in-game, all textures work as expected. 21:09 VanessaE menu_last_game = dreambuilder 21:09 VanessaE hm. 21:09 VanessaE odd, the selected world is: 21:09 VanessaE vanessa@rainbird:~$ less .minetest/worlds/Dreambuilder-testing/world.mt 21:09 VanessaE ... 21:09 VanessaE gameid = minetest 21:10 p_gimeno if you switch games, does it fix itself? 21:10 VanessaE lemme chedck. 21:10 p_gimeno switch to another game, then back to minetest_game 21:10 VanessaE lemme check, too. 21:11 VanessaE hm. none of my available worlds use any game other than mtg 21:11 * VanessaE creates a new one. 21:12 p_gimeno don't you even have minimal? that should do 21:12 VanessaE that fixed it. 21:12 p_gimeno ahh 21:12 VanessaE created a world under realtest, then switched back to mtg. now the menu image appears. 21:13 VanessaE so it's using the menu_last_game parameter instead of the ACTUAL selected game. 21:13 * VanessaE updates the issue 21:14 p_gimeno I have minimal empty, yet when I switch to minimal and back to MTG it works 21:14 p_gimeno when I switch to minimal, I see the minimal BG, and when I switch back, I see the textures I placed in the test texture pack 21:14 p_gimeno I'm talking about switching via the icons at the bottom, btw 21:15 VanessaE yeah 21:15 VanessaE didn't think to click there first. 21:15 VanessaE I *never* use those icons. 21:15 VanessaE I tend to forget they're buttons, not just icons. 21:15 p_gimeno yeah :) 21:17 p_gimeno I've checked quite a few games, and it is useful, but not so much for those who don't 21:28 VanessaE there, updated... https://github.com/minetest/minetest/issues/8532 21:31 p_gimeno :+1: and for that matter, why to have menu_last_game at all? 21:32 VanessaE well that's useful by itself 21:32 VanessaE for the initial menu display/world listing, but that field should be ignored as far as the menu graphics are concerned. 21:32 VanessaE the last loaded world should decide that. 21:32 VanessaE or the selected world anyway 21:34 p_gimeno the gameid in world.mt of the last loaded world should decide the game to display, then 21:34 VanessaE sadly, jpg's aren't allowed for menu backgrounds :-/ 21:34 VanessaE agreed. 21:34 VanessaE display the graphics AND world list that corresponds to that setting. 21:35 p_gimeno which again makes me wonder why to have menu_last_game 21:37 VanessaE *shrug* 21:39 p_gimeno the menu bookkeeping settings are a mess; selected_world_path should be used for remembering the selected list item yet mainmenu_last_selected_world is used instead 21:39 p_gimeno there are redundant and insufficiently maintained settings 21:49 VanessaE zhm 21:50 VanessaE ok, header and overlay are working properly... but I can't seem to override the mtg icon 21:50 VanessaE (but lua_api.txt doesn't imply that it should be possible anyway) 21:57 * VanessaE pushes the re-added menu overlay+"header" (empty) images to HDX git. 21:58 VanessaE (er, header is empty I mean, because overlay supplies all that's needed)