Time  Nick       Message
02:50 ANAND      #8441 is no longer WIP. All issues fixed.
02:50 ShadowBot  https://github.com/minetest/minetest/issues/8441 -- Separate server-side disabling of minimap from minimap mode by ClobberXD
02:50 ANAND      It's somewhat trivial, code-wise
02:55 ANAND      Travis builds are failing due to outdated Xcode and https://travis-ci.org/minetest/minetest/jobs/514787850#L739
02:56 ANAND      The second issue probably only applies to that specific build. So, not sure if that needs fixing
02:58 ANAND      Wait a minute... outdated Xcode is no more an issue
02:58 ANAND      Here's why the build "failed": https://travis-ci.org/minetest/minetest/jobs/514787844#L3093
02:59 ANAND      lol
03:00 ANAND      On that note, would someone please take a look at #8443?
03:00 ShadowBot  https://github.com/minetest/minetest/issues/8443 -- Add deprecation warnings for ObjectRef:get/set_attribute by ClobberXD
03:00 ANAND      It's literally two lines :)
03:08 sofar      hey, I wonder if the remote media server would benefit from HTTP/2 over SSL
03:31 sofar      #8140 should be ready?
03:31 ShadowBot  https://github.com/minetest/minetest/issues/8140 -- Force send a mapblock to a player. by sofar
05:41 nerzhul    sofar curl support it you can enable it, http/1.1 is not disabled if you enable it
15:52 rubenwardy Yet another user confused by pitch move
15:52 rubenwardy Such bad UX
16:09 benrob0329 rubenwardy: its not enabled by default iirc?
16:09 rubenwardy the key is bound by default right next to the toggle fly key
16:10 benrob0329 Oh, to be honest the whole system of keybindings we have is confusing for new players
16:10 rubenwardy yeah
16:10 sfan5      just unbind it
16:10 benrob0329 There should be something like, a small help graphic on the main menj
16:10 benrob0329 Below the actual menu
16:12 benrob0329 If something is confusing, that doesn't mean it needs to be hidden, it just needs to not be confusing.
16:12 benrob0329 Pitch-Fly is something a lot of players will probably want if coming from anything that isn't MC
16:13 benrob0329 But its just sitting there without explanation right now and no way for players to know what they hit
16:13 benrob0329 Ohh, I have an idea
16:13 benrob0329 "Pitch Fly Activated (Press L To Turn Off)"
16:14 benrob0329 Leave the message up a little bit longer, and tell players how to turn it back off
16:16 rubenwardy sfan5: paramat is against that though
16:20 p_gimeno   every now and then I discover a setting and go "omg so there was a setting for THIS and I was even thinking to go implement the feature! Why isn't this more visible being so useful?"
16:20 p_gimeno   the last time it happened with always_fly_fast
16:21 p_gimeno   tl;dr: as a user I'm against unbinding it as well
16:23 rubenwardy #8314
16:23 ShadowBot  https://github.com/minetest/minetest/issues/8314 -- Change pitch fly binding, add button to change keys menu by rubenwardy
17:00 sofar      nerzhul: yeah, MT supports HTTP/2 over SSL for remote media without problems, so my public remote media server now enables it as well
17:44 nerzhul    sofar nice
18:52 p_gimeno   I think that #3943 was fixed by #7988. Can someone confirm?
18:52 ShadowBot  https://github.com/minetest/minetest/issues/3943 -- testStreamRead and testBufReader failures
18:52 ShadowBot  https://github.com/minetest/minetest/issues/7988 -- IEEE floats: Fix unit test in release mode by paramat
18:59 p_gimeno   eh no, it's not, sorry, nevermind
20:02 p_gimeno   why is a commit that removes an unused parameter titled "Fix comments"?
20:09 kaeza      Magic.
20:12 paramat    #8438 is very simple, needs another +1
20:12 ShadowBot  https://github.com/minetest/minetest/issues/8438 -- Change sign of pitch angle in debug menu by ClobberXD
20:13 paramat    will merge #8314 in 15 mins
20:13 ShadowBot  https://github.com/minetest/minetest/issues/8314 -- Change pitch fly binding, add button to change keys menu by rubenwardy
20:14 rubenwardy What is the build error for?
20:14 paramat    xcode
20:15 paramat    "The job exceeded the maximum time limit for jobs, and has been terminated."
20:15 rubenwardy Ah kk
20:15 rubenwardy That's fine
20:16 paramat    another simple one #8440
20:16 ShadowBot  https://github.com/minetest/minetest/issues/8440 -- Android settings: Use opaque leaves instead of fancy by paramat
20:17 paramat    sofar are you able to approve game#2290 ?
20:17 ShadowBot  https://github.com/minetest/minetest_game/issues/2290 -- can_interact_with_node check for group key by Lejo1
20:19 paramat    can anyone review bugfix game#2328 ? i don't understand it
20:19 ShadowBot  https://github.com/minetest/minetest_game/issues/2328 -- Fix builtin item metatable. by sofar
20:36 paramat    merging #8314
20:36 ShadowBot  https://github.com/minetest/minetest/issues/8314 -- Change pitch fly binding, add button to change keys menu by rubenwardy
20:46 p_gimeno   I've always wondered why commit messages don't display here
20:51 paramat    they can be very long
20:51 paramat    here's the simple fix for flickering objects at dawn and dusk #8417
20:51 ShadowBot  https://github.com/minetest/minetest/issues/8417 -- Stabilise 'day night ratio' to fix object brightness flicker by paramat
20:52 p_gimeno   I mean, why they are displayed in #minetest instead of #minetest-dev
21:08 p_gimeno   I understand what game#2328 is doing, but not quite why it's a problem (I always prefer metatables to be in a dedicated table anyhow, but I fail to see why it's a problem in this case; the justification in game#2286 is fuzzy to me: "The reason for this fix is the wrong metatables usage that take nil values for some conditions"
21:08 ShadowBot  https://github.com/minetest/minetest_game/issues/2328 -- Fix builtin item metatable. by sofar
21:08 ShadowBot  https://github.com/minetest/minetest_game/issues/2286 -- fix setmetatable for builtin:item enhancement by bell07
21:09 p_gimeno   )
21:21 paramat    ah i see. maybe it's to inform others of commits made
21:23 p_gimeno   hm, now that I look again, game#2286 is incomplete
21:23 ShadowBot  https://github.com/minetest/minetest_game/issues/2286 -- fix setmetatable for builtin:item enhancement by bell07
21:24 p_gimeno   err, game#2328
21:24 ShadowBot  https://github.com/minetest/minetest_game/issues/2328 -- Fix builtin item metatable. by sofar
21:27 p_gimeno   I think this line should also be removed: https://github.com/minetest/minetest/blob/4f7674d448abb9f12030c743a1a6a0d3ad07ad7c/builtin/game/register.lua#L101
21:31 p_gimeno   while on that, why does core.register_item set a different metatable for each itemdef?
21:32 p_gimeno   that looks like an utter waste
22:39 paramat    thanks, will add your comments to the thread