Time Nick Message 01:04 rubenwardy RC time? 01:09 rubenwardy #8145 01:09 ShadowBot https://github.com/minetest/minetest/issues/8145 -- Add setting to hide mature content from ContentDB by rubenwardy 01:14 rubenwardy pushing trivial bugfix in 10: https://github.com/rubenwardy/minetest/commit/3c7e92049d233053a659e5665b121bea67baa69e 01:14 rubenwardy tested 01:15 rubenwardy I suggest releasing a RC tomorrow, and freezing translations 01:22 rubenwardy oh, tomorrow is now 01:36 rubenwardy !tell Krock #7432 does fix a bug in that it stops the wrong content from being renamed, HOWEVER there's now another bug with it 01:36 ShadowBot rubenwardy: O.K. 01:40 rubenwardy !tell Krock the issue is that one of my previous PRs added a `name` field in modpack.conf, which means that it's not possible to rename modpacks with that anymore 01:40 ShadowBot rubenwardy: O.K. 01:40 rubenwardy !tell Krock I guess it should be more of a rename folder thing 01:40 ShadowBot rubenwardy: O.K. 01:42 paramat shouldn't RC come after clearing blockers? 01:42 rubenwardy no 01:42 rubenwardy actually, idk 01:42 paramat ok 01:43 rubenwardy I think that it's ok to have an RC with remaining blockers, as long as it's usually 01:43 rubenwardy actually, no 01:43 rubenwardy what I actually want is a prerelease build 01:43 rubenwardy not a release candidate 01:43 rubenwardy the point is to try and get people to test it and report issues 01:43 paramat i'll probably +1 #8019 soon. that needs attention, other blockers are trivial. but there's also #8090 01:43 ShadowBot https://github.com/minetest/minetest/issues/8019 -- Use true pitch/yaw/roll rotations without loss of precision by pgimeno by pauloue 01:43 ShadowBot https://github.com/minetest/minetest/issues/8090 -- Remove or fix broken commit 4bb41a1 "mitigate formspec exploits" 01:44 paramat yeah, sounds good 01:44 ANAND Yea, just like stu's unofficial APK 01:45 ANAND nerz was saying something about an official pre-release APK for 5.0.0-dev. Guess that didn't happen... 01:47 paramat then i suggest after all blockers are cleared, add another week before release, for final testing 01:49 paramat btw the 5.0.0 'project' https://github.com/minetest/minetest/projects/4 only contains blockers, so is useful as an overview of them 01:51 rubenwardy #8161 01:51 ShadowBot https://github.com/minetest/minetest/issues/8161 -- Number zero fix modpack rename by rubenwardy 01:52 rubenwardy #8161 01:52 ShadowBot https://github.com/minetest/minetest/issues/8161 -- Fix modpack rename related bugs by rubenwardy 03:45 rubenwardy #8162 03:45 ShadowBot https://github.com/minetest/minetest/issues/8162 -- Update credits by rubenwardy 04:20 rubenwardy plllleassse stoppp adding things to default! 04:30 rubenwardy I swear to God, everytime I look at it it gets worse 04:30 rubenwardy why are fences in default? 04:30 rubenwardy oh wait, misread 04:33 sofar lmao 04:35 rubenwardy I thought it was walls 04:35 rubenwardy luckily that is in a different mod 04:35 rubenwardy there seems to be this dogma that mapgen == default 04:35 rubenwardy but that doesn't really need to be true 08:11 nerzhul merging #8157 08:11 ShadowBot https://github.com/minetest/minetest/issues/8157 -- Force player save before kicking on player shutdown by nerzhul 08:53 nerzhul merging #8159 08:53 ShadowBot https://github.com/minetest/minetest/issues/8159 -- DragonFly BSD is somewhat identical to FreeBSD by mazocomp 09:13 Krock merging web#153 09:13 ShadowBot https://github.com/minetest/minetest.github.io/issues/153 -- Now Minetest runs at DragonFly BSD by mazocomp 09:15 Krock no, not merging that one yet. https://github.com/DragonFlyBSD/DeltaPorts/pull/892 needs merging first 11:12 nerzhul at least we make it useless after release 11:47 rubenwardy pushing trivial bugfix in 10: https://github.com/rubenwardy/minetest_game/commit/64a923f7fb92b18a2fb2e727a45c69df744559b8 11:54 Krock looks about right 11:54 Krock but why do you use minetest.after? 11:54 Krock ^ rubenwardy 11:55 rubenwardy because the callbacks are ran before the grant, not after the grant 11:56 Krock ah, so that you can ensure the right sfinv content is displayed after grant 11:56 rubenwardy yeah 11:57 rubenwardy hmmm 12:33 rubenwardy #8164 12:33 ShadowBot https://github.com/minetest/minetest/issues/8164 -- Disable confirmation dialog on localhost by rubenwardy 12:33 rubenwardy Shara ^ 12:34 Shara Nice. I hope we';re still keeping the option though 12:35 rubenwardy yes 12:50 rubenwardy Krock: updated #8145 to your suggestion 12:50 rubenwardy thanks for it 12:50 ShadowBot https://github.com/minetest/minetest/issues/8145 -- Add setting to hide mature content from ContentDB by rubenwardy 12:52 Krock np. double space in .. text .. "]" 12:53 Krock and the gettext line can be broken 12:53 Krock no need for an additional variable 12:55 rubenwardy fixed 12:56 rubenwardy also, looks like the CI is failing because our xcode version has reached end of life 12:56 rubenwardy git: 'cd' is not a git command. See 'git --help'. 12:56 rubenwardy hrr 13:17 Krock rubenwardy: is it possible to supply multiple same named GET parameters? I thought they were unique key/value pairs 13:17 rubenwardy yes 13:17 rubenwardy it's already done for `type` 13:17 rubenwardy it's implementation specific 13:17 rubenwardy for example, PHP uses &type[]=a for arrays 13:17 Krock ah I see, good. 13:18 rubenwardy whereas the server framework I use, flask, uses &type=a 13:19 rubenwardy if you look here, you'll see the function used: https://github.com/minetest/contentdb/commit/9c2c8c21f1e3b412328f05629204a7cf105236c4#diff-e19fcacd83560685f9e3ae649f7cd05bR22 13:21 Krock til GET request parameters can contain multiples of the same key 13:22 rubenwardy :D 13:23 Krock right, the diff above was to make the rename dialogue nice when there's no additional text. also using an entire sentence for the warning 13:24 Krock minor change but while we're on it.. 13:24 * rubenwardy tries cat | git am 13:25 rubenwardy oh, apply 13:25 rubenwardy done 13:29 Krock done 13:30 rubenwardy merging #8161 in 10 :tada: 13:30 ShadowBot https://github.com/minetest/minetest/issues/8161 -- Fix modpack rename related bugs by rubenwardy 13:30 rubenwardy ? 13:30 Krock although I didn't test it on Windows.. I hope it works there too 13:30 rubenwardy paramat still has concerns about #8145 13:30 rubenwardy same 13:30 ShadowBot https://github.com/minetest/minetest/issues/8145 -- Add setting to hide mature content from ContentDB by rubenwardy 13:31 rubenwardy would be good to have people do some testing with CDB on windows 13:31 * rubenwardy looks at Fixer 13:31 Krock well, an RC is needed 13:31 rubenwardy yeah 13:32 rubenwardy I posted an announcement on the discord 13:34 Krock preparing a new PR to extract the most needed changes from #7348 for the release 13:34 ShadowBot https://github.com/minetest/minetest/issues/7348 -- Protocol cleanups: Remove legacy access denied, legacy HUDs; improve damage & HP values by SmallJoker 13:34 rubenwardy someone posted this, which also has an issue https://cdn.discordapp.com/attachments/369137254641303560/541486683862990863/unknown.png 13:34 rubenwardy cool 13:34 Krock numberZero already has a fix for that 13:34 Krock although it may require disabling fast faces 13:35 Fixer rubenwardy: i forgot what was unfixed, what should I checK? 13:36 rubenwardy https://cdn.discordapp.com/attachments/369137254641303560/541515829141962762/unknown.png 13:36 rubenwardy Fixer: well, try installing random shit from CDB on windows 13:36 rubenwardy and renaming 13:36 rubenwardy and enabling 13:36 rubenwardy and deleting 13:36 rubenwardy etc 13:36 rubenwardy and also go into mod.conf / game.conf / modpack.conf / etc and change "release" to a lower number 13:37 rubenwardy and checking that the button changes from "uninstall" to "update" in the contentdb menu 13:37 rubenwardy and update works 13:37 rubenwardy oh, and please 13:37 rubenwardy maybe I should make an issue for this 13:40 rubenwardy issue maybe explained better #8165 13:40 ShadowBot https://github.com/minetest/minetest/issues/8165 -- Testing ContentDB on non-Linux platforms 13:45 Krock cannot split the changes easily. Please review #7348 asap so we don't need to deal with the HP limits after the release 13:45 ShadowBot https://github.com/minetest/minetest/issues/7348 -- Protocol cleanups: Remove legacy access denied, legacy HUDs; improve damage & HP values by SmallJoker 13:45 Krock that would be quite a pain to work around it 13:48 rubenwardy https://github.com/minetest/minetest/pull/7348/files#diff-90993ca3bb550ffc1c77a1578f3545d3R1494 13:49 rubenwardy result_hp is unsigned, I imagine that the other variable is the one that matters though 13:49 rubenwardy https://stackoverflow.com/questions/5328815/what-happens-when-i-subtract-an-unsigned-integer-from-a-signed-integer-in-c 13:50 rubenwardy "In your example, the signed value is converted to unsigned (by taking it mod UINT_MAX+1), then the subtraction is done modulo UINT_MAX+1 to give an unsigned result." 13:50 Krock okay, going to sort out the issues step by step 13:52 rubenwardy is it worth incrementing PROTOCOL_VERSION one last time? 13:53 rubenwardy there's been lots of random breaks in 37, iirc 13:53 rubenwardy idk actually 13:55 rubenwardy - s16 newhp = ((s32) damage_per_second > m_hp ? 0 : m_hp - damage_per_second); 13:55 rubenwardy nicceee 13:56 rubenwardy Unarelith: https://github.com/minetest/minetest/pull/8162/files#diff-5a0086397befe64d1ec2a542013d93c9R58 13:56 rubenwardy are you OK with that attribution 13:57 rubenwardy or would you prefer "Unarelith" 13:57 rubenwardy oh, I'm also missing a space 13:57 Unarelith rubenwardy, oh, thanks, but my name is "Quentin Bazin", not "Quentinbazin" :p 13:57 Unarelith you can put "Quentin Bazin (Unarelith)" 13:57 rubenwardy cool 13:58 Unarelith but ty, I haven't done the real cleanups yet, still waiting for 5.0.0 release :p 13:58 Unarelith made a lot of progress on my own project while waiting: https://github.com/Quent42340/OpenMiner 13:59 Unarelith and here's my formspec equivalent: https://github.com/Quent42340/OpenMiner/wiki/Lua-API-Overview#custom-gui 14:00 rubenwardy nice 14:01 Unarelith ty, I'm still having a hard time with lighting though: https://github.com/Quent42340/OpenMiner/issues/21 14:01 Krock rubenwardy: partial patch: https://github.com/SmallJoker/minetest/commit/4edcd3406 Are you keen on reviewing this one? 14:02 rubenwardy I've been reviewing the PR 14:02 Krock this should fix partially the HUD issues with ID=0 14:03 rubenwardy argh 14:03 Krock I know. I also saw that it must be split to not accidentally run into issues 14:03 rubenwardy everytime I expand a snippet, it resets to the top 14:03 Krock I will adjust the PR afterwards to clean out the less important HP type cohesion issue 14:33 ANAND rubenwardy: Could you change mine to "ANAND (ClobberXD)"? It'd look more consistent that way :) 14:34 rubenwardy ah yeah 14:34 rubenwardy done 14:34 ANAND Yay :) 14:39 Fixer that shifting to the side during multijumping up or down is pissing me off 14:42 Fixer rubenwardy: i'm on newest git, no shaders, intel hd, having no ripped edges like on that discord link, that dude needs to create an issue ASAP 14:43 nerzhul rubenwardy: i like your commit messages 14:43 rubenwardy thanks 14:44 ANAND lol 14:54 rubenwardy Krock: misread your message earlier 14:54 rubenwardy ending my MT spree now, will maybe have a look later 14:55 Krock still working on it. take your time :) 15:18 nerzhul we are close to release now :) 15:18 sfan5 when was the release supposed to be 15:27 rubenwardy today] 15:27 rubenwardy sfan5: 15:27 sfan5 oh 15:35 Krock lol rubenwardy. those commit messages are somewhat xkcd-ish 15:36 rubenwardy yeah :) 16:08 fwhcat Hi, so you jump from 0.4.17 to 5.0.0 ? 16:14 Krock from 0.4.17.1 to 5.0.0 yes 16:15 nerzhul it's supposed to be today, but are we ready ? 16:15 fwhcat nice! 16:16 nerzhul https://github.com/minetest/minetest/milestone/9 16:16 nerzhul it seems 3 PR are waiting to be merged/fixes 16:16 nerzhul and we are okay 16:18 Krock nerzhul: it would be great to have #8167 in too. otherwise it will have to wait for the next breakage again 16:18 ShadowBot https://github.com/minetest/minetest/issues/8167 -- Consistent HP and damage types by SmallJoker 16:19 nerzhul go ahead tag milestone 16:23 Krock #8019 has plenty of testing results. I like that. Seems ready 16:23 ShadowBot https://github.com/minetest/minetest/issues/8019 -- Use true pitch/yaw/roll rotations without loss of precision by pgimeno by pauloue 16:47 rubenwardy "* Attachment and player positions have been shifted by 1 node, to allow support for custom player selection boxes. Fix: update default and player_api, add `10` to any attachment positions, shift the origin of player models to the feet" 16:47 rubenwardy is this correct, Krock (?) 17:00 rubenwardy errrr 17:00 rubenwardy https://hosted.weblate.org/projects/minetest/minetest/#alerts 17:00 rubenwardy we need est back lol 17:01 p_gimeno where's that sed command? 17:03 p_gimeno I'm good at regexps and fairly good at sed commands, but I don't see any anywhere in the MT repo 17:04 rubenwardy I think it's in weblate 17:05 p_gimeno can it be posted here, or to me in a PM? 17:06 rubenwardy Idk 17:07 rubenwardy I don't have access to the weblate, it could be in the source code repo 17:25 rubenwardy debug.txt from user https://gist.github.com/rubenwardy/a688b7c86898de1ccf44f143d9b7459c 17:25 rubenwardy Maybe something off with unifieddyes? (VanessaE) 17:27 VanessaE idk what those "sRGB" messages are from and the warning about the palette is safe to ignore. 17:28 rubenwardy https://cdn.discordapp.com/attachments/369137254641303560/541671240318976033/unknown.png 17:30 Krock rubenwardy: correct 17:30 rubenwardy cool 17:30 rubenwardy thanks 17:31 rubenwardy pushing trivial bug fix in 5: https://github.com/rubenwardy/minetest/commit/9a071d66a59bd0db72d09a3ca75b2ab9247dda92 17:32 Krock it's exactly what happens in boost_cart for 0.4.x and 5.0.0-dev compat. https://github.com/SmallJoker/boost_cart/blob/master/functions.lua#L21 17:33 Krock rubenwardy: why is it not closed when the download succeeded? 17:33 Krock nvm. the variable is destructed 17:33 rubenwardy yeah 17:33 Krock needs closing forehand to delete it 17:34 Krock lgtm 17:36 rubenwardy cool cool 17:36 rubenwardy pushing 17:37 rubenwardy my changes/commit number is quite a lot larger than you are paramat, all these bug fixes are changing that 17:37 p_gimeno nice the minetest downloads page is back on the top of the google search results 17:38 rubenwardy :D 17:43 paramat feel free to merge #8145 no objections 17:43 ShadowBot https://github.com/minetest/minetest/issues/8145 -- Add setting to hide mature content from ContentDB by rubenwardy 17:43 rubenwardy ok, merging in 10 17:43 rubenwardy I really don't want to hardcode the filter, because it's the sort of thing a proprietary application would do 17:43 rubenwardy :( 17:44 paramat no prob, we can discuss what is in the android default independently 17:45 rubenwardy yeah 17:45 rubenwardy luckily the way it is designed allows us to retroactively change the default 17:45 rubenwardy +s 17:48 paramat so, does any core dev fully understand #8019 ? i'll probably be approving but am requesting the second approval is from someone who fully understands everything 17:48 ShadowBot https://github.com/minetest/minetest/issues/8019 -- Use true pitch/yaw/roll rotations without loss of precision by pgimeno by pauloue 17:48 rubenwardy I don't lol 17:51 paramat maybe sfan5? ^^ 17:51 p_gimeno https://github.com/minetest/minetest/pull/8019#issuecomment-460072630 17:51 p_gimeno I've updated it with diagrams 17:52 rubenwardy well, I understand matrix transformations 17:52 rubenwardy just not the code 17:53 sfan5 me neither 17:54 p_gimeno is the problem the scene graph itself? 17:55 p_gimeno the alternative to merging 8019 is to revert #7989 and #7395 17:56 ShadowBot https://github.com/minetest/minetest/issues/7989 -- Fix entity rotation in existing worlds by SmallJoker 17:56 ShadowBot https://github.com/minetest/minetest/issues/7395 -- Add Lua methods 'set_rotation()' and 'get_rotation()' by CoderForTheBetter 17:56 rubenwardy I had a look through the PR, and the matrix maths all looks correct 17:56 rubenwardy the issue is more that I don't know the surrounding code 17:56 rubenwardy I also don't know too much about rotation 17:56 paramat i really don't want to revert 17:57 paramat i understand the rotation issues 17:58 paramat i think between us all we'll manage to approve it 18:12 rubenwardy so, may I do a RC1 soonish? 18:12 rubenwardy only thing I can't do are Android and MacOS builds 18:13 paramat fine for me 18:13 nerzhul i can generate a debug build this evening 18:22 rubenwardy If it helps: http://www.askaboutgames.com/pegi-rating/ 18:22 rubenwardy Not an expert, but would guess it'd fall under the "user-generated/curated content" definition and need a "Parental Guidance Recommended" sticker. But I'm not an expert on this. 18:22 rubenwardy More general info: https://pegi.info/ 18:22 rubenwardy asked about CDB 18:23 rubenwardy Parental Guidance is PEGI-7 18:23 rubenwardy I think 18:23 rubenwardy actually, idk 18:24 paramat thanks 18:24 paramat heh pegi 3 is toddlers 18:24 rubenwardy yeah 18:27 paramat pegi 7 would be fine, it would be good to avoid higher 18:30 rubenwardy oh btw, that above is a quote 18:30 rubenwardy above "asked about..." and below join 18:37 Andrey01 hi, is 5.0.0 going to be released today? 18:38 paramat no 18:39 Andrey01 but when then? 18:41 paramat i'm guessing 1-2 weeks 18:41 rubenwardy Andrey01: there will be a release candidate today 18:41 rubenwardy which is basically a pre-release version 18:41 Andrey01 but as i saw you have merged almost all prs 18:41 Andrey01 oh 18:41 rubenwardy basically "this is a version which could become 5.0.0, but there are still remaining issues" 18:42 rubenwardy "please test and let us know of anymore" 18:45 Andrey01 i had been testing a bit, but i didn`t find out any bugs 18:45 Andrey01 and Content Store looks like very nice now 18:48 rubenwardy :D 18:49 p_gimeno I'd suggest excluding the set_rotation function for the pre-release, you don't want people setting rotations with z!=0 and complaining later 18:49 p_gimeno just disabling it should suffice 18:50 rubenwardy there's a warning in the forum topic about it 18:51 p_gimeno or perhaps patching it so it doesn't work if given a z!=0 18:52 rubenwardy what happens if you do (0, 0, 90') 18:55 p_gimeno yaw is no longer yaw 18:55 p_gimeno and it will be incompatible with 8019 18:57 rubenwardy ah 18:58 p_gimeno https://gitlab.com/pgimeno/minetest/commit/ac9d90fc8b432db3d3354926df260d667a58b14a 18:58 p_gimeno (caveat emptor: I haven't even compiled it) 18:59 p_gimeno that, plus a blocker PR to remove it 19:00 p_gimeno or the removal can be added to 8019 19:02 paramat merging game#2293 in 5 mins 19:02 ShadowBot https://github.com/minetest/minetest_game/issues/2293 -- Tweak permafrost and stones textures by random-geek 19:04 p_gimeno compiled and tested, it works 19:55 rubenwardy merging trivial bug fix in 10 https://github.com/rubenwardy/minetest/commit/5b965e08bd8795c71ab9a6d9474c2cf3bd3a7d17 20:28 sofar so far the master branch has been working well for me, I've been doing some testing myself 20:29 sfan5 it's supposed to do that 20:29 sfan5 ;) 21:18 entuland hey guys is there anything like an apple version of minetest? I'm hearing from players playing some versions on it but they seem just broken, and I can't find any mention in the website 21:19 entuland I mean, a working official version 21:21 sfan5 for iOS? no 21:21 entuland okay 21:25 rubenwardy entuland: problem is that the app store doesn't allow GPL software 21:25 rubenwardy not sure if that also covers LGPL actually 21:26 rubenwardy and also that we don't even have the capability to support MacOS 21:26 rubenwardy let alone iOS 21:26 entuland I was able to find a mention of your nick in a discussion referring to your subreddit but wasn't able to find the actual source there, rubenwardy 21:26 rubenwardy huh 21:27 entuland thanks for the confirmation, that's the same info I gathered from that discussion 21:27 rubenwardy nerzhul: please may you provide an Android test build? 21:30 nerzhul rubenwardy okay 21:30 nerzhul pushing a build on my machine 22:15 rubenwardy argh 22:15 rubenwardy I accidentally tagged HEAD~2 as 0.4.16 a while ago 22:15 rubenwardy so when I did checkout 0.4.16, it got 5.0.0 22:15 rubenwardy annoying 22:24 VanessaE I hope you fixed it :) 22:25 rubenwardy this was local 22:25 rubenwardy :) 22:31 VanessaE come on come on release -rc1 already so I can update and piss off my users :) 22:56 Lone-Star for the most part 5.0.0 is pretty solid, only a few things broke in some mods, mostly moreblocks as some blocks don't get placed in the right direction and slabs dont stack 22:57 Lone-Star most of the blocks I use in moreblocks got added to MTG anyways 22:58 VanessaE Lone-Star: that rotation bug happens in 0.4.17 also, and no most of them were not. 22:59 VanessaE moreblocks slabs haven't been stackable for a few years now 22:59 rubenwardy !title https://forum.minetest.net/viewtopic.php?f=18&t=22078 22:59 ShadowBot rubenwardy: Minetest 5.0 release candidate 1 (5.0.0-rc1) - Minetest Forums 22:59 VanessaE \o/ 23:08 VanessaE aw. my little hotbar expansion didn't make it into the changelog? :< 23:10 Lone-Star like from you mp_extras? 23:11 VanessaE nah 23:11 nerzhul merging #8169 23:11 ShadowBot https://github.com/minetest/minetest/issues/8169 -- Update manpage by pauloue 23:11 VanessaE just a minor expansion of 23 -> 32 hotbar slots in the engine. 23:12 nerzhul and #8172 23:12 ShadowBot https://github.com/minetest/minetest/issues/8172 -- Main menu: Fix cloud color by random-geek