Time  Nick       Message
13:17 Krock      why was #3167 reopened? This is already implemented
13:17 ShadowBot  https://github.com/minetest/minetest/issues/3167 -- Feature request: Confirm password for account creation
14:00 Krock      merging non-feature PR #8086 in 10 minutes
14:00 ShadowBot  https://github.com/minetest/minetest/issues/8086 -- Remove incorrect feature flag 'chat_send_player_param3' and document versions by pauloue
14:10 Krock      !tell paramat So PR 8101 (suss valleys) is code movement only? I'm concerned that generateTerrain was changed in behaviour - is the underground also identical (surface already is)
14:10 ShadowBot  Krock: O.K.
14:16 Krock      merging...
17:29 paramat    Krock . oh duh, i decided #3167 wasn't a duplicate but then somehow thought it therefore had to be reopened. closed
17:29 ShadowBot  https://github.com/minetest/minetest/issues/3167 -- Feature request: Confirm password for account creation
17:31 paramat    valleys underground is identical yes because all caves are generated by external code shared by the mapgens
17:34 paramat    it's mostly code movement and optimisation but also some minor bugfixes, i'll detail all the changes in the thread sometime
17:38 Krock      it looks good already, especially the comparison images. nice efforts, but I'd need to dig a bit into the code to understand whether everything's OK
17:43 paramat    yeah, that's the hard part
17:43 paramat    it's a significant rewrite so not easy to verify
17:44 paramat    i mean, it took me years to actually understand the mess that was the previous code
17:45 paramat    i had to reduce everything down to absolute basic generation to understand it, then re-add everything else onto that
17:46 paramat    however, i'm very confident of what i did, and know what i'm doing 100% (for a change)
18:08 paramat    +1 for #8089
18:08 ShadowBot  https://github.com/minetest/minetest/issues/8089 -- [Do not squash me] Fix group setting bugs by SmallJoker
18:10 paramat    will merge that in 15 mins
18:15 Krock      thank you. will look at the mapgen PR tomorrow
18:19 paramat    no rush, not for 5.0.0
18:25 paramat    merging 8089
18:25 paramat    hm can't squash, will have to do it the old way
18:31 Krock      curl -Ls https://github.com/minetest/minetest/pull/8089.patch | git am -3
18:31 Krock      git push
18:46 paramat    merged
19:12 rubenwardy the rating on google play would probably mean that I would have to remove any gun mods from CDB
19:12 rubenwardy let alone this: https://content.minetest.net/packages/LorenzoVulcan/drug_wars/
19:13 rubenwardy not sure how play manages downloadable content in-game
19:16 rubenwardy one way around this could be to remove CDB support from the android port, and instead link to another app on the play store
19:16 rubenwardy ;)
19:18 rubenwardy Actually, I think mt already violates this anyway due to servers
19:42 paramat    a rise in 'suitible for' rating could really hurt downloads, i think it's more important than allowing more mature content
19:43 rubenwardy yeah
19:43 rubenwardy but, we may be violating it already
19:43 paramat    also a little concerned about WTFPL licenses and schools
19:43 rubenwardy as servers may contain blood and gore and such
19:43 rubenwardy not sure how content ratings work if you can access and download content like that
19:45 rubenwardy pegi 3, our current rating, means that you can't have any violance, unless it's "comical"
19:45 rubenwardy heh
19:45 paramat    yeah it's comical in MT
19:46 rubenwardy not on necessarily servers though
19:46 rubenwardy for example, shooter by default has blood
19:46 paramat    hmm yeah
19:46 rubenwardy also, I'm not sure pegi 3 is even right given that it's possible to chat with people in the app
19:47 paramat    body part particle spawners