Time  Nick       Message
00:00 paramat    will merge #7720 in 15 mins, trivial docs PR
00:00 ShadowBot  https://github.com/minetest/minetest/issues/7720 -- document inventory sending behaviour by zeuner
00:25 p_gimeno   paramat: BTW, the patch in 7988 was mine, but the commit wasn't :) the usual way to handle it is to credit the author, not to set them as authoring the commit, e.g. "Applied patch by <author> to do this and that"
00:26 rubenwardy if all the content is by the author, then I'd have the author be the author, and the commiter be the commiter
00:32 paramat    hmm
00:33 p_gimeno   PostgreSQL is my model of professional behaviour, this is an example of how they handle it: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=ecfd5579561c3e720e696a42aadcd4b5b52aa581
00:33 paramat    i can see sense in both arguments, but i think it's ok as it is as rubenwardy states
00:35 paramat    and nerz asked for this too
00:36 paramat    merging 7720
00:39 paramat    merged
01:01 p_gimeno   it just feels very wrong to me, a bit like impersonating me. Next time I'll always push to Gitlab so you can have a commit that I actually authored, and I ask you to please use that.
01:02 paramat    ok, i'll change it
01:03 paramat    .. as either way is ok
01:03 p_gimeno   I appreciate that
01:10 paramat    done
01:13 p_gimeno   thank you
11:31 nerzhul    pushing #7988 to master
11:31 ShadowBot  https://github.com/minetest/minetest/issues/7988 -- IEEE floats: Fix unit test in release mode by paramat
11:32 nerzhul    p_gimeno yep, and it's also easy to merge because we can download the patch directly
11:32 nerzhul    but if you contribute to issues, with not on PR on GH ?
11:34 p_gimeno   because I've closed my repos and I will eventually delete my user there
11:35 p_gimeno   I'm really hoping for #7901 to become a reality
11:35 ShadowBot  https://github.com/minetest/minetest/issues/7901 -- Accepting PRs/patches from non-Github users
11:41 nerzhul    i know it's proprietary but it is since the beginning. JS is used everywhere, and on gitlab too i think
11:41 nerzhul    gitlab accepts mail communication, and merge request through mail
12:44 ANAND      Would anyone be able to take a look at #7738? It's (hopefully) close to being approved by paramat.
12:44 ShadowBot  https://github.com/minetest/minetest/issues/7738 -- Spatial Vectors: Add vector.angle(a, b) by ClobberXD
18:46 Krock      p_gimeno: so it's just that single line "int exp;" or anything else? I don't get any warning here (GCC 7.3.0)
18:48 Krock      meh whatever. pushing that trivial fix in 5 minutes
18:53 Krock      pushing..
18:53 p_gimeno   Krock: it's that single line. My compiler seems to think that frexpf might not modify it, therefore it thinks later use is uninitialized.
18:53 Krock      80eb762
18:54 Krock      err
18:54 p_gimeno   thanks :)
18:54 Krock      it's a bit confusing that you commented on a specific commit (which is already outdated)
18:55 p_gimeno   uh, sorry about that, I missed that you made changes later
19:05 Krock      will merge #7832 in 10 minutes
19:05 ShadowBot  https://github.com/minetest/minetest/issues/7832 -- Add command line option to load password from file by kkabrams
19:15 Krock      merging...