Time Nick Message 00:00 p_gimeno the node's scale is correct, but it is drawn out of scale for some reason that I can't find 00:02 p_gimeno I've updated the patch, by the way 00:03 p_gimeno there was an issue with the hand/tool of 1st person view, it wasn't visible, but that's fixed now 00:08 CoderForTheBette Great. How are you testing scale? Does it have to do with lua mods and the visual size? Like here https://github.com/minetest/minetest/blob/master/src/client/content_cao.cpp#L687 ? (Note, I don't think that has to do with dropped items though). I'm just jumping in on this, sorry if you already checked this stuff. 00:10 p_gimeno scale is obeyed for other types of CAOs, but not for m_wield_meshitem for some reason 00:10 p_gimeno the scale is set properly in the node, and I can read it back without problems 00:10 p_gimeno by node I mean scene node 00:11 CoderForTheBette Maybe it has to do with how the images are made into meshes? I don't know where that meshing code is (if there is any, maybe Irrlicht has a function for 3-D objects from images, I don't think so) 00:12 p_gimeno That code is in wieldmesh.cpp but I haven't been able to find anything relevant. It works if the parent is the scene, but not if the parent is the IDummyTranslationSceneNode. 00:14 p_gimeno Transformation* not Translation 00:14 p_gimeno gosh I'm tired 00:18 CoderForTheBette Hmm. I vaguely remember something about Irrlicht and children nodes not scaling correct when attached. This might relate a little bit: https://github.com/minetest/minetest/issues/7897 (not sure though) 00:20 p_gimeno thanks 00:27 p_gimeno I think I found it... 00:27 p_gimeno I was setting the parent of the wrong node 00:28 CoderForTheBette Ah, hopefully that is it. However, it is still weird that those meshes are scaled like that in the issue I linked. I wonder why... 00:29 CoderForTheBette All I could find so far is https://github.com/minetest/minetest/blob/a833bee9edaeb6df69d1e510759a7b33915a41e0/src/client/wieldmesh.cpp#L277 00:29 CoderForTheBette Where WIELD_SCALE_FACTOR_EXTRUDED = 40.0 00:32 p_gimeno well, the mesh as it was being rendered was exactly 3 nodes wide 00:32 p_gimeno (before the fix, that is) 00:43 p_gimeno patch updated with the fix, and /me needs some rest now 00:43 p_gimeno (also simplified, down to 3 files changed) 02:12 ANAND Would anyone be able to take a look at #7960? It's very trivial, so there's nothing much to review. 02:12 ShadowBot https://github.com/minetest/minetest/issues/7960 -- Replace all occurrences of `func` with `function` in docs by ClobberXD 07:21 ANAND Rebased #7960 07:21 ShadowBot https://github.com/minetest/minetest/issues/7960 -- Replace all occurrences of `func` with `function` in docs by ClobberXD 08:40 nerzhul nice registry.gitlab.com/minetest/minetest/minetestserver:master is now available :) 08:40 paramat ANAND yes will review7960 (again) 08:41 ANAND Alright 08:43 nerzhul sfan5: i will just tweak the docker image name and add a docker tag linked to commit , because with current implementation we only have branch/tag or latest but not the exact commit 08:43 nerzhul https://user-images.githubusercontent.com/119752/49857177-2cc7ba80-fdf2-11e8-8e85-07e1ceae0a44.png works 08:43 nerzhul and here are iamges https://gitlab.com/minetest/minetest/container_registry 08:48 paramat merging #7960 08:48 ShadowBot https://github.com/minetest/minetest/issues/7960 -- Replace all occurrences of `func` with `function` in docs by ClobberXD 08:51 paramat merged. long overdue improvement 08:51 ANAND :D 09:54 nerzhul ty paramat 10:34 nerzhul sfan5 i just published #7969, what do you think about it ? 10:34 ShadowBot https://github.com/minetest/minetest/issues/7969 -- Add docker image documentation by nerzhul 17:42 Unarelith rubenwardy, opened #7970 to discuss about a potential formspec refactoring 17:43 ShadowBot https://github.com/minetest/minetest/issues/7970 -- Formspec refactor proposal by Quent42340