Time  Nick             Message
00:45 paramat          hi rubenwardy are you uncertain about approving #7949 ?
00:45 ShadowBot        https://github.com/minetest/minetest/issues/7949 -- Force-disable client-provided CSM until server-sent CSM completed by paramat
02:56 paramat          merging #7870
02:56 ShadowBot        https://github.com/minetest/minetest/issues/7870 -- Add 'item' visual type by GreenXenith
02:57 paramat          merged
02:58 paramat          +1 for #7891
02:58 ShadowBot        https://github.com/minetest/minetest/issues/7891 -- Fix ContentDB packages timing out by using download_file instead by rubenwardy
03:19 ANAND            Yay, thanks
04:42 paramat          merging 7891
04:43 paramat          merged
04:44 paramat          down to 1 blocker
04:55 ANAND            Hurray!
09:48 nerzhul          paramat: blocker issue ou blocker feature ?
12:15 ClockGen         My connection is terrible and it iterrupts often but I'm checking irc logs
12:15 ClockGen         Oh well apparently my previous message wasnt sent
12:15 ClockGen         Hey guys, I still have problems with packaging for f-droid. It compiles fine, but it segfaults at the start. I'm compiling code from tag 0.4.17.1, maybe apks attached at release binaries were compiled with different commit or with some manual changes?
12:17 sfan5            what does logcat say?
12:20 ClockGen         Idon't have access to my computer right now, but I recall it was segfaulting with null pointer dereference
12:21 ClockGen         In libminetest.so
12:26 ClockGen         I found a commit right before 0.4.17.1 tag that was probably fixing this exact problem https://github.com/minetest/minetest/commit/119aa5c91977ce5381e399e21eabf390e5cb5f5e
12:26 ClockGen         But for some reason it still happens
12:56 nerzhul          ClockGen the commit with the version code increase is the commit you want to reproduce
12:56 nerzhul          because it's the last thing i do to permit uploading to play store
12:59 ClockGen         Yes, that's the commit I'm using
12:59 ClockGen         https://github.com/minetest/minetest/commit/6dc7177a5de51f1329c1be04e7f07be64d5cc76c
12:59 ClockGen         This one, right?
13:01 nerzhul          https://github.com/minetest/minetest/tree/stable-0.4
13:01 nerzhul          take that branch
13:01 nerzhul          the last commit is the latest release
13:05 ClockGen         There's a lot of version code updates, it's still the same 0.4.17.1 that's compatible with release servers?
13:07 nerzhul          0.4.17.1 is compatible with 0.4.16 servers at least in terms of backward compat
13:22 ClockGen         Just gotta be sure that there will be no incompatibility between google play and fdroid users
13:23 ClockGen         Anyway thanks, I'm building suggested commit now
14:34 Unarelith        nerzhul, I'm setting up VirtualBox to test #7768, so FreeBSD for the server and some random Linux for the client?
14:34 ShadowBot        https://github.com/minetest/minetest/issues/7768 -- Network: Send IEEE floats by SmallJoker
15:21 nerzhul          Unarelith ty for your time, i don't know if that works wit ha VM, i hope yes
15:21 nerzhul          yep
15:21 nerzhul          also there is a minetest freebsd port if you want to setup your freebsd faster
15:21 nerzhul          pkg install minetest-server
15:23 Unarelith        I already installed everything :p
15:23 Unarelith        it's compiling
15:23 Unarelith        and pkg install minetest-server doesn't work anyway
15:28 nerzhul          okay :p
15:29 nerzhul          mayube it's just minetest
15:29 nerzhul          i don't remember :p
15:36 Unarelith        nerzhul, so basically if it doesn't work what am I supposed to see?
15:36 nerzhul          the main issue i saw it a chunk position issue or a SAO object position issue
15:37 nerzhul          don't hesitate to install tenplus1 mobs mod to ensure you have sufficient test data
15:39 Unarelith        ok will do
15:40 Unarelith        it's currently the last blocker for 5.0.0, could be nice if it works
15:42 nerzhul          last feature PR yes, but i think we have issues which are not tested
15:48 Unarelith        there's a problem with BSD_ICONV_USED, I had to set it manually
15:50 rubenwardy       #7967
15:50 ShadowBot        https://github.com/minetest/minetest/issues/7967 -- Package manager doesn't track packages reliably
15:50 nerzhul          Unarelith: at compilation time ?
15:51 nerzhul          rubenwardy: what do you mean by track ? on disk ?
15:51 nerzhul          i understand your point but where is the contention ? can you be more precise on the issue ?
15:51 Unarelith        nerzhul, it's a macro, so... yes
15:51 rubenwardy       yes
15:51 nerzhul          Unarelith: Which FreeBSD version do you use ?
15:52 nerzhul          rubenwardy where does the mod comes from ?
15:52 nerzhul          it's a problem in the contentdb ?
15:52 rubenwardy       contentdb
15:52 rubenwardy       no
15:52 rubenwardy       it's a problem in Minetest
15:52 nerzhul          can't you have modpack and mod types ?
15:52 nerzhul          okay your problem is the FS storage then ?
15:52 Unarelith        nerzhul, 11.2
15:52 rubenwardy       no, because users are sutpid
15:52 nerzhul          i said that about CSM but it seems no :D
15:52 rubenwardy       people always mark modpacks as mods in MT
15:52 nerzhul          #troll
15:53 nerzhul          when they register in content db ?
15:53 rubenwardy       because modpacks are both a player concept and a technical organisation
15:53 nerzhul          can't you just prefix directory with modpack when you know it is ?
15:53 nerzhul          or you don't have a such information
15:54 nerzhul          also, what is packageID format ?
15:54 rubenwardy       it's an integer
15:55 rubenwardy       the package manager doesn't support manually installed content because it doesn't know who made it, so can't match it up with the package
15:55 rubenwardy       the current code prepends "mp_" to the name, but still has some issues
15:56 rubenwardy       I don't have time to talk or think about this now
15:57 nerzhul          then why do you link it ? :p
15:58 nerzhul          i think the folder name is a bad idea, you should rely on a metadata in the mod folder (like a package.json for npm)
15:58 rubenwardy       because Unarelith mentioned that the float issue was the only blocker
15:58 rubenwardy       it doesn't rely on the folder name, it looks in the config folder
15:58 rubenwardy       mod.conf or modpack.conf with the PR I made
16:00 Unarelith        how should I run the server to use minimal? I'm using ./bin/minetestserver --gameid minimal but it says it can't find the game
16:03 nerzhul          Unarelith i suggest to use a minetest_game with mobs to have multiple SAO and game features
16:04 nerzhul          to trigger various float things
16:05 Unarelith        nerzhul, the server still can't find games
16:05 Unarelith        or I'm doing something wrong
16:06 nerzhul          i can't remember where does it search games
16:06 nerzhul          are you on the src root folder with games/minetest_game inside ?
16:06 Unarelith        yep
16:07 nerzhul          let me some minutes to check the code for BSD
16:08 nerzhul          Unarelith i see an interesting feature
16:08 nerzhul          define MINETEST_SUBGAME_PATH
16:09 nerzhul          i don't remember we had that :p
16:10 nerzhul          else it seems on FreeBSD it's not very ncie
16:10 nerzhul          std::string path_user = "..";
16:10 nerzhul          it's the handled case
16:10 Unarelith        I just installed the game in the os
16:10 nerzhul          you have choice: use the env variable i provided
16:11 Unarelith        though, I'm getting a timeout when I connect to server
16:11 nerzhul          or run minetest from bin/ directory
16:11 nerzhul          to make minetestserver look on the upper folder/games
16:11 nerzhul          it's not a very nice option
16:12 nerzhul          i should add a portability for BSD conventions
16:12 Unarelith        hmm I did something wrong, but I can't see where
16:13 Unarelith        I can ping between machines, I thought it would be enough but seems like I was wrong
16:13 nerzhul          what is your virtualisation soft ?
16:13 Unarelith        VirtualBox
16:13 nerzhul          okay
16:14 nerzhul          your primary interface it in nat mode ?
16:14 Unarelith        yup it's NAT by default anyway
16:14 nerzhul          it's the problem
16:14 nerzhul          vbox is shit
16:14 nerzhul          when you are in nat host <-> guest communication doesn't work
16:14 nerzhul          add a new network interface with a private network with dhcp
16:14 nerzhul          and communicate on that interface instead
16:14 Unarelith        I'm trying guest-guest communication actually
16:14 nerzhul          same problem if i remember
16:15 nerzhul          use a private network
16:15 Unarelith        and how do I do that? :')
16:16 nerzhul          google: vbox create private network interface
16:16 nerzhul          :)
16:16 nerzhul          i use libvirt on my linux host it's better but for advanced users (with virt-manager it's a vboxlike)
16:28 Unarelith        nerzhul, still timeout
16:28 Unarelith        idk what to do
16:29 nerzhul          do you connect using the private network ?
16:30 nerzhul          i push a trivial portability fix on game dtection for BSDs
16:30 nerzhul          our code is portable but doesn't select that on BSDs
16:30 Unarelith        yep
16:30 Unarelith        I can ping between my machines though
16:30 nerzhul          oh before pushing just to be sure
16:30 nerzhul          Unarelith can you test a compilation thing for me ?
16:31 nerzhul          on porting.cpp L403
16:31 nerzhul          (on your freebsd compilation build)
16:31 nerzhul          can you append " || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__DragonFly__)" (without quotes)" after the linux condition
16:31 nerzhul          and build ?
16:31 nerzhul          it should work
16:31 nerzhul          if okay i push that to master to permit a better minetest folder detection onBSD
16:33 Unarelith        nerzhul, it compiles
16:33 nerzhul          nice
16:34 nerzhul          i push that to master
16:34 Unarelith        ok
16:34 nerzhul          better BSD support
16:34 Unarelith        though I'll need you help to fix my timeout issue, I'm really bad at networking
16:35 Unarelith        *your
16:35 nerzhul          both machines have a private network interface with specific IP ?
16:35 nerzhul          firewall are disabled ?
16:35 nerzhul          https://github.com/minetest/minetest/commit/a8575295d5f577b245b932bac118ef077ea96c08 pushed
16:35 nerzhul          (Unarelith ensure it was your change :) )
16:36 Unarelith        yep it's ok
16:36 Unarelith        I don't know about firewalls
16:36 nerzhul          merging #7945
16:37 ShadowBot        https://github.com/minetest/minetest/issues/7945 -- lua_api.txt: Various fixes and improvements by pauloue
16:38 nerzhul          what is your virtualization host ?
16:38 Unarelith        ArchLinux
16:38 nerzhul          okay it's like me
16:38 nerzhul          have you got many VM on vbox or it's a first try to help us ?
16:42 Unarelith        I reinstalled my Arch a few months ago, so it's a fresh vbox install
16:45 nerzhul          okay
16:46 nerzhul          i suggest you to use libvirt & virt-manager instead , install them with pacman and enable libvirt daemon with systemd at least it uses kvm directly and there is no network issue
16:46 nerzhul          i will be afk for a while but you can at least launc this and launch virt maanger to connect to your local libvirt daemon
16:58 p_gimeno         Unarelith: if the BSD machine has a 'endian' command, could you run it please?
17:06 Unarelith        hmm, I can't move the view correctly, but it's probably a problem with the VM
17:06 Unarelith        I can't see the mobs of mobs_redo even though I added it
17:06 Unarelith        but dropped item looks normal
17:17 Unarelith        p_gimeno, let me check
17:19 Unarelith        p_gimeno, endian says 'little'
17:20 p_gimeno         yeah, I suspected that
17:20 p_gimeno         thanks
17:25 p_gimeno         running it under sparc or mips emulated with qemu would probably be a better test
17:25 p_gimeno         https://stackoverflow.com/questions/2839087/how-to-test-your-code-on-a-machine-with-big-endian-architecture
17:26 Unarelith        but what's the point of being compatible with architectures Minetest will never ever run on?
17:26 * p_gimeno       shrugs
17:26 Unarelith        the best test here could be OSX server and Windows/Linux client
18:07 nerzhul          or linux server mac osx client :)
18:08 Unarelith        would need osx either way
18:40 Krock            nerzhul: I keep removing and adding LuaEntities but it's counting straight up
18:41 Krock            will compare with master
18:43 Krock            actually master does not recycle the IDs either
18:48 p_gimeno         can anyone please tell me where the currently active item is handled for display purposes? my rotations patch doesn't show the hand or the held item
18:51 p_gimeno         I've looked in localplayer.cpp, camera.cpp and wieldmesh.cpp but I can't seem to be able to find it
18:53 Unarelith        p_gimeno, try game.cpp or client.cpp
18:53 Unarelith        and good luck
18:53 p_gimeno         huh
18:54 * p_gimeno       tries, and adds hud.cpp to the list just in case
18:55 rubenwardy       It was in camera last time I checked
18:55 Unarelith        :')
18:56 Krock            although I'm still not very happy about "getAddedActiveObjectsAroundPlayer".. lacks of generic use
18:56 p_gimeno         rubenwardy: thanks, then I must have missed it
18:56 Krock            ^ nerzhul
18:57 rubenwardy       src/client/camera.h:176:	WieldMeshSceneNode *m_wieldnode = nullptr;
18:57 Krock            grep for the inventory animations setting
18:57 p_gimeno         rubenwardy: Camera::drawWieldedTool ?
18:57 p_gimeno         thanks
18:57 Krock            one of the use cases will be the currently selected item
18:58 rubenwardy       so sad, a dead PR: #4297
18:58 ShadowBot        https://github.com/minetest/minetest/issues/4297 -- Add custom wield item animation using linear keyframes (WIP) by rubenwardy
19:00 p_gimeno         rubenwardy: so, wieldmesh.cpp is about that? not about the 3rd person view?
19:00 rubenwardy       the 3rd person view doesn't have an item
19:01 rubenwardy       wieldmesh makes a mesh for an item to be used standalone
19:01 Krock            rubenwardy: this is so sad. Alexa play despacito 2
19:05 p_gimeno         ok, thank you, let's see if I can fix that
19:12 p_gimeno         aaand fixed! thanks again
19:13 nerzhul          Krock yeah i agree with you i just ported the original case, i can rename it to remove player keyword and rename to getAddedActiveObjectAroundPosition
19:13 nerzhul          it's more accurate
19:13 nerzhul          it it fits to you
19:13 nerzhul          except that and code style is this okay to you ?
19:19 nerzhul          or you see an issue ?
19:21 Krock            no, it's fine
19:21 Krock            +1 afterwards
19:23 nerzhul          nice
19:35 Unarelith        Krock, about unified_inventory#118 please tell me what color could be nice since I'm unable to :')
19:36 Krock            *shrug*
19:38 Krock            https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L1918
19:38 Krock            https://github.com/minetest/minetest_game/blob/master/mods/default/init.lua#L20
19:38 Krock            I guess that would be #30434C;#FFF
19:44 Unarelith        Krock, what does ";#FFF" means? and why do you have a black tooltip background on 5.0.0-dev btw?
19:45 Krock            #FFF is the foreground color. white.
19:46 Krock            ; is the copypasta leftover
19:46 Unarelith        oh, ok
19:47 Unarelith        and I have the answer to my other question, my minetest_game is probably outdated
19:48 Krock            although I wonder why you've got to specify the tooltip color
19:48 rubenwardy       the tooltip color is optional
19:49 Krock            in 5.0 everything's white on dark blue anyway (MTG default)
19:49 p_gimeno         rubenwardy: any idea why is there a "wield" CAO type (that uses a WieldMesh node), and how/what for is it used?
19:53 Unarelith        p_gimeno, for entity visual = "wielditem"
19:54 Unarelith        https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L5480
19:56 p_gimeno         thanks, but what is that used for?
19:57 p_gimeno         ah, dropped items according to 'visual
19:57 p_gimeno         '
19:57 Unarelith        p_gimeno, probably for dropped items, I personnally use it in my mod to animate nodes
19:57 p_gimeno         ok, thank you
20:21 Krock            Unarelith: will push the change to make it look like this tomorrow https://i.imgur.com/HAhmYvp.png
20:22 Krock            it'll be the same format as with regular inventory items with the mod name display turned on
21:54 nerzhul          sfan5 are you around ?
21:56 nerzhul          sfan5: see #7968
21:56 ShadowBot        https://github.com/minetest/minetest/issues/7968 -- Add a Dockerfile + gitlab CI build by nerzhul
21:56 nerzhul          i just added a PR to package MT server as a docker file
21:56 nerzhul          docker container with dockerfile*
21:57 nerzhul          with gitlab CI and registry it should just run file and permits to test minetest server easily witout compiling (i know we laso have daily packages haha)
22:58 nerzhul          sfan5 #7968 is now ready for a merge, are you okay ?
22:58 ShadowBot        https://github.com/minetest/minetest/issues/7968 -- Add a Dockerfile + gitlab CI build by nerzhul
22:59 sfan5            LGTM
22:59 nerzhul          merging then
23:01 nerzhul          merging #7958 too
23:01 ShadowBot        https://github.com/minetest/minetest/issues/7958 -- Make MapNode handle paramtype2≠leveled properly by numberZero
23:09 Unarelith        nerzhul, is #7768 ok now? or is there still things to test?
23:09 ShadowBot        https://github.com/minetest/minetest/issues/7768 -- Network: Send IEEE floats by SmallJoker
23:09 nerzhul          i'm tired will re-review tommorow but your tests were very useful ty
23:28 p_gimeno         any idea what part of the code rotates the dropped items?
23:42 CoderForTheBette p_gimeno: I am pretty sure it is in this if-block: https://github.com/minetest/minetest/blob/3bfb8284b868c580b5ec15e732c1d6b379168c2f/src/content_sao.cpp#L438 Not 100% sure though, let me test
23:44 p_gimeno         thank you very much :)
23:44 p_gimeno         looking
23:45 p_gimeno         it would be weird for it to be on the server side
23:48 CoderForTheBette You're right. Something happened to the content_cao file? renamed?
23:49 p_gimeno         moved to client/
23:52 CoderForTheBette Thanks, found it. https://github.com/minetest/minetest/blob/3bfb8284b868c580b5ec15e732c1d6b379168c2f/src/client/content_cao.cpp#L975 I multiplied m_rotation.Y by 20 and dropped items spin very fast.
23:53 p_gimeno         thanks!
23:57 p_gimeno         yes, definitely that... unfortunately, that doesn't explain why the matrix is zero, and why the scale is not obeyed
23:57 p_gimeno         the rotation* is zero