Time Nick Message 00:33 VanessaE so with all these merges, what 00:33 VanessaE ... 00:34 VanessaE what's the expected time to release? 00:40 Unarelith hmm, I'm unable to pull games from ContentDB on master (though mods/modpacks works) 00:51 jas_ haha vanessae 00:51 jas_ couldn't resist ? 00:51 jas_ it's like "i can feel it" 00:52 VanessaE jas_: nah, just curious. also what brainless fucknut put the ' next to Enter... :) 00:55 VanessaE it's paramat's fault, besides :) 00:55 VanessaE (for mentioning it) 00:57 rubenwardy Unarelith: what game are you trying to install? 00:58 rubenwardy I'm going to head off now, anyway. Will read the logs 01:01 paramat it's my fault :) there's no expected time to release, doing so is proved a bad idea, when it's ready 01:02 VanessaE heh ok 01:02 VanessaE I just wondered if it was in the neighborhood of weeks away, or months... 01:02 VanessaE I guess I can assume the latter :) 01:04 paramat but only 2 blocker PRs, so could possibly be as little as 2-3 months if nothing pops up 01:05 VanessaE 2 months to merge 2 blockers eh? ok :) 01:08 paramat big release, will need good testing, long freeze 01:09 Unarelith rubenwardy, tried with all of them, none works 01:09 VanessaE paramat: sounds fair 01:10 * VanessaE tries to think of anything else she could do to make it better 01:43 p_gimeno paramat: please consider this one too: https://notabug.org/pgimeno/minetest/pulls/3 01:45 p_gimeno there's an alternative, namely to having together with each load_mod_xxx, an extra setting called mod_path_xxx in world.mt 01:47 p_gimeno but that will clobber the file somewhat 01:48 paramat ok 01:51 p_gimeno associated issue: #7914 01:51 ShadowBot https://github.com/minetest/minetest/issues/7914 -- Future-proof 5.0.0 for fixing #4183 01:51 paramat yes, i guess it depends on concept approval of 6898 01:53 p_gimeno however https://notabug.org/pgimeno/minetest/pulls/3 is pretty trivial and does little damage; if 6898 is accepted and https://notabug.org/pgimeno/minetest/pulls/3 is not merged, then it must wait to 6.0.0 01:53 paramat marked as blocker to get attention 01:53 p_gimeno thanks 02:03 p_gimeno 6898 already had one approva, by the way 02:03 p_gimeno approval* 02:55 ANAND Could #7923 please be reopened until #7891 has been merged? 02:55 ShadowBot https://github.com/minetest/minetest/issues/7923 -- Content Store: Missing package short descriptions 02:55 ShadowBot https://github.com/minetest/minetest/issues/7891 -- Fix ContentDB packages timing out by using download_file instead by rubenwardy 03:15 paramat looking 03:16 paramat reopened 03:53 ANAND Thanks 04:20 paramat devs, i went through all 300 bugs looking for possible additional blockers. see #2600 i think we should use the full menu for android, at least as the default, and preferably remove all the simple menu code. the app won't be much good if you can't use multiple singleplayer worlds 04:20 ShadowBot https://github.com/minetest/minetest/issues/2600 -- Android: No way to choose singleplayer worlds/subgames 04:24 paramat can't even select subgames either 18:16 Krock Will merge #7934 in 15 minutes if there are no objections 18:16 ShadowBot https://github.com/minetest/minetest/issues/7934 -- Fix android build error messages introduced by commit 5f1cd555cd9d1c64426e173b30b5b792d211c835 by juozaspo 18:29 Krock p_gimeno: How does #7914 help in the future? 18:29 ShadowBot https://github.com/minetest/minetest/issues/7914 -- Future-proof 5.0.0 for fixing #4183 18:29 Krock merging... 18:30 p_gimeno Krock: load_mod_xxxx = path will be considered true instead of false, allowing compatibility in the case of sharing world.mt files if #6898 is merged 18:30 ShadowBot https://github.com/minetest/minetest/issues/6898 -- Allow distinguishing mods by modpack by pgimeno 18:31 Krock so why not combine this change with the PR above? 18:31 p_gimeno #6898 is a complex PR that is unlikely to be merged in 5.0.0 18:32 ShadowBot https://github.com/minetest/minetest/issues/6898 -- Allow distinguishing mods by modpack by pgimeno 18:32 Krock if that's not possible then it means you're relying on that users always have the newest binary to play 18:32 p_gimeno #7914 is far simpler 18:32 ShadowBot https://github.com/minetest/minetest/issues/7914 -- Future-proof 5.0.0 for fixing #4183 18:32 Krock nonetheless I would appreciate to have it properly integrated into 6898 18:33 p_gimeno if neither 6898 nor 7914 go in for 5.0.0, then 6898 will have to wait for 6.0.0 at least 18:33 Krock hmm.. the value can be "nil" (string)? Never seen that 18:33 rubenwardy sounds like a bug to me 18:33 p_gimeno Krock: create a new world, enter the config, save, examine world.mt 18:34 rubenwardy the code is properly doing something like settings:set("thing", dump(bool)) 18:35 p_gimeno Krock: 7914 includes a fix for that 18:36 p_gimeno the bug was here: worldfile:set("load_mod_" .. mod.name, tostring(mod.enabled)) 18:36 rubenwardy aha lol 18:37 p_gimeno if you run the world and exit, it's changed to false 18:37 rubenwardy should be worldfile:set_bool("load_mod_" .. mod.name, mod.enabled) 18:38 Krock world.mt does not contain any load_mod_* entries 18:38 Krock just created one new world 18:38 rubenwardy you need to open and save the config dialog 18:38 Krock ok 18:38 rubenwardy wait 18:38 p_gimeno Krock: now enter the mod config of that workd and save 18:38 p_gimeno world* 18:38 rubenwardy my thing may not work if nil is given to set_bool 18:38 Krock > nil 18:38 Krock wat 18:39 Krock time to blame someone for dumping the content instead of is_yes 18:39 p_gimeno that may be a bug, but currently without consequences, because "nil" is taken as false 18:39 Unarelith rubenwardy, did you find something yesterday anything about my ContentDB issue? 18:40 Krock handling "nil" is not required because worlds which were never entered are not a problem 18:40 p_gimeno but with the change introduced by 7914, it needs to be explicitly checked for 18:40 rubenwardy https://github.com/minetest/minetest/commit/804d65a8ecdb70acf868e0a5a9b6c670b473a70c 18:40 rubenwardy Unarelith: unfortunately no 18:40 rubenwardy are you running with RUN_IN_PLACE=0? 18:40 p_gimeno Krock: the scenario in my mind is if the user migrates a world after e.g. adding a mod and saving the configuration... an extremely rare occurrence 18:42 p_gimeno i.e. if the last thing they did before migrating to 5.0 was to save the config from the UI, while having new mods 18:42 Unarelith rubenwardy, I assume it's an env variable? tried with and without: same issue :/ 18:42 rubenwardy well, if you didn't know about it then it'll be 0 18:42 rubenwardy it's a cmake config var 18:42 rubenwardy I only tested with RUN_IN_PLACE=1, which was probably a bad idea on my behalf 18:42 Krock minetest --version also shows that 18:46 Unarelith I used to be able to download games (which I wasn't able to run somehow), but since a recent commit (less than a week) game download doesn't work :/ 18:50 p_gimeno updated #7914 18:50 ShadowBot https://github.com/minetest/minetest/issues/7914 -- Future-proof 5.0.0 for fixing #4183 18:52 p_gimeno (edited to improve clarity a bit) 19:08 Krock > and you asked me to fix them in a later PR. 19:08 Krock ANAND... 19:09 Krock !tell ANAND "and you asked me to fix them in a later PR." Maybe I meant the entire file. Your changes still need to follow the code style rules 19:09 ShadowBot Krock: O.K. 19:10 Unarelith edited #7908 comment, rubenwardy Krock nerzhul any opinions on this comment? 19:10 ShadowBot https://github.com/minetest/minetest/issues/7908 -- File 'client/game' splitted into new folder by Quent42340 19:18 p_gimeno Krock: to sum up, 7914 is kind of a subset of 6898, with strictly the necessary things that can make transition smooth, to ease review and adoption without having to review the full 6898 thing, which proved hard and may not make it to 5.0.0 due to time constraints 19:19 Krock tbh I'm disappointed that 6898 was closed in that stage 19:19 Krock *state 19:21 p_gimeno I still need to understand how CSM works in 5.0 and its relationship to 6898 19:21 p_gimeno (to rebase it) 19:23 Unarelith nerzhul, don't worry I'll wait 5.0.0 to make other changes, probably to rebase this too. This discussion is about possible name convention change due to file splitting, it's not about the fact that's it good or not for 5.0.0. And I don't understand why you bring Java here. 19:23 Krock p_gimeno: it's kinda the mainmenu, but in-game 19:24 Krock the confusing part is that client and server API files are mixed 19:25 p_gimeno Krock: would 6898 need to deal with CSMs as another case, similar to game, world and mods? 19:31 Krock for the reason that CSM is in an experimental phase anyway I'd not consider doing anything there 19:31 Krock not sure if it even supports modpacks 19:31 Unarelith and btw nerzhul, a big code refactoring IS needed. That's why I'll wait 5.0.0, and that's why I'll only make small scale changes like this one first. The main goals of my PRs will be: split big files, update code to C++11, fix style in some files, remove unnecessary dynamic allocations, improve singleton system, use composition to split big classes like Game or Client... 19:32 p_gimeno Krock: so I would rebase it without minding about CSM, is that right? 19:32 Krock p_gimeno: yes 19:33 p_gimeno ok 19:34 Krock sfan5: would I need to undo https://github.com/minetest/minetest/pull/5268#discussion_r102071068 in order to get the PR rolling? I mean, the PR works.. 19:35 sfan5 if you're very very sure that the new code works correctly then go ahead 19:36 sfan5 you can also have my approval if you'd like to merge it now 19:37 Krock thanks for the kind offer, but I need reviews; not just approvals :/ 19:38 Krock I'm not sure whether that discussion is causing the PR to stall or just the lack of people who are keen on testing int 19:38 Krock *it 19:39 sfan5 that's what I mean, given that I have commented I have already looked at the code 19:39 sfan5 and since sofar has tested it I feel comfortable with giving approval to merge it 19:39 Krock ah okay 19:40 sofar I'd be happy to retest it, too 19:41 Krock in a recent comment I noted that tubelib makes excellent use of node timers, so that will help to do some testing 19:44 Krock after all it's neither high priority nor a blocker - but it's already waiting for three years (together with RBA's work) 19:47 Krock sofar: much appreciated. It would be great if you have some time to test it :) 20:08 sofar Krock: I'll try and see if I can get to it tonight 20:10 Krock :+1: 20:19 paramat will merge #7931 later 20:19 ShadowBot https://github.com/minetest/minetest/issues/7931 -- Re-master and improve touchscreen gui icons by stujones11 20:41 paramat almost back to where we can say "why are there 712 open issues on github?" 21:15 Unarelith paramat, #7903 is ready (with snake_case) and I'll rebase 7908 soon 21:15 ShadowBot https://github.com/minetest/minetest/issues/7903 -- File 'content_sao' splitted into folder 'src/server/object'. by Quent42340 21:32 paramat just seen that, thanks 21:33 paramat will merge trivial #7935 in a few hours 21:33 ShadowBot https://github.com/minetest/minetest/issues/7935 -- Mirror 'sunrisebg' texture to fix chopped right edge by paramat 21:34 paramat merging #7931 21:34 ShadowBot https://github.com/minetest/minetest/issues/7931 -- Re-master and improve touchscreen gui icons by stujones11 21:36 paramat done