Time Nick Message 00:27 CoderForTheBette Alright, took care of line 773 and tested and everything still works as it did before (player rotation, item rotation, save and load world and nodes still at same rotation). Here's the commit: https://github.com/minetest/minetest/pull/7395/commits/4ae625f4d0009ce12fcd7ebafabb18c37eaf6a00 00:32 paramat still WIP or more to do? 00:33 CoderForTheBette It's good to go as far as I am aware. p_gimeno said something about the player not being set dirty, but I took a look at the code and can't find anything wrong. He would need to give more info. However, I still think this is fine after testing it for so long. 00:35 CoderForTheBette @p_gimeno I tried getting rid of negative signs and it turned all the rotations backwards. For example, if I moved my mouse left to look left, then more player's model turned right instead of left. Same for boats. All the rotations should be the same so I'm keeping it how it is. 00:35 CoderForTheBette more = my* 00:40 p_gimeno ok then 00:40 p_gimeno is it possible to set the rotation of the player? 00:41 CoderForTheBette No, never has ben possible 00:41 CoderForTheBette been* 00:41 CoderForTheBette using a mod, at least 00:42 rubenwardy setting the yaw has been possible 00:43 rubenwardy just not the pitch 00:43 CoderForTheBette ah, you can set the look rotation (set_look_horizontal(yaw)) but not the player model. Sorry, I misunderstood 00:44 CoderForTheBette My PR would not make it possible to set the 3 axes of rotation for the player. 00:44 p_gimeno ok, then there's nothing to set dirty 00:47 CoderForTheBette Glad to hear it. @paramat this is definitely not WIP then. 00:55 paramat good 01:04 rubenwardy surely sounds are audiovisuals? 01:04 rubenwardy why is there a label for them? 01:04 rubenwardy :) 01:05 paramat oh yeah :) 01:06 paramat well, thought a more specific label would be useful 01:06 paramat but i'm not too bothered 01:08 rubenwardy that's fair enough 01:12 Unarelith paramat, rubenwardy, about `util/travis/clang-format-whitelist.txt`, shouldn't it be a blacklist? 01:12 Unarelith or maybe blacklists aren't supported? 01:14 rubenwardy it's files which are never checked by the linter iirc 01:14 rubenwardy wait 01:14 Unarelith you're right, that's the files the linter never checks 01:14 rubenwardy yeah 01:15 Unarelith and that's almost all of them 01:15 rubenwardy the name is a bit misleading really 01:15 rubenwardy lol 01:15 rubenwardy sounds about right 01:17 Unarelith ~70% of the code is unchecked, omg 01:17 ShadowBot Unarelith: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command). 01:17 Unarelith oh the bot didn't like my ~ 01:17 paramat 'whitelist' is correct 01:18 Unarelith in a way it is 01:18 paramat the whitelist is so big because the linter is so silly about codestyle 01:18 Unarelith then what's the point of having a linter at all? 01:19 paramat well, i somewhat sympathise ;) 01:20 paramat i've been complaining about it for a long time, it mostly just annoys people for no good reason 01:21 paramat only occasionally detects something useful 01:22 Unarelith I think that every basic repo action like adding/moving/renaming/deleting a file shouldn't require to edit three other files (CMakeLists.txt, Android.mk, clang-format-whitelist.txt) 01:22 paramat the only usefulness is to remove from whitelist when writing a PR to see what pops up, then re-add to whitelist before merge 01:26 Unarelith paramat, btw did you see my fix for CMakeLists.txt? 01:27 paramat and worse, we're now starting to add 'clang format on/off' lines of code to turn linter on and off within files, just because the linter is useless 01:27 paramat but nerz strongly supports the linter for some weird reason :) 01:28 paramat not yet 01:28 Unarelith adding lines for linter inside files is baaaaaaad :') 01:29 paramat i have now 01:35 Unarelith paramat, I was wondering, why not use new GitHub checks thing: https://blog.github.com/2018-05-07-introducing-checks-api/ 01:37 paramat hm travis ci is integrated 01:38 paramat maybe related #6766 01:38 ShadowBot https://github.com/minetest/minetest/issues/6766 -- Make LINT a separate check 01:38 Unarelith it definitely is 01:41 Unarelith so this issue may not be a "can't fix" anymore 01:45 paramat ok 01:47 paramat re-opened 01:50 Unarelith nice, however I think to try it we'll need permissions on minetest GitHub account 01:52 T4im iirc they only have travis.com supporting it, and travis.org not; although they apparently plan to migrate open source projects over in the long term 01:53 Unarelith T4im, I tried to install it on my account and I had an option for open source projects 01:54 T4im probably already on .com then though 01:55 T4im i believe there is an option to migrate earlier if you are willing to throw away the build-history, too 01:57 T4im see https://blog.travis-ci.com/2018-05-02-open-source-projects-on-travis-ci-com-with-github-apps 01:57 T4im new users get it, old users not yet 01:58 Unarelith it was 6 months ago 01:58 Unarelith maybe it changed 01:59 T4im there were no new blog posts saying otherwise since then 01:59 Unarelith oh :( 01:59 T4im also docs still state it that way: https://docs.travis-ci.com/user/open-source-on-travis-ci-com/#Existing-Open-Source-Repositories-on-travis-ci.org 02:00 T4im "New or migrated repositories building on travis-ci.com will have access to the features offered with the GitHub Apps-based Integration." 02:02 T4im right now their focus seems more on removing containerized builds again 02:06 Unarelith it's sad, but this may be used as a workaround though 02:06 Unarelith https://github.com/travis-ci/travis-ci/issues/5035#issuecomment-385656932 02:09 T4im mtg actually uses container builds and someone might get an email about that tomorrow 02:09 T4im :P 02:13 Unarelith well I was wrong about my workaround, but it's still a nice extension 08:27 ANAND I'm planning to make a couple of code-style PRs. Should I wait until Unarelith's massive refactoring PRs are merged before getting started? 17:31 rubenwardy game#2152 17:31 ShadowBot https://github.com/minetest/minetest_game/issues/2152 -- Add sfinv.show_formspec() and sfinv.set_page_and_show() by rubenwardy 17:31 rubenwardy game#2214 17:31 ShadowBot https://github.com/minetest/minetest_game/issues/2214 -- Add sfinv.get_page() by rubenwardy 19:14 Unarelith nerzhul, could you check my PRs? they should be good now