Time Nick Message 10:43 nerzhul merging #7834 & #7873 10:43 ShadowBot https://github.com/minetest/minetest/issues/7834 -- Android: Improve UI scaling on smaller high-density displays by stujones11 10:43 ShadowBot https://github.com/minetest/minetest/issues/7873 -- Fix Android build by numberZero 10:59 Krock > when the merge announce comes after MinetestBot's feed check 13:55 nerzhul :p 14:39 sfan5 pushed a trivial documentation change 18:10 paramat thanks so much for reviewing and merging those, next i'll update #7784 to suitable settings 18:10 ShadowBot https://github.com/minetest/minetest/issues/7784 -- Android settings: Develop adaptive HUD/GUI scaling, font size by paramat 18:10 paramat #7395 needs another approval 18:10 ShadowBot https://github.com/minetest/minetest/issues/7395 -- Add Lua methods 'set_rotation()' and 'get_rotation()' by CoderForTheBetter 18:26 Krock downvoted https://github.com/minetest/minetest/pull/7820#issuecomment-439713842. rubenwardy let's fite 18:27 rubenwardy lol 18:27 rubenwardy it's best to stick to the standards for the platform 18:28 rubenwardy well, I'm not too strongly opposed anyway 18:28 Krock is it a Java or Google/Android standard? 18:28 rubenwardy my recommendation is to stick with platform standards 18:28 rubenwardy it's enforced by default in Android Studio 18:28 rubenwardy so Google/Android 18:28 Krock "by default" means that it can be changed 18:29 sfan5 i'd rather have it that we stick to Minetest's code standards 18:29 Krock C++ editors sometimes even do autodetection. Thus, I'd prefer to use our standards 18:29 Krock i.e. agree with sfan5 18:29 rubenwardy sure 18:30 Krock just wanted to discuss this briefly :) 18:30 rubenwardy :) 18:31 rubenwardy I reckon we should rewrite Minetest into Kotlin, then there would be no need for the Java/NDK split 18:31 rubenwardy /jks 18:31 paramat i prefer tabs too 18:32 rubenwardy Android Studio is one of the few IDEs that is good enough that it doesn't matter 18:32 rubenwardy spaces act like tabs, perfectly 18:32 rubenwardy but given this is Minetest, no one uses Android Studio 18:32 rubenwardy because of our crappy Makefile build system 18:33 rubenwardy Android Studio supports NDK building using CMake :'( 20:08 nerzhul rubenwardy i use clion and don't have this problem :p 20:08 paramat now that 7834 is merged i have updated #7784 and will merge it in a few hours if no objection. It's fairly trivial and carefully developed and tested 20:08 nerzhul yes it supports it but not in our current way 20:08 ShadowBot https://github.com/minetest/minetest/issues/7784 -- Android settings: Develop adaptive HUD scaling by paramat 20:09 rubenwardy CLion is built upon the same IDE as Android Studio 20:09 nerzhul i tried to purge a little bit our makefile to have gradle only but it's difficult, if it succeed and we rewrite ~30% of our cmake files we can use it :p 20:09 nerzhul i know :p 22:27 paramat merging #7784 22:27 ShadowBot https://github.com/minetest/minetest/issues/7784 -- Android settings: Develop adaptive HUD scaling by paramat 22:30 paramat done, we're making some good progress