Time Nick Message 01:07 paramat nerzhul good news, see https://github.com/minetest/minetest/issues/7525#issuecomment-439184380 seems there is no bug and the playstore app was built with irrlicht in debug mode =) please can you make a point release to fix? 18:05 Krock merging game#2265 in 10 minutes 18:05 ShadowBot https://github.com/minetest/minetest_game/issues/2265 -- Remove double inner/outer in stairs descriptions by pauloue 18:50 Krock er 18:51 Krock ERR amended the commit title 18:54 stujones11 Where should checkout to build the backport release? 18:54 stujones11 +I 18:57 stujones11 Is it stable-0.4 or should I use the release tag? 18:58 paramat stable 0.4 i think, as that goes further than the 0.4.17.1 release 18:59 paramat yes, checked 19:00 stujones11 ok, thanks! 19:00 paramat latest tag is jun 10, stable-0.4 is jun 28 19:01 paramat stable-0.4 has the extra stuff added for the playstore app 19:01 paramat (for the last fix of the app) 19:08 paramat so stable-0.4 is at what is called 0.4.17.2 (the current app release) 19:10 stujones11 So for the correct game I should use backport-0.4, right? 19:11 Krock can't the fix be integrated into 5.0? 19:13 Krock how it looks right now it's just a build setup issue (building a release build) 19:16 stujones11 The 5.0.0 release build works fine, I am testing the backport release right now. 19:17 paramat correct game as in MTG? 19:18 stujones11 paramat, yes MTG there is a branch named backport-0.4 19:19 paramat either stable-0.4 or tags 0.4.17.1 or 0.4.17.2, all are identical 19:19 Krock ah, it's a leftover branch. could be deleted as well 19:20 paramat actually MTG tag 0.4.17 is identical too 19:20 Krock not sure if it has the same history as MTG 19:20 Krock *MTG master 19:20 paramat well MT tags and versions have become confusing because .. 19:21 paramat the latest app was called 0.4.17.2 but that tag isn't in the engine. and, tag 0.4.17.2 was added to MTG 19:22 paramat i've asked that we either add tag 0.4.17.2 to the engine, or that MTG tag 0.4.17.2 is removed and we recognise calling the app 0.4.17.2 a mistake 19:25 Krock PC users don't care about .2, so it's fiiiine 19:25 paramat i don't yet know how to add tags. i think we should add tag 0.4.17.2 to MTE, to the commit that stable-0.4 is at currently 19:25 Krock that release didn't go properly anyway, but at least it's there 19:26 paramat well, it's not fine because it's causing confusion and is a headache for devs =) 19:26 Krock got other much more important things which might give an headache 19:27 paramat ok. i'll learn and add the tag myself :) 19:32 stujones11 I can now confirm that the android backport builds fine in release mode. 19:32 stujones11 it is possible to tell from the size of libirrlicht.a, the debug version is 0.4MB bigger ;) 19:33 paramat nice 19:34 paramat nerzhul will you be able to fix the app this weekend? 19:44 stujones11 When I said it builds fine, it does still have the broken patch file. 19:44 stujones11 Fix here: https://github.com/minetest/minetest/commit/65af7d2fb6a7e9537dedfb9d11e93c929030d71b 20:05 stujones11 I just remembered, there could be a problem making a play-store point release. 20:05 stujones11 https://developer.android.com/distribute/best-practices/develop/target-sdk 20:05 stujones11 The fix, however, is included in #7820 20:06 ShadowBot https://github.com/minetest/minetest/issues/7820 -- Update Android java-part by MoNTE48 20:06 paramat oh hm 20:07 paramat #7813 20:07 ShadowBot https://github.com/minetest/minetest/issues/7813 -- Target at least SDK 26 20:09 paramat actually 7820 looks well tested (3 people) i think we can merge it 20:10 paramat i can't judge the code though 20:11 paramat nerzhul please could you review #7820 ? might be needed before we can update and fix the app 20:11 ShadowBot https://github.com/minetest/minetest/issues/7820 -- Update Android java-part by MoNTE48 20:11 paramat back later 21:50 srifqi I was compiling recent master branch for Android. The compilation failed with this error: 21:50 srifqi jni/src/irrlichttypes.h:56:13: error: no function template matches function template specialization 'roundingError' 21:51 srifqi I reverted b786982 commit and that error doesn't occur anymore. 21:52 srifqi PR #7839 is not for Android or am I missing something? 21:52 ShadowBot https://github.com/minetest/minetest/issues/7839 -- Support Irrlicht 1.9 by numberZero 21:54 Krock The 5.0.0 release build works fine, I am testing the backport release right now 21:54 Krock outdated statement, stujones11 ? 21:55 Krock srifqi: which Irrlicht version are you using? 22:11 sfan5 irr's android port is some weird mix between 1.8 and 1.9 so that might cause it 22:17 srifqi Krock: I just make clean_irrlicht and then make irrlicht. 22:17 srifqi r5150 (?) 22:20 srifqi 1.9 (?)