Time Nick Message 17:12 Krock Merging #7739 in 10 minutes 17:12 ShadowBot https://github.com/minetest/minetest/issues/7739 -- Ease selection of entities behind nodes by SmallJoker 17:21 VanessaE Krock: I forget, are you doing mtg too? 17:23 Krock VanessaE: occasionally 17:23 Krock marging 17:23 VanessaE just a simple request that's not important enough for an issue: import homedecor's former glass door textures (prior to that node's removal just a day or two ago), to use for mtg's plain glass doors. imho mine look better than mtg's. ;) 17:23 Krock Maaarge! 17:23 VanessaE heh 17:24 Krock VanessaE: not familiar with those items, but I think new textures would be great there 17:24 VanessaE moment 17:24 Krock "those items" as in "the code behind" aka API 17:25 VanessaE there here somewhere... 17:25 VanessaE https://gitlab.com/VanessaE/homedecor_modpack/blob/ec0e332918ecd9f8eb7c45b1ea5a2de30ef18896/homedecor/textures/homedecor_door_glass.png 17:26 VanessaE (and door_glass_inv) 17:26 VanessaE you'll need to re-arrange the image a bit to work for mtg's door, but that shouldn't be hard. 17:26 VanessaE there? GAH. they're* 17:27 Krock oh nice, let's see 17:29 VanessaE HD's images are cc-by-sa 3.0 but idc since that one's not in active use in my mod anymore. just use whatever's the prevailing license in mtg. 17:42 VanessaE opinions? 17:57 VanessaE I think I broke Krock's brain..... 17:58 Krock no, just absent 17:58 Krock Not sure how the door textures are made 17:58 VanessaE heh ok. 17:58 VanessaE well in HD they're a mesh node. 17:58 VanessaE the main part that's obvious a door is 16x32 I think, and is copied/mirrored to the back. the rest of the margins are used for the edges. 17:59 VanessaE obviously* 18:00 Krock it's a different mesh node in MTG 18:00 VanessaE yep I know. 18:00 Krock yes, yours does the same, jsut with different positions 18:00 VanessaE shouldn't be hard to mogrify my image to fit mtg's door. 18:01 VanessaE (which reminds me, HDX's mtg door textures need fixed. I'll get on that Real Soon Now™) 18:17 Krock VanessaE: the door clearly lacks some details.. trying to add noise grains 18:17 VanessaE ok. 18:18 VanessaE mine were originally those upscale office-type doors, hence them being kinda clean 18:25 Krock Old/new https://i.imgur.com/05GLQoO.png 18:26 Krock not too bad, I guess? 18:28 VanessaE :+1000: 18:28 VanessaE https://i.kym-cdn.com/entries/icons/mobile/000/001/987/FuckYEA.jpg 18:29 Krock I take this as a supporting answer. 18:29 VanessaE yep :) 18:32 rubenwardy +1 18:34 VanessaE feel free to use whatever else you want for other nodes, btw. 18:39 Krock but credits must be given (according to myself). Thanks for the information, maybe there will be another texture which finds major acceptance to get it into MTG 18:39 VanessaE sure, of course. 18:40 Krock game#2252 18:40 ShadowBot https://github.com/minetest/minetest_game/issues/2252 -- New glassdoor texture by SmallJoker 18:41 Krock the textures feel a lot brighter in gimp than ingame.. weird 18:41 VanessaE yeah 18:41 VanessaE I see that *everywhere* 18:41 VanessaE drives me nuts. 18:42 VanessaE only the top of the node will look the same. 18:42 VanessaE (even on something as simple as wood or stone) 18:42 Krock oh I see 18:42 VanessaE I assume it's due to the static side shading that's used to similate directional lighting. 18:42 Krock this is the shading part to see the different sides easier on voxels 18:43 Krock exactly that 18:43 VanessaE only fix afaik would be some kind of sun/moonlight shader with a real light source. 18:44 Krock or changing the setting value to 0 18:44 VanessaE (probably could be done as a modification of the dawn/dusk transition code) 18:52 Krock #6153 looks complete. sfan5, would you mind giving a short feedback whether your comments were resolved or anything needs a change? 18:52 ShadowBot https://github.com/minetest/minetest/issues/6153 -- Windows: Cpack wix installer by adrido 18:53 Krock I think you'd like to see an additional change for cross-compiling since WiX does not work? 18:53 sfan5 that's only RUN_IN_PLACE=0 which I don't actually use 18:54 sfan5 but yes, this PR will break cross-compiling with run_in_place=0 from linux 18:55 sfan5 or maybe not, if cmake can fallback to the zip generator 18:55 sfan5 not that it matters 18:55 sfan5 so: yes, all my comments were addresses 18:55 sfan5 s/s$/d/ 19:00 Krock RUN_IN_PLACE defaults to 1 for Win32 builds anyway, so existing setups won't break, but new ones will encounter issues when building systemwide 19:01 Krock in that case could either one of us approve the PR to get it merged. It's been around for a long time already 19:03 sfan5 done 19:16 Krock great, thanks. 19:22 Krock will merge #6153 in 15 minutes 19:22 ShadowBot https://github.com/minetest/minetest/issues/6153 -- Windows: Cpack wix installer by adrido 19:36 Krock merging...