Time  Nick      Message
08:04 ANAND     Trivial / Documentation: #7759
08:04 ShadowBot https://github.com/minetest/minetest/issues/7759 -- lua_api.txt: Move 2 fields to nodedef by ClobberXD
09:54 nerzhul   hi, sorry for being so absent guys
10:10 Krock     no problem. Glad to see you here again :)
13:08 T4im      hello there :) would there be 2 willing devs to review if i rebased the followup profiler pr #4343 these days? the good news is, i'm > 2 years distanced from that code, so i'd probably see easily where additional code comments might be needed to understand it :D
13:08 ShadowBot https://github.com/minetest/minetest/issues/4343 -- Profiler: Better structures, count calls, measure relative usage by t4im
13:12 Krock     hello! glad to see you back :)  I'd be interested in this
13:13 T4im      :D yea sorry for taking off that abruptly
13:13 T4im      and thank you!
13:16 Krock     just to have it said: development is quite slow nowadays and approvals are quite hard to get. I hope this will become better soon
13:19 T4im      :)
15:47 Krock     time to put pgimeno's IEEE checking code into a real PR...
15:48 Krock     otherwise we're getting nowhere with the network problems. I just hope the output is consistent among the platforms - unittest will hate it
15:50 p_gimeno  it's nearly impossible to fully test
15:51 Krock     ah, the underscore. that's why it failed to autocomplete
15:51 p_gimeno  yeah, some people said they confused my nick with paramat's :)
16:55 paramat   #7748 fairly simple PR for beautiful night clouds
16:55 ShadowBot https://github.com/minetest/minetest/issues/7748 -- Night clouds: Boost brightness for a moonlit appearence by paramat
16:58 Krock     Could somebody please review PR #7676? For the reason that it's been around for quite a while, confirmed working and a bugfix I'll otherwise merge it in an hour unless there are objections
16:58 ShadowBot https://github.com/minetest/minetest/issues/7676 -- Remove settings properly by SmallJoker
17:08 paramat   will look
17:18 paramat   did you check that 'core.settings:remove(setting.name)' resets a noise table to it's default?
17:19 paramat   if so go ahead
17:20 Krock     will make sure
17:20 Krock     don't remember whether I checked groups too
17:23 Krock     paramat: you meant a setting like mgv7_np_mount_height, right?
17:23 paramat   correct
17:23 paramat   noise params 2d/3d
17:26 paramat   'core.settings:set(setting.name, setting.default)' has been in use there for 4 years
17:27 Krock     broken for 4 years
17:27 paramat   lol
17:27 paramat   ok, just checking :]
17:28 Krock     yes, works.
17:28 paramat   ok thanks
17:28 Krock     i.e. the setting is trimmed from the minetest.conf file. Not much you can do wrong there
17:29 paramat   sounds right
17:29 Krock     however, I'm not sure on how I should test #7748. Is it the clouds which appear slightly different now?
17:29 ShadowBot https://github.com/minetest/minetest/issues/7748 -- Night clouds: Boost brightness for a moonlit appearence by paramat
17:30 paramat   at night clouds are slightly brighter
17:30 paramat   change is shown in the screenshots
17:30 Krock     thanks to my monitor I see two times black with some stars
17:30 paramat   best test at midnight to avoid interference from directional coloured fog effect
17:31 Krock     can't tell any difference by looking at the screenshots tbh
17:31 paramat   weird, bad monitor?
17:31 Krock     turned the brightness a bit up now. I see.. in the PR the clouds are now a bit visible
17:32 Krock     looks about right
17:36 paramat   the recent lightcurve fix made night sky a little brighter, so in master clouds became almost indistinguishable from night sky, as seenm in the 2nd screenshot
17:37 paramat   *seen
17:37 paramat   so the PR is essentially restoring the contrast
17:41 paramat   i coded that after taking a nighttime full moon walk and looking at the moonlit clouds
17:56 Krock     thanks for the approval. merging #7676 ....
17:56 ShadowBot https://github.com/minetest/minetest/issues/7676 -- Remove settings properly by SmallJoker