Time Nick Message 10:42 rubenwardy game#2214 10:42 ShadowBot https://github.com/minetest/minetest_game/issues/2214 -- Add sfinv.get_page() by rubenwardy 10:50 rubenwardy updated game#2152 10:50 ShadowBot https://github.com/minetest/minetest_game/issues/2152 -- Add sfinv.show_formspec() and sfinv.set_page_and_show() by rubenwardy 10:54 rubenwardy both of those PRs are tested 16:09 paramat please can someone review bugfix #7693 ? it's thoroughly tested 16:09 ShadowBot https://github.com/minetest/minetest/issues/7693 -- Improve decode_light_f by numberZero 16:27 paramat Shara for when you have time game#2207 game#2209 16:27 ShadowBot https://github.com/minetest/minetest_game/issues/2207 -- New hotbar textures by paramat 16:27 ShadowBot https://github.com/minetest/minetest_game/issues/2209 -- Fire: Remove ABM active when fire mod disabled by paramat 16:38 Shara I am probably fine with both. Will take a look 16:40 Krock paramat: how about old fire which does not have nodetimers set up yet? 16:40 Krock if those on old maps should be extinguished too, then maybe a LBM will help 16:40 Shara Heh, wsa just wondering if that is accounted for anywhere 16:41 Krock game#2207 looks better now. Neutral on this PR because I kinda like the current one 16:41 ShadowBot https://github.com/minetest/minetest_game/issues/2207 -- New hotbar textures by paramat 16:43 Shara I've no issues with 2207. I hate the selector in the current one but do like the spacing between slots, and this fixes the selector but removes that spacing 16:43 Shara But overall I think it does look cleaner/neater 16:43 paramat hm old fire .. 16:44 paramat also game#2150 16:44 ShadowBot https://github.com/minetest/minetest_game/issues/2150 -- Beds: Add white simple and fancy beds by paramat 16:45 Shara I'm neutral on beds 16:50 paramat i don't think it's worth worrying about old fire, flames were converted to nodetimers 2.5 years ago. in the rare case old flames persist they still won't spread and can be removed by punching or by a dedicated mod if large in number 16:52 Shara I think whether they spread or not is the most important thing 16:52 Krock They'll never be removed 16:52 Shara Until you punch you. 16:52 Krock s/you./them./ 16:52 Shara heh 16:53 paramat 2.5 years is long enough to not worry 16:53 paramat it's just not worth the effort 16:53 Shara Worrying is good. This is something worth being sure about. 16:54 Krock Just came up with this idea because of the recent "blox" PR from VE 16:54 Krock same thing there, except that unknown nodes will be left over in the world 16:54 paramat i won't disapprove if one of you wants to make a follow up PR to do that but i won't do it :) 16:54 Shara If the worst thing this can leave us with is fire nodes that don't go out by themselves and won't spread, I think that's fine. 16:55 Krock yes, that's the worst case 16:55 Shara I'm just looking at it as a server owner. Would it bother me if suddenly there were a few fire nodes that needed to be manually put out? No. 16:56 Shara There's no real gameplay advantage or disadvantage for players that find those nodes, unless they literally build round them to have a special light source or something 16:57 Krock > if suddenly there were a few fire nodes that needed to be manually put out? 16:57 Krock inb4 forest fires may happen 16:57 Shara That's why I mentioned not spreading being important 16:58 paramat this is for when fire mod is disabled, when fire spread doesn't happen 16:58 paramat merging game 2207 16:59 Shara But what happens if someone changes their mind and enables it? 17:01 paramat merged 17:02 paramat if someone re-enables fire mod they want those flames to spread again, so it's correct behaviour 17:09 paramat so can i merge game 2209? feel free to do a follow up LBM PR if you want 17:17 paramat see https://github.com/minetest/minetest/graphs/code-frequency this has been the longest quiet period in MT dev history 17:18 Krock that's not a reason to merge it if you wanted to say that 17:18 Shara ^ 17:18 paramat ? 17:18 Shara Pesonally I think 2209 is okay, but I would prefer more opinions than only mine 17:18 Krock but feel free to do so. Fire will be harmless but bother those who will have to remove it from the world 17:19 paramat oh follow up PR being a reason 17:20 paramat nah, the reason i mentioned a follow up PR is that i'm not going to add an LBM myself, as i wrote earlier 17:21 paramat ok thanks 17:21 Shara I'd prefer to avoid an lbm 17:21 paramat yeah me too 17:23 paramat Krock any opinion on white bed? 17:24 Krock some more colours wouldn't hurt but yet again it's called "white bed" 17:24 paramat merging 2209 17:25 Krock neutral on the beds PR, depending on dye seems fine 17:26 paramat i'm -1 for multiple colours of beds in MTG, see issue. this is to avoid needing red dye to make a bed 17:27 Krock their issue is basically that finding flowers is hard 17:28 paramat there may be situations where roses do not exist, due to custom biomes 17:28 Krock white looks very plain, boring. Add it if there are people who like it. For me it would be way too basic 17:28 Krock there may be situations where clay does not exist due to custom biomes but people are fine with that 17:28 paramat and it's also ridiculous, a player has wool, but can't sleep because they can't dye it MC-red :D 17:28 Krock jungle grass too, but less of a problem 17:29 paramat well, it's white for a reason: no dye :) 17:30 Shara If the bed thing can't get settled, I'm tempted to just say remove the requirement for dye and leave it alone 17:30 Shara I mean, this is a world where we can cut wooden trees into neat planks with our bare hands so... realism is not too strong here 17:30 paramat also i really dislike how we copied MC with beds, BlockMen copied MC too closely 17:35 paramat merged 17:36 paramat yes removing the need for dye is an option, i'm not totally sure about this so will wait for more input 17:41 Krock I'd be against trimming that 17:53 paramat thanks so much to you both for being active 18:01 paramat i've kept the 5.0.0 project up to date https://github.com/minetest/minetest/projects/4 see that for what 5.0.0 involves 18:02 paramat any more opinions on #7569 ? 18:02 ShadowBot https://github.com/minetest/minetest/issues/7569 -- Send custom floats (log2) by SmallJoker 18:02 paramat nerzhul ^ 18:03 paramat i feel we need to focus a little on releasing 5.0.0 :) 18:04 paramat not much left to do actually, but there is the issue of those obscure crashes 18:04 paramat quite a lot is android stuff, grrr.seems to take up a disproportionate amount of time 18:07 paramat nerzhul #7483 just needs another +1, if you are able to review 18:07 ShadowBot https://github.com/minetest/minetest/issues/7483 -- Move touchscreen input handling to base GUIModalMenu class by stujones11 18:08 Krock paramat: low-priority, but why did you agree twice? https://github.com/minetest/minetest/pull/7726#discussion_r217744579 looks very strange 18:09 Krock regarding https://github.com/minetest/minetest/pull/7651#issuecomment-421092505 it's the same. I wonder how you're getting non-blurry acacia tree inventory images 18:09 paramat heh 18:10 paramat github weirdness made me do that 18:10 paramat yeah odd 18:11 paramat i only tested in creative inventory though 18:14 paramat perhaps we can keep stujones11 in mind for android dev?, see contributions https://github.com/minetest/minetest/commits?author=stujones11 18:15 Krock if they're interested in being a code dev I have no objections. They're welcome 18:16 paramat sort of a core dev for android stuff, not sure about a full core dev yet 18:17 Krock Will merge #7711 in ~15 mins 18:17 ShadowBot https://github.com/minetest/minetest/issues/7711 -- Inv deSerialize(): Prevent infinite loop, error on failure by SmallJoker 18:18 Krock thanks for the review, sfan5 :) 18:23 paramat in fact, certainly not a full core dev 18:28 Krock merging.. 18:29 Krock done. Megaf ^, might want to retest your migration