Time  Nick      Message
17:43 Krock     Yet Another Compat Drop PR: #7684 - not entirely necessary but opens the chance to change other packets too
17:43 ShadowBot https://github.com/minetest/minetest/issues/7684 -- Add core.remove_detached_inventory by SmallJoker
17:48 Krock     Test code is available now - if anyone is keen on testing
20:04 paramat   #7399 rebased
20:04 ShadowBot https://github.com/minetest/minetest/issues/7399 -- Damage flash/camera tilt: Make shorter to reduce player blindness by paramat
20:13 Krock     the PR is clean but the range of 0.25 ... 0.33s feels way too less to notice a difference
20:13 Krock     would 0.2 .. 0.5 be an option?
20:30 paramat   the difference in alpha is still as noticeable
20:31 paramat   the change in duration is hard-linked to change in alpha, so is determined by the acceptable alpha values
20:32 paramat   hurt tilt also still shows change in damage amount
20:32 paramat   and 0.5 is too long, has the same problems as before, and is unnecessary
20:33 paramat   even 0.33 feels almost too long to me (and almost starts hurting my eyes due to length)
20:34 Krock     it would still be possible to limit the maximal alpha and show it for a little bit longer
20:34 paramat   the change in duration is still noticeable to me, just
20:34 Krock     well, it kinda should hurt
20:36 paramat   nuuu
20:36 paramat   the whole point is to make it a quick flash, that's what fixes blindness in combat
20:37 paramat   however, it's probably just me who gets visual pain from a long flash, i am visually sensitive (health issue)
20:42 paramat   the change in intensity of duration, alpha and tilt may be a little difficult to conciously notice at first due to speed, but you are certainly noticing it subconciously
20:42 paramat   note it has 2 core devs supporting in emoticons
20:43 paramat   it's funny, i personally cannot even look at the screen currently when damage happens x_X
20:44 Krock     well then, it's a trivial change. merge it if you want
20:44 Krock     trivial from the code perspective
20:45 paramat   thanks for considering it
20:46 paramat   will merge in 5 mins
20:57 paramat   merging
21:01 paramat   merged