Time  Nick       Message
00:16 paramat    #7667
00:16 ShadowBot  https://github.com/minetest/minetest/issues/7667 -- Content tab: Resize buttons to not clip text by paramat
01:03 paramat    game#2196
01:03 ShadowBot  https://github.com/minetest/minetest_game/issues/2196 -- Add new dirt texture by random-geek by paramat
01:04 Cornelia   Mmm.. gotta get a good look at that nice, new dirt..
14:33 Krock      Variant 1: template <typename T> NetworkPacket &operator>>(std::vector<T> &dst)
14:33 Krock      Variant 2: template <typename T> NetworkPacket &operator >> (std::vector<T> &dst)
14:36 Krock      The rules say to add spaces around binary operators and this is a function notation. Which variant is correct here? Doesn't matter much tbh
15:00 ANAND      not sure about the rules, but the second is more readable for me
16:07 Krock      nerzhul: guaranteed vector size is only specified up to 65k https://stackoverflow.com/a/918796
16:08 Krock      although in almost all cases it will be >= 4 bytes
16:58 paramat    rubenwardy or anyone, any idea how to fix modpack description 1st line in #7667 ?
16:58 ShadowBot  https://github.com/minetest/minetest/issues/7667 -- Content tab: Resize buttons to not clip text by paramat
17:01 Krock      1) Use textarea
17:01 Krock      2) remove the line_wrap function and just paste the description text directly inside the textarea
17:01 Krock      3) Chill
17:01 paramat    thanks
17:02 Krock      !next
17:02 ShadowBot  Another satisfied customer. Next!
17:02 paramat    game#2196 Shara Krock
17:02 ShadowBot  https://github.com/minetest/minetest_game/issues/2196 -- Add new dirt texture by random-geek by paramat
17:02 Krock      always used a custom texture pack but I'm open for this change
17:03 Krock      would rather like to hear some player/server owner feedbacks and approve afterwards
17:03 paramat    yeah wait for Sha-ra's feedback :)
17:05 paramat    meh, this isn't a democracy ;)
17:06 rubenwardy Prepend a single blank linr
17:06 Krock      surely it isn't but what does it help to change a texture which the majority may dislike?
17:13 paramat    ruben ok
17:14 paramat    well the texture has been viewable for a while now, there's been time for reactions to get a sense of popularity
17:19 Shara      I don't like those repeating pixels I flagged in the original thread
17:19 Shara      They are still there, and they really jump out at me
17:23 paramat    it looks like just 1 of the group of 3 pixels was made a little darker
17:23 Shara      Yes, which doesn't help at all
17:24 Shara      I like it before the stones were added, don't like the one with stones.
17:25 Shara      liked*
17:25 paramat    i'm ok with either
17:25 Shara      But don't really want to block it if others prefer it this way
17:26 paramat    well, i prefer the stony one, but groups of 3 need to be reduced to 2 pixels
17:26 Shara      That would help
17:27 paramat    i agree to reducing pebbliness a little
17:28 paramat    there's 2 groups of 3
17:29 Shara      I don't find myself noticing the second group though
17:30 Shara      I think it matches the pixels around it enough to be okay
17:30 Shara      Whereas the group I pointed out is against a very dark part of the dirt texture, so jumps out
17:33 paramat    ok
18:02 paramat    i might tweak that texture myself as it's one pixel
19:02 paramat    dirt PR updated
19:03 sfan5      does it have screenshots?
19:28 paramat    yes 1
19:29 Shara      The edit is good for me
19:32 paramat    sfan5 see the issue for the old texture as comparison. will merge in 5 mins
19:33 sfan5      ok
19:39 paramat    merging
19:42 paramat    merged. excellent, the previous one was so bad
19:43 VanessaE   paramat: stable-0.4 also? :)
19:52 VanessaE   to that end, it might be a good idea to sync all of that branch's textures with master
19:54 paramat    not a bugfix
19:55 VanessaE   :<
19:56 paramat    and i prefer to maximise the allure of 5.0.0 :)
19:56 VanessaE   *throws tantrum* but I don't wanna switch to 5.0.0  :(
20:13 rubenwardy no
20:14 rubenwardy stop changing dirt
20:15 VanessaE   inb4 "oh, we should add pebbles/gravel to the texture"
20:25 paramat    actually it does add pebbles :)
20:26 VanessaE   well I meant more visible ones :P
20:27 VanessaE   (to me, it looks more like it contains gravel)
20:57 paramat    Shara i reviewed game#2142 and game#2186
20:57 ShadowBot  https://github.com/minetest/minetest_game/issues/2142 -- Simplify Wool by tenplus1
20:57 ShadowBot  https://github.com/minetest/minetest_game/issues/2186 -- Simplify DYE mod by tenplus1
20:59 Shara      Probably not awake enough right now, but will review sometime this week if no one beats me to it
20:59 Shara      I support the concept, so just need to check through everything
21:07 paramat    ok
21:40 paramat    updated #7667
21:40 ShadowBot  https://github.com/minetest/minetest/issues/7667 -- Content tab: Fix clipped text in button and description by paramat
23:32 paramat    game#2198 rubenwardy
23:32 ShadowBot  https://github.com/minetest/minetest_game/issues/2198 -- README.txt files: Change 'LGPL 2.1' to 'LGPLv2.1+'. Remove 'WTFPL' by paramat
23:57 paramat    will merge in 15 mins as already requested by the rubywarden