Time  Nick      Message
13:53 nerzhul   merging #7628
13:53 ShadowBot https://github.com/minetest/minetest/issues/7628 -- Some minor Fastface optimizations. by lhofhansl
13:53 nerzhul   ty lhofhansl
20:52 xamgu     soo this might be a bit out there, but: how about we move all those single files inside the minetest folder into map.sqlite and rename it to savegame.sqlite or similar?
20:52 xamgu     advantages: unified data format, simpler backups, online backups possible, removal of custom parser code, others i can not think of rn
20:52 xamgu     disadvantages: got to remove that custom parser code
20:53 sfan5     > removal of custom parser code
20:53 sfan5     except auth.txt, the files follow the settings format so there's nothing to remove
20:53 sfan5     also open an issue (if there isn't one open already...)
20:54 nerzhul   sfan5: auth.txt has now a sqlite model in master heh
20:54 xamgu     i don't have a github account
20:57 xamgu     sfan5: so im not an expert, but im not sure thats true
20:57 xamgu     env_meta.txt ends with "EnvArgsEnd" which im not sure is a key-value expression
20:58 xamgu     map_meta.txt is lua structs i think
20:58 xamgu     world.mt is in fact the same format
20:59 xamgu     the player files contain the inventory, im not sure thats the same parse path either
21:00 sfan5     you're right that the EnvArgsEnd or [end_of_params] is a special case
21:00 xamgu     so maybe its not remove, just simplify a lot? i don't know how minetest is structured internally
21:00 sfan5     but other than that no serialization is exclusive to the files
21:01 sfan5     e.g. the player files are composed of both the settings format and the serialization format for inventories, neither of which could be removed if player files didn't exist (since they are used elsewhere)
21:01 xamgu     + the main two benefits in my mind are that it would make a savegame simply a single file and allow the usage of the sqlite-apis (including backups!) for the entire savegame
21:02 xamgu     out of curiosity, where is the inventory used? i did not find another place using a very shallow search
21:02 sfan5     the same inventory format is used for both network communication and the map data
21:04 xamgu     ah, i see
21:05 basxto    https://github.com/minetest/minetest/issues/3374 is a bit related, I think
21:05 xamgu     ok, so i take this as no one has found any glaring issues with the proposal?
21:05 xamgu     i will take a look
21:08 xamgu     yeah, similar solution, but different issues
21:09 basxto    also this can work for backups in singleplayer https://mikemaximus.github.io/gbm-web/GBM_Official_Linux.xml
21:09 xamgu     it might be worth noting that sqlite is not type-safe, so you can store any kind of data in any field. that allows just using a table as a key-value-store without any issues
21:12 xamgu     yeah, for singleplayer that works
21:12 xamgu     but on servers downtime is more of an issue
21:14 xamgu     so i will wait a bit to see if anyone has any problem with the proposal
21:14 xamgu     if not i might try and contribute, but i can't really write c++
21:40 p_gimeno  one problem I see with that idea is the difficulty of checking or changing settings
21:46 paramat   yes, map_meta.txt is very useful in .txt form
21:47 paramat   as is world.mt. so i would be -1 for this