Time  Nick       Message
01:43 ANAND      Addressed the comments in #7588, anything else left to fix? :)
01:43 ShadowBot  https://github.com/minetest/minetest/issues/7588 -- Improve formatting of Player HUD flags documentation by ClobberXD
01:57 paramat    will look soon
02:04 ANAND      Thank you
09:20 Krock      Okay, the build & unittest succeed now in #7569 . I'm however afraid that rounding errors might cause the unittest to fail on other systems
09:20 ShadowBot  https://github.com/minetest/minetest/issues/7569 -- Send custom floats (log2) by SmallJoker
09:20 Krock      fighting against noise, basically
09:52 nerzhul    Krock, nice job !
09:53 Krock      thanks. But it needs testing :3
10:44 Krock      Merging #7589 and #7351 in 10 minutes
10:44 ShadowBot  https://github.com/minetest/minetest/issues/7589 -- Log server shutdown using actionstream by ClobberXD
10:44 ShadowBot  https://github.com/minetest/minetest/issues/7351 -- Allow enter to select items from combobox's list. by basicer
10:51 ANAND      Is a LATEST_PROTOCOL_VERSION bump required in #7557?
10:51 ShadowBot  https://github.com/minetest/minetest/issues/7557 -- Expose player FOV to Lua API by ClobberXD
10:51 ANAND      The custom floats PR bumps it from 36 to 37
10:52 ANAND      When is the proto version supposed to be bumped?
10:52 ANAND      Min proto version is bumped everytime backwards compat is dropped... right?
10:54 Krock      well, basically I only did it because http://irc.minetest.net/minetest-dev/2018-07-25#i_5366802
10:54 Krock      but it's 5.0.0-dev and the players yet don't use it on the public servers
10:55 Krock      so the protocol bump is just because it would mess up too much when connecting to an old server
10:57 Krock      for your case, a bump is not required because you don't need to check whether the client supports that feature or not
10:57 Krock      that's in particular for backwards compatibility
10:57 Krock      merging..
10:58 sfan5      ANAND: because 5.0 is a breaking release anyway we don't need to bump on every small change
10:58 sfan5      but for large changes it'd be nice to adhere to the bumping rule even if not technically required
11:06 Krock      Any comments for #7568?
11:06 ShadowBot  https://github.com/minetest/minetest/issues/7568 -- Check node updates whether the blocks are known by SmallJoker
11:08 sfan5      looked at it before and didn't see anything wrong
11:16 Krock      a good sign :) thanks
11:44 ANAND      Ah I see. Thanks for the clarification, Krock and sfan5 :)
11:54 nerzhul    Krock if i remember we updated the MIN version on this release, your PR can increase it another time
17:03 rubenwardy What should ContentDB use to differentiate Minetest versions internally?
17:03 rubenwardy Protocol version(?)
17:04 rubenwardy basically, you shouldn't see packages which don't support your version
17:04 rubenwardy and you shouldn't download releases which don't support your version
17:06 sfan5      protocol version is probably the best indicator you have
17:06 sfan5      you can ask users to enter which MT versions are supported and "convert" that to protocol version ranges
17:07 rubenwardy yes
17:07 rubenwardy that's my plan
17:19 rubenwardy sfan5: #7593
17:19 ShadowBot  https://github.com/minetest/minetest/issues/7593 -- Add protocol_version and supported package types to ContentDB urls by rubenwardy
17:19 rubenwardy github's split view is acting very strange for me
17:20 rubenwardy unified view too
17:20 rubenwardy probably my plugin
17:21 sfan5      why does the download url need a proto version
17:21 sfan5      looks good to me either way
17:22 rubenwardy because it should get the latest release which supports their version
17:24 rubenwardy I guess it should probably return the release ID in the request, then request a specific release in the download
17:25 sfan5      yeah that would be cleaner
17:26 sfan5      also identifying a download by author sounds terrible, what if a mod changes its owner?
17:27 rubenwardy I'll be using package ID soon for storing in mod.conf etc
17:27 rubenwardy for that exact reason
17:33 rubenwardy updated #7593 to do that, sfan5
17:33 ShadowBot  https://github.com/minetest/minetest/issues/7593 -- Add protocol_version and supported package types to ContentDB urls by rubenwardy
17:33 rubenwardy there's still a question on the URLs containing author
17:33 rubenwardy I think it's a good idea for when people link to packages
17:34 sfan5      lgtm
17:34 rubenwardy however it does cause issues if the author of a package happens to be changes after a user downloaded the list
17:34 rubenwardy I'll wait for CI then merge
17:34 rubenwardy and solve the package ID issue later
17:35 Krock      type=mod&type=game&type=txp
17:35 rubenwardy yes
17:35 Krock      does [your server language] allow reading them at the same time?
17:36 rubenwardy yes
17:36 Krock      nice
17:36 rubenwardy !title https://content.minetest.net/packages/?type=mod&type=game
17:36 ShadowBot  rubenwardy: Mods, Games - Content DB
17:36 rubenwardy also, Flask :)
17:40 rubenwardy Flask is <3
18:16 rubenwardy WTF
18:16 rubenwardy lint is suggesting mixed indentation
18:16 rubenwardy https://travis-ci.org/minetest/minetest/jobs/409339625
18:16 rubenwardy doesn't even line up
18:17 rubenwardy wait, it does
18:17 rubenwardy but still
21:54 rubenwardy will a memory limited process have a lower CPU %?
21:58 sfan5      what
21:59 rubenwardy from my understanding, unless the page is stored in storage the process won't become blocked
21:59 rubenwardy so the answer will be no
22:00 rubenwardy s/limited/bound/
22:49 rubenwardy merging #7593 in 10 minutes
22:49 ShadowBot  https://github.com/minetest/minetest/issues/7593 -- Add protocol_version and supported package types to ContentDB urls by rubenwardy
23:25 rubenwardy merging...