Time  Nick         Message
02:30 paramat      merging #7532
02:30 ShadowBot    https://github.com/minetest/minetest/issues/7532 -- Mgvalleys: Make river depth variation and humidity drop optional by paramat
02:35 paramat      done, phew
18:53 rubenwardy   updated #7469
18:53 ShadowBot    https://github.com/minetest/minetest/issues/7469 -- Formspecs: Add tooltip element for area by rubenwardy
18:54 rubenwardy   also game#2152
18:54 ShadowBot    https://github.com/minetest/minetest_game/issues/2152 -- Add sfinv.show_formspec() and sfinv.set_page_and_show() by rubenwardy
18:57 Krock        why is `show_formspec` needed for a tab switch? now you're getting the context twice
18:59 rubenwardy   the comment explains
19:00 rubenwardy   it allows mods to show the inventory
19:00 rubenwardy   which is useful if you show a dialog from an inventory window
19:01 rubenwardy   the alternative is maybe to have two names from the sfinv inventory
19:01 rubenwardy   that could be more efficient actually
19:01 rubenwardy   one for the builtin inventory ("") and one for shown ("sfinv:sfinv")
19:01 rubenwardy   then it could know whether it needs to show_formspec
19:02 rubenwardy   should I do that?
19:03 Krock        just a moment. I think I've just seen a way to crash the server by sending wrong sfinv fields
19:03 rubenwardy   lol
19:04 Krock        nvm, false alert. It's guarded by an if-statement
19:06 * rubenwardy reimplements mod channel API
19:19 Krock        uh well, sfinv is new lands to me - but what bothers me is the show_formspec in combination with set_inventory_formspec. One of them must be superfluous when using the navbar
19:20 rubenwardy   yeah
19:21 rubenwardy   I might do the inventory name thing thing
19:21 rubenwardy   *then
19:23 Krock        regarding #7469 - it'll cause errors on older clients
19:23 ShadowBot    https://github.com/minetest/minetest/issues/7469 -- Formspecs: Add tooltip element for area by rubenwardy
19:23 rubenwardy   5.0?
19:24 rubenwardy   ah
19:24 Krock        the mods would have to be marked 5.0-only. yes
19:24 rubenwardy   probably worth having a feature flag
19:24 Krock        indeed. code looks good, works.
19:26 Krock        clang tidy wants some changes for bool rect_mode = parts[0].find(",") != std::string::npos;
20:21 nerzhul      yeah, we don't have many blocking changes on tidy but it's interesting to look at its reviews sometimes