Time Nick Message 17:39 paramat the play store android app is still broken =) should it be removed until fixed? 17:40 rubenwardy probably worth reverting to the older version 17:41 Krock yes, removing has already been suggested. for now it would be best to revert it to 0.4.16 stable 17:42 Krock ^ nerzhul (speaking of the android apk, plyastore) 17:44 paramat #7439 17:44 ShadowBot https://github.com/minetest/minetest/issues/7439 -- Android: Crash while loading singleplayer world 18:40 nerzhul it's not possible to remove it, but i can generate a new 0.4.16 apk if needed 18:40 nerzhul where is the problem, i really don't understand, is this MTG code or MT ? 18:40 nerzhul MT code is correct 18:41 nerzhul and MTG is correct too 18:41 nerzhul is this builtin ? 18:42 nerzhul i just diffed the workspace with both 0.4.17 tags it's exactly the same code 18:53 rubenwardy updated #7454 18:53 ShadowBot https://github.com/minetest/minetest/issues/7454 -- Update to new ContentDB API by rubenwardy 18:53 rubenwardy Krock ^ 18:54 rubenwardy oh poo 18:54 rubenwardy turns out I made the PR from upstream/contentapi instead of rubenwardy/contentapi 18:55 Krock eh 18:56 rubenwardy #7459 18:56 ShadowBot https://github.com/minetest/minetest/issues/7459 -- Contentnewapi by rubenwardy 19:13 rubenwardy merging #7459 in 30 19:13 ShadowBot https://github.com/minetest/minetest/issues/7459 -- Contentnewapi by rubenwardy 19:17 Krock assuming 30 minutes 19:18 rubenwardy lol 19:18 rubenwardy nerzhul: I'm thinking on implementing support for offline player meta 19:19 rubenwardy easiest way would be having a map like std::map> in server 19:19 rubenwardy would nice to somehow allow this to be tested 19:19 rubenwardy essentially, the idea is that both player:get_meta() and minetest.get_player_meta() will group a ref_counted pointer to the player meta 19:19 sfan5 s/map/unordered_map/ :) 19:19 rubenwardy sure 19:20 rubenwardy and every save step it'll check to see if any of the metas don't have any more references, which case it'll unload 19:20 rubenwardy just wondering if there's a better class 19:22 rubenwardy well, I'll make a WIP patch for it, it could always be moved later 19:23 rubenwardy later as in before being merged ofc 19:31 rubenwardy argh, this is painful 21:13 nerzhul rubenwardy: why a shared_ptr ? the ref will be owned by lua stack ? 21:13 nerzhul if yes, it means you can retain some shared_ptr in lua and trigger anoying memleaks from lua stack when some mods are badly written 21:29 sofar sweet