Time  Nick        Message
06:07 paramat     will merge game#2147 in 15 mins
06:07 ShadowBot   https://github.com/minetest/minetest_game/issues/2147 -- Add longer log schematics by Ezhh
06:22 paramat     merging
06:26 larrythecow i just upgraded to 0.4.17.1 from 0.16.something and one of my mods caused the server to lock up when shutting down sometimes
06:26 larrythecow having just poked it for a bit this evening, it seems to be caused by a node that calls set_node_level() in on_construct
06:27 paramat     merged
06:27 larrythecow no crash, no errors, just the server locks up on shutdown
06:27 larrythecow i'll poke it more tomorrow, but thought others might be interested in the info
06:29 paramat     desktop i assume, not android
06:29 larrythecow gentoo desktop
06:30 larrythecow i'll configure it for a debug build and see what is eating up one of my cores, hopefully tomorrow if i have time
06:30 paramat     nice
06:31 larrythecow when i interrupt the stalled process in gdb, the main thread is just waiting on some mutex inside ::~Server()
06:32 larrythecow no debug symbols to know more atm
06:35 nerzhul     paramat updated #7449
06:35 ShadowBot   https://github.com/minetest/minetest/issues/7449 -- Version scheme change: 0.5.0 -> 5.0.0 by nerzhul
06:35 paramat     looking
06:40 paramat     added another comment
06:40 nerzhul     and it's fixed :)
06:41 nerzhul     i push a trivial variable removal (no-op variable)
06:45 paramat     no-op, ok :)
06:46 nerzhul     paramat 7449 okay to you ?
06:47 paramat     not yet, i added another comment
06:47 nerzhul     paramat as i said, it's fixed
06:47 nerzhul     oh
06:47 nerzhul     you commented on the fix
06:51 nerzhul     i updated
06:52 paramat     added a suggestion
06:52 paramat     lets see what others think later
06:57 paramat     yeah that's ok now
07:16 nerzhul     merging
07:16 nerzhul     ty for the reviews
07:33 paramat     ok will do the same for MTG
07:36 paramat     no need, seems it doesn't mention version anywhere :)
14:22 thoughtjigs How is https://github.com/minetest/minetest/pull/7445 looking now? Any more changes need to be made?
14:24 rubenwardy  #7445
14:24 ShadowBot   https://github.com/minetest/minetest/issues/7445 -- Xorg/net wm pid by thoughtjigs
14:27 sfan5       hm
14:28 sfan5       C++ style casts
14:28 sfan5       other than that it looks fine from a quick look
14:50 thoughtjigs Which lines were the C++ style casts showing up in?
14:51 sfan5       none, you should probably be using them
14:54 thoughtjigs Ahh, makes sense. I am an old C programmer ... not so sure about all this new fangled object oriented stuff ;-) I assume you mean that some of them should be static or dynamic casts instead?
14:56 sfan5       yes
15:05 thoughtjigs Several of those casts existed in the previous code (before my changes) should those be updated as well?
15:07 sfan5       would be nice yes
15:09 thoughtjigs Ok, will make it so.
15:09 thoughtjigs Thanks for taking the time to review
15:15 thoughtjigs By the way, I was the only devops working for pokemon at the time pokemon Go launched. I am taking a few months off from that exhausting period and would love to help out in any way I can. Been a while since I programmed in C/C++ Been working with mostly python, ruby, and ansible lately but the C/C++ stuff is coming back slowly :-) Let me know if there is anything I can do to help out.
15:19 sfan5       Any help is much appreciated, I think there'll always be a few open issues that are easy to fix even for newcomers to the project so take a look at the issue tracker.
15:21 thoughtjigs Any that are particularly high priority? I have the time now and would hate to spin my wheels on something you guys think is a low priority. I did review the issue tracker and there were quite a few issues.
15:23 sfan5       it doesn't really matter which priority the issues are, a contribution is a contribution. in any case, take a look at the issue labels: we have two(?) for issue priority
15:24 thoughtjigs Sounds great, will do.
15:52 thoughtjigs sfan5, changes pushed. If you could take a look at my casting choices that would be much appreciated. I think I got them right but a review would be great.
22:51 rubenwardy  #7454
22:51 ShadowBot   https://github.com/minetest/minetest/issues/7454 -- Update to new ContentDB API by rubenwardy
22:51 rubenwardy  ANAND: will fix your issue ^