Time  Nick       Message
02:09 rdococ     #7421 should be fairly trivial
02:09 ShadowBot  https://github.com/minetest/minetest/issues/7421 -- on_grant and on_revoke callback bug
11:04 ANAND      Greetings! I'm trying to build the NMPR version; it requires jThread which I've successfully built. How do I make 'make' (the application) detect jThread (located in ~/jthread)?
11:27 sfan5      what even is the "nmpr" version?
11:30 ANAND      Network Multi-Player Release (dev.minetest.net/Core_Architecture)
11:46 sfan5      uh huh
11:46 sfan5      looks like it expects jthread to be installed system-wide
11:46 sfan5      you'll need to edit the Makefile
11:48 ANAND      I see...
12:00 ANAND      um... sorry, but what exactly do I edit in the Makefile to enable system-wide installation? :)
12:01 sfan5      no
12:01 sfan5      you edit the makefile to look for jthread in ~/jthread instead
12:03 nerzhul    yeah ola for sfan5 :D
12:08 ANAND      Ah, you mean MT's Makefile. I was looking into jThread's... :P
12:36 Wuzzy      https://lpaste.net/raw/2738617915552038912
12:37 Wuzzy      this is what happens why i try to start a game in 0.5.0-dev
12:37 Wuzzy      9ca37d86a3f8fd35150880e3c64cb81796430d68
12:57 rubenwardy was fixed, local error ^
13:27 nerzhul    yeah
14:18 lisac      #7008
14:18 ShadowBot  https://github.com/minetest/minetest/issues/7008 -- Allow CSMs to register a function on keypress by lisacvuk
19:30 Krock      So what are we going to do with these two crash issues in 0.4.17?
19:31 sfan5      fix them and release 0.4.17.1
19:34 Krock      yes, same. #6092 can be fixed by backporting 014a1a080. However, what are we going to do with the deprecated log crash?
19:34 ShadowBot  https://github.com/minetest/minetest/issues/6092 -- Game crashes when up or down arrow keys are pressed while in pause menu
19:34 Krock      Various solutions exist but nothing's decided yet
19:38 Krock      just leaving this in the channel to not lose much time, since it might be the only reason why few servers are afraid of updating
19:48 sfan5      Krock: backport the fix?
19:48 sfan5      doesn't that work?
19:55 Krock      Yes, so #6708 would be handled afterwards - and not as a solution for this crash
19:55 ShadowBot  https://github.com/minetest/minetest/issues/6708 -- Add file and line to NodeDef field deprecation warning by rubenwardy
19:55 Krock      will open a fix PR
21:11 rubenwardy lol
21:11 rubenwardy why 0.4.17.1 but not 0.4.16.1?
21:12 paramat    0.4.18 is fine for me
21:14 nerzhul    did i said hmmmm is ridiculous because i'm not a forum admin i have no moderator status either ? xD
21:15 nerzhul    yeah i'm late, i know
21:17 rubenwardy seems very silly to introduce it for a patch to 0.4.17 when 17 is a patch to 16
21:19 nerzhul    i failed to solve the android linking issue in 0.4.17 but i should try to workaround proposed on the issue
21:19 paramat    17 doesn't seem a patch as it's a year on, it also has some non-bugfixes
21:19 paramat    but 0.4.17.1 is indeed more of a patch
21:20 Krock      nerzhul, would be glad if it could be added to the PR too
21:20 twoelk     patch 16, patch 17, patch 18, sounds like counting puddles by treading into them
21:20 rubenwardy no, as a bug fix release it is
21:20 Krock      .17 is our current patch.  the tailing .1 is now like in freeminer, called tweak :3
21:21 rubenwardy wow, look at me trying to convince myself that our version system has any sanity in it
21:21 paramat    well, no need to be strict with naming, 0.4.17 just seems right, 0.4.16.1 does not for a release a year on
21:22 rubenwardy that is what it is though, it's not a full release
21:22 nerzhul    in fact, a release is a release in a devel process
21:22 nerzhul    release => publish
21:22 nerzhul    the version should reflect what we do
21:24 paramat    also everyone is now used to it as 0.4.17, too late
21:24 sfan5      not that we aren't following the semver spec
21:24 sfan5      s/not/note/
21:24 rubenwardy yeah
21:24 rubenwardy I think it should be 0.4.18
21:24 nerzhul    it's 0.4.18
21:25 rubenwardy however I do think we should switch to semvar
21:25 nerzhul    we can do that for 0.5 if needed to be more agiles on patches
21:25 rubenwardy we will almost certainly need to make patch releases for 0.5
21:25 sfan5      rubenwardy: it should be 0.4.17.1 because we aren't following the spec
21:26 sfan5      4 is the major ver, 17 the minor version, 1 would be the patch
21:26 sfan5      since we've always had this constant 0. prefix in the beginning
21:26 rubenwardy then the 0. is pointless
21:26 rubenwardy :/
21:26 sfan5      the 0. is pointless in our current versioning scheme
21:26 rubenwardy that being said
21:27 rubenwardy maybe if we do add this then we can just drop the 0. at some point
21:28 nerzhul    +1
21:28 rubenwardy so go ahead with 0.4.17.1
21:28 rubenwardy hopefully someone will "accidentally" get rid of the 0.
21:28 rubenwardy in future
21:32 Krock      paramat, https://github.com/minetest/minetest/issues/7419#issuecomment-395892293  when there's a duplicate, we close the newer issue unless it contains more relevant information. #6798 is the same bug, just now in 0.4.17 instead of our master branch
21:32 ShadowBot  https://github.com/minetest/minetest/issues/6798 -- Fatal error in void log_deprecated() when 'deprecated_lua_api_handling = log or error'
21:32 rubenwardy 0.5.0.0   🤔
21:33 Krock      half way to 1.0
21:35 rdococ     0.10.0.0*
21:36 Krock      thanks rdococ
21:46 rubenwardy guys, I think we need to switch to svn   https://i.rubenwardy.com/bbk63.png
21:49 Fixer_     to cvs
21:53 paramat    Krock, ok :)
21:55 paramat    yes i agree to dropping the 0. go to 5.0.0
22:01 paramat    added new label 'PR open but not on Github' for #6898 etc.
22:01 ShadowBot  https://github.com/minetest/minetest/issues/6898 -- Allow distinguishing mods by modpack by pgimeno
22:01 sfan5      IMO we don't need a label for every tiny thing
22:01 sfan5      if the pr is considered worthy enough, someone should reopen it by pushing the changes to their own fork
22:02 paramat    that's necessary as the PR gets closed when the user moves
22:02 nerzhul    yeah this label is useless
22:02 nerzhul    a PR is a PR, this category ahs no sense
22:02 paramat    this will happen often and PRs will get forgotten otherwise
22:02 nerzhul    the user not on github relation is not interesting
22:03 nerzhul    also if user doesn't want to defend or answer our questions on GH why open the PR ?
22:03 sfan5      one (or two?) times is not "often"
22:04 sfan5      either way, does someone want to adopt that pr?
22:06 Fixer_     that PR should allow selecting modpack to play properly when there are mods/many-modpacks in /mods
22:16 paramat    will merge #7355 in 5 mins
22:16 ShadowBot  https://github.com/minetest/minetest/issues/7355 -- Mapgen flags: Add 'biomes' global mapgen flag by paramat
22:23 paramat    merging
22:25 paramat    merged
23:01 p_gimeno   6898 is more specifically about allowing several mods with the same name to exist in different modpacks without conflicts or any automatic arbitrary resolution
23:04 p_gimeno   in other words, about letting world.mt specify the full path where to load the mod from, and the user choose the exact mod to load