Time  Nick       Message
00:03 paramat    couldn't reproduce your crash, but here's the tested code https://github.com/minetest/minetest/pull/6746#issuecomment-388591177
09:22 Krock      nerzhul, also regarding the future backports for 0.4.18 - shouldn't we simply require C++11 to solve such issues?
09:22 Krock      Sorry for picking this up again but we'll only end up changing the code back to C++03 manually which is IMO nonsense
09:25 Krock      still, we can release 0.4.17 C++03-compatible (the commits are already there to fix it)
15:48 sfan5      backport is updated now!
15:57 ANAND      sfan5, new commit?
15:59 paramat    thanks
16:06 Krock      I'll amend the HEAD commit of backport. https://github.com/minetest/minetest/pull/6746/commits/26b6ab31de#diff-cf7e9e2b070b8a54073ec62af6f63ce9R178 was forgotten
16:06 ANAND      does it fix the "attempt to index local 'node' (a nil value)" bug?
16:07 sfan5      yes
16:07 ANAND      great! :D
16:07 paramat    ah i didn't realise that was in, good
16:09 paramat    hm i can't see it
16:10 Krock      hmm.. that's weird. Git thinks HEAD is "Fix luajit include not being found" - even after fetch/checkout
16:12 paramat    no item entity crash isn't fixed yet in backports, hopefully soon though
16:14 paramat    code is here https://github.com/minetest/minetest/pull/6746#issuecomment-388591177
16:38 sfan5      paramat: it is fixed
16:38 sfan5      wait where did it go
16:39 Krock      did we just conflict in pushing to abckports?
16:41 nerzhul    Krock i don't think a fix can be a major C++03 breakage
16:42 Krock      nerzhul, sorry?
16:42 nerzhul    if you are following a git flow stable-0.4 is a release branch and is attended to be stable in terms of API we are just pushing hotfixes to it
16:42 nerzhul    master (our develop branch if you read at git-flow) intend to have what we need for a next release
16:43 nerzhul    if we push a feature to 0.4.18 we will never accept to make 0.5 happen
16:43 Krock      oh. you're referring to the C++11 idea
16:43 nerzhul    0.5 is enoough mature, some features need polish but we are nearly ready for a release in the 3 next months i think.
16:43 nerzhul    yeah, sorry i'm late :)
16:43 sfan5      Krock: no, I must have lost the change somehow
16:44 Krock      okay. I'll edit the C++03 commit after you committed the builtin item fix
16:46 nerzhul    edit ? just push another fix no ?
16:46 nerzhul    we are you doing exactly ?
16:46 nerzhul    i can push more C++03 compilation fixes now if needed, i get 15 mins
16:46 sfan5      Krock: did you re-push the last 4 commits?
16:46 nerzhul    do you have some staged changed somewhere ?
16:47 Krock      sfan5, yes, to edit the C++03 commit
16:47 sfan5      oh so you want to edit it again
16:47 Krock      yes because it was overwritten :3
16:47 Krock      never mind
16:48 sfan5      ?
16:48 Krock      cached page. reloading now shows them
16:50 Krock      it's all fine. push the builtin item change to the branch
16:50 sfan5      done
16:50 Krock      nerzhul, yes sure. we just have to look that pushed aren't being blocked because someone else is editing it
16:50 Krock      great :)
16:51 paramat    thanks
16:52 Krock      nerzhul, I edited your commit to fix the m_cao = nullptr initialisation too, which was forgotten previously
16:53 nerzhul    Krock no problem, if it's in multiple commits it's not problematic for this branch :)
16:54 sfan5      keeping track of "forein" commits in the backports branch is hard enough, so it's better to keep it as a single commit
16:55 sfan5      foreign*
16:57 Krock      ^ that
16:57 nerzhul    i see
17:48 rubenwardy #7327
17:48 ShadowBot  https://github.com/minetest/minetest/issues/7327 -- Add package update detection
17:49 rubenwardy nerzhul: any objections to #7253 and #7302
17:49 ShadowBot  https://github.com/minetest/minetest/issues/7253 -- Add updating to online content repository by rubenwardy
17:49 ShadowBot  https://github.com/minetest/minetest/issues/7302 -- Add screenshots to online repository browser by rubenwardy
17:49 rubenwardy both have 1 approval
17:56 Fixer      was that PR about damage to people on boats also finally accepted?
17:56 Krock      accepted and merged. yes
17:56 Fixer      nice, ty
18:02 rubenwardy updated #7327
18:02 ShadowBot  https://github.com/minetest/minetest/issues/7327 -- Add package update detection
18:09 rubenwardy updated again
18:15 Fixer      rubenwardy: have you seen my error message about Content Browser?
18:17 Krock      "delete this;" fails. Interesting. https://github.com/minetest/minetest/issues/7272#issuecomment-388643466 (bottom report)
18:31 rubenwardy No?
18:31 rubenwardy Is there a github issue?
18:33 paramat    #7329 tuned vertical biome blend, simple PR
18:33 ShadowBot  https://github.com/minetest/minetest/issues/7329 -- Vertical biome blend: Improve PRNG seed for finer detail by paramat
19:24 Fixer      rubenwardy: i've posted error message directly to you twice in -hub
19:24 rubenwardy the best way to report issues is on the issue tracker :P
19:25 rubenwardy I'm very busy with other uni things so can't fix things immediately
19:26 Fixer      rubenwardy: in case it is minor, here is it https://pastebin.com/raw/mS3P0Y98 when pressed left arrow in content browser
19:28 rubenwardy hanks
20:01 paramat    best to open an issue, stuff gets missed and forgotten on IRC
20:40 rubenwardy merging trivial commit in ~5 minutes
20:40 rubenwardy https://github.com/rubenwardy/minetest/commit/9cc341e91face2c999a96e023ba43444c689164d
20:41 rubenwardy !title
20:41 ShadowBot  Update contentdb_url to content.minetest.net · rubenwardy/minetest@9cc341e · GitHub
20:45 rubenwardy done
22:23 paramat    will merge #7277 once i test again after renaming the mapgen flag
22:23 ShadowBot  https://github.com/minetest/minetest/issues/7277 -- Mgvalleys: Make the shallow/dry rivers an option by paramat