Time Nick Message 01:21 paramat merging #7227 (trivial) 01:21 ShadowBot https://github.com/minetest/minetest/issues/7227 -- Sun colour: Undo colour change. Remove double assignment by paramat 01:25 paramat done. 800 issues! 05:30 srifqi ~tell paramat How will we add shadow for button? Until now, nobody has already add drop shadow for that. 05:30 ShadowBot srifqi: O.K. 12:18 Krock https://pastebin.com/raw/PPnbDQe2 trivial fix for #6471 will merge in ~30 minutes unless 12:18 ShadowBot https://github.com/minetest/minetest/issues/6471 -- 2D player sprite: Incorrect offset 12:18 Krock can also confirm that after 6 years, the "critters" mod still works correctly: https://i.imgur.com/Z8MVOCd.png 12:18 nerzhul nice Krock 12:19 nerzhul wtf iamge 12:45 ashtrayoz3 ashtray tries to talk 12:47 ashtrayoz3 Well, that worked. So, #7231 is ready for review. 12:47 ShadowBot https://github.com/minetest/minetest/issues/7231 -- Document the use of "tools" in extended drop tables. by ashtrayoz 12:47 Krock ashtray was heard 12:57 Krock merging the 2D player sprite fix ... 12:57 Krock (or rather: pushing) 13:02 rubenwardy Krock: looks like it wasn't squashed? 13:02 sfan5 >:( 13:02 sfan5 krock pls 13:03 rubenwardy lol 13:03 rubenwardy quick, break gitlab! 13:03 Krock what 13:03 Krock what 13:04 Krock Note to myself: Check the applied patches before pushing.. oh god 13:05 Krock rubenwardy, heh.. not anymore, I hope :) 13:11 sfan5 merging #7174 in ~5 minutes 13:12 ShadowBot https://github.com/minetest/minetest/issues/7174 -- Key change menu: Fix empty string translation by minduser00 13:34 nerzhul gitlab force pulled now :) 14:15 Fixer I got crash trying to reach Change Keys tab after that fix 14:16 Fixer can you check if it crashes for you? 14:17 Krock 1 moment 14:20 Krock sfan5, you can't free static strings 14:20 sfan5 woops 14:21 Krock I believe it was also mentioned in the PR :P 14:22 Krock sfan5, irony is that you pointed out that this isn't possible when I suggested it: https://github.com/minetest/minetest/pull/7174#discussion_r177514302 14:22 sfan5 yes I said that myself, but in a different context 14:23 Krock my wrong idea has spread >:) 14:23 sfan5 hm it even says this in the comment above wgettext() 14:23 sfan5 this is why you don't change things at merge time 14:24 Krock and for MinetestBot spam you don't look before pushing 14:26 sfan5 Fixer: fixed. 14:26 Fixer will recheck now 14:28 Krock it's fixed now 14:44 Fixer bug fixed, yes 14:47 Fixer thank you 15:26 rubenwardy nerzhul: how can I bulk apply all code style corrections? 15:59 rubenwardy nerzhul: why is travis failing randomly? 7213 15:59 rubenwardy nerzhul: why is travis failing randomly? #7213 15:59 ShadowBot https://github.com/minetest/minetest/issues/7213 -- Run code style linter first by rubenwardy 16:09 rubenwardy I'll just disable it, it's pointless anyway 16:11 rubenwardy nerzhul: https://travis-ci.org/minetest/minetest/jobs/364172957 16:12 nerzhul rubenwardy: clang-format -i from the MT root folder 16:12 rubenwardy thanks 16:13 nerzhul for the random travis, ask travis themselves, it's pretty unstable these days... 16:19 rubenwardy YAML:20:35: error: unknown enumerated scalar 16:19 rubenwardy AllowShortFunctionsOnASingleLine: InlineOnly 16:19 rubenwardy clang-format version 4.0.0-1ubuntu1 (tags/RELEASE_400/rc1) 16:19 rubenwardy :/ 18:51 nerzhul rubenwardy please update to 5.0 at least 18:51 rubenwardy cba 18:51 nerzhul CI always use recent versions to have mroe features and be near MT code :) 18:51 rubenwardy can't find a PPA, so cba :) 18:51 nerzhul it's the .travis.yml ppa 18:52 nerzhul travis install the PPA before installing it ^^ 18:52 nerzhul what is cba ? 18:53 rubenwardy can't be asked / be bothered 18:59 nerzhul i see 18:59 nerzhul ty 18:59 rubenwardy I'll do it at some point, just not tonight :) 20:18 rubenwardy paramat: thoughts? #3068 20:18 ShadowBot https://github.com/minetest/minetest/issues/3068 -- blacklist for servers a player does not wish to see again 20:23 sofar I'd rather see a whitelist instead 20:25 rubenwardy #6236 20:25 ShadowBot https://github.com/minetest/minetest/issues/6236 -- Network protocol documentation 20:27 rubenwardy nerzhul ^ 20:27 nerzhul what do you want ? i documented my parts :p 20:27 rubenwardy I'm not the issue author 20:28 rubenwardy just wondering what you think of that 20:28 nerzhul just read the code, ti's documented if you want to implement it 20:28 nerzhul else, no interest to permit hacky client to be easily maintained or create a different server engine 20:28 nerzhul :p 20:28 rubenwardy I agree, the networkprotocol.h is pretty good 20:33 rubenwardy paramat: added http://dev.minetest.net/Code_style_guidelines#Spelling 20:47 rubenwardy ha #6766 20:47 ShadowBot https://github.com/minetest/minetest/issues/6766 -- Make LINT a separate check 21:01 paramat good work on issues 21:02 paramat lol good spelling guideline 21:20 Krock could care less actually 21:38 paramat i could care less than you 21:39 * rubenwardy shivers in disgust 21:41 rubenwardy paramat: I renamed the label to make us sound less lazy 22:05 paramat hmm that's not ideal for feature requests with no dev interest, PRs probably won't be accepted. but i could make another label 22:15 rubenwardy oh, by dev do you mean core dev? 22:16 paramat yes 22:17 paramat for me there are contributors and devs, even though contributors do dev 22:18 paramat maybe i should use core dev instead .. hm