Time Nick Message 05:50 srifqi nerzhul: Probably. Try to repush to Weblate. 07:47 nerzhul i should do it yes 07:47 nerzhul i will run update-po and push, weblate seems broken 07:47 nerzhul but i need to update translations before hmmm... 09:06 Krock nerzhul, 15th April for release sounds good but I'm not sure how much I can be online on that day 09:07 Krock same for the 14th, sadly 09:52 sfan5 who changed the "Bug" label to be orange/brown? aaaaaaaaaa 09:57 * Krock looks at rubenwardy 10:00 Krock "bugfix" also changed from light blue to orange.. not quite happy with that 10:01 Krock red is used in a negative context but a bugfix is positive :) 10:51 celeron55 could be github's doing as they updated some label stuff 10:51 celeron55 i don't remember our colors, were only those two changed? 11:32 rubenwardy I changed some which have black text on a dark color 11:32 rubenwardy Because github changed their algorithm so they were then unreadable 11:32 rubenwardy So I probably changed those 11:32 rubenwardy I see red as important rather than bad 11:33 sfan5 >what are traffic lights? 11:34 rubenwardy High priority is red 11:34 rubenwardy Is a high priority pr bad? 11:34 sfan5 of course not 11:34 sfan5 red can have both meanings 11:35 sfan5 having "bug" / "bugfix" as brown-orange-ish is just meh IMO 11:36 Krock celeron55, they must be changed individually. I noticed a few changes but for most of them I couldn't tell what color was used before :3 11:36 rubenwardy It's the redest they have 11:37 Krock *cough* #FF0000 11:37 rubenwardy That messes up the text colors 11:37 rubenwardy Well, if that was the red before then it does 11:39 rubenwardy Also, the current color is more red than brown or orange, and has good contrast with white 11:39 rubenwardy Wait 11:39 rubenwardy I have flux on 11:41 rubenwardy Put bug to red (which looked brownish with flux) and bugfix to a pastel color 11:41 rubenwardy Pastel blue 11:56 nerzhul yes the black + dark color is just ugly 12:47 nerzhul i pushed some updates on #6587 12:47 ShadowBot https://github.com/minetest/minetest/issues/6587 -- Optimize entity-entity collision by numberZero 12:47 rubenwardy niice 12:47 rubenwardy that PR has been waiting too ;pmg 12:47 rubenwardy *long 12:48 nerzhul if someone wants to finish to populate the unittests: go :) i added the main layer & do two unittests 12:48 nerzhul (there is 8 in total) 12:48 nerzhul this part is nice: https://github.com/minetest/minetest/pull/6587/files#diff-584c6d91e4a8b18bd848aa32a8dd872fR33 12:48 nerzhul it permits to use unordered map in many other places 12:48 rubenwardy I'll do it 12:49 nerzhul See from this: https://github.com/minetest/minetest/pull/6587/files#diff-4cea157bba21a6a9641fcbf897de2b9bR56 12:49 rubenwardy saw 12:49 nerzhul oh i did a mistake on testIsFreeID :p it should be false for zero case and i forget to test another random value as true 12:53 rubenwardy fixed 12:54 nerzhul heh, when all points are fixed and travis is okay, just merge it :) 12:54 nerzhul it's nice to edit user's PR to add some things instead of waiting the remaining fixes, sometime 12:54 nerzhul if i get time i will try to analyse some of our clang-tidy reported problem and fix the most anoyings 12:55 rubenwardy cool 13:03 rubenwardy 83 PRs though 13:09 rubenwardy errr 13:09 rubenwardy tests are failing elsewhere 13:09 rubenwardy Test assertion failed: buf.getF1000() == 53.534f 13:09 rubenwardy at test_serialization.cpp:472 13:10 rubenwardy we need colors for --run-unittests 13:18 Krock thanks for the review, rubenwardy 13:19 rubenwardy yw 13:19 Krock that particular error is already appearing for a long time. I suspect floating point errors there 13:19 rubenwardy all that's missing now are mod inventory notifications 13:20 Krock as the number is sent over the network, then divided by 1000 13:20 rubenwardy ie: there's no notiffication on a mod doing :add_item or whatever to the inventory 13:20 Krock wouldn't that result in a massive overhead? 13:20 rubenwardy happens with set_node 13:21 rubenwardy could also be done with a dirty flag, and just a vague "something has changed" notification 13:53 nerzhul float is not very precise 13:54 nerzhul but you can ignore it. On travis it never failes, hopefully 14:34 rubenwardy merging #5286 in 15 14:34 ShadowBot https://github.com/minetest/minetest/issues/5286 -- Inventory item mousewheel movement by HybridDog 14:35 rubenwardy ayone know the code around here? #4888 14:35 ShadowBot https://github.com/minetest/minetest/issues/4888 -- Handle multiple deserialization of a block's entities by Rogier-5 14:47 rubenwardy writing tests after thge fact is .. soo ... borin 14:50 rubenwardy merging... 14:51 Krock o/ resolving rebase conflicts 15:04 nerzhul nice job rubenwardy, just miss the touching but it's nice to see as it's a sensible part 15:18 nerzhul merging #7185 ty Krock 15:18 ShadowBot https://github.com/minetest/minetest/issues/7185 -- [Don't squash me!] Add player inventory callbacks & refactor by SmallJoker 15:20 Krock it must be some kind of algorithm behind the PR reviews in order to find out how long it takes to get a review 15:21 Krock thanks, I would've done that too in a few hours, so other devs would have more time to keep an eye on it shortly 15:21 nerzhul Krock in gitlab you have stats for that. For github maybe it's in the indsights but it's global 15:21 nerzhul you, ruben, m 15:21 nerzhul me 15:39 rubenwardy Krock: it depends on the author and the content I guess 15:39 rubenwardy and whether or not they post in this channel 15:40 rubenwardy so that PR would have been reviewed fairly quickly as it's a big defficit currently 15:40 rubenwardy but it was merged quicker because it's you 15:40 rubenwardy probably unfair but meh 15:41 Krock but it was merged quicker because it's you 15:41 * Krock gives rubenwardy a few more PRs of his to review 15:41 nerzhul so many issues reported by tidy in warning, many to fix (not all)... just pushed trivial #7189 to fix ~50 of them 15:41 ShadowBot https://github.com/minetest/minetest/issues/7189 -- Fix many issues reported by clang-tidy by nerzhul 15:41 rubenwardy lol 15:42 nerzhul will merge it in ~30min / 1h after build pass 15:42 nerzhul we should have a little performance gain in mapgen due to many float <-> double conversions the compiler cannot optimize 15:43 Krock nerzhul, LGTM 15:43 Krock heh, that's a minimal improvement 15:43 nerzhul after a bunch of minimal improvements we can have a big gain :) 15:44 nerzhul my reference was the following build https://travis-ci.org/minetest/minetest/jobs/360988547 15:46 nerzhul i think after fixing all performance-type-promotion-in-math-fn reported issue we can promote it to error to prevent regression on that part. Note: that doesn't mean we should use std:: everytime, but at least on each float, and it's the majority 15:50 nerzhul at a point i hope i can get time to finish integrating cmake for android build, but it's a pain to implement cmake on each non cmake supported third party software :( 15:57 rubenwardy Krock: reduce dark magic is very hard to review 15:57 rubenwardy XD 15:58 Krock Q: How to test? A: read instructions B: test C: ??? D: profit 15:58 Krock * C:\ ??? 15:59 Krock I know, it's better to not touch black magic but it's there and it must be burnt... slowly 15:59 rubenwardy lol 16:00 rubenwardy what's updateSelectedItem() supposed to do, and why does it have craftresult and craftpreview hard coded? 16:15 Krock they're hardcoded because they're also created in C++, hardcoded, and are not thought to be modified 16:16 Krock the upper code part (loop) ensures that the craftresult slot is emptied whenever possible, as it's not shown to the client 16:16 Krock the bottom if-check ensures the entire stack is selected after crafting 16:17 Krock as the crafting is the only situation where the itemstack becomes larger - in other cases it either changes the itemname or decreases to fill another slot 16:18 Krock I hope that explained it in an understandable way ^ rubenwardy 18:20 nerzhul has a force push been done on master ? gitlab repo sync failure to divergent masters 18:21 sfan5 Krock did so two days ago IIRC 18:21 nerzhul Allow changing the velocity of objects relatively (#3208) 18:22 ShadowBot https://github.com/minetest/minetest/issues/3208 -- allow changing the velocity of objects relatively to their current velocity by HybridDog 18:22 nerzhul the problematic commit 18:22 nerzhul i force push 18:22 nerzhul (on gitlab) 18:27 Krock yes, according to our rules that's allowed for 5 minutes after merge 18:32 sfan5 by the way the commit message is still not correct after that force push ;) 18:32 sfan5 it should be "relative to their current velocity" not "relatively to their current velocity" 18:33 Krock brb force pushing the entire world 18:36 rubenwardy Lol 18:54 paramat \80/ 19:03 nerzhul Krock: no problem for me, i know it's in the rule, i just wanted to understand why this was done to know the impact on gitlab :) 20:58 Krock lol nerzhul. are you running all travis jobs to try&error-fix all thrown compiler errors? 20:58 Krock I believe compiling it locally would be quite faster to fix all these errors 20:58 nerzhul not all, but 1 every 30 min to fix clang build because i miss a cmath header and i'm looking the tv with my wife :p 20:58 nerzhul i think last is the best 20:59 nerzhul on next PR i will compile locally with clang to prevent this heh 20:59 Krock no need to rush. fix the PR when you've got free time 20:59 nerzhul i don't rush heh 21:54 nerzhul nice NumberZero fixed the UT in #6587 21:54 ShadowBot https://github.com/minetest/minetest/issues/6587 -- Optimize entity-entity collision by numberZero 22:26 nerzhul nice there is now a setting to force the pull from remote on gitlab, then on future divergent branches we don't need to be involved