| Time |
Nick |
Message |
| 00:42 |
|
paramat joined #minetest-dev |
| 00:50 |
|
Icedream joined #minetest-dev |
| 00:56 |
|
Lymkwi joined #minetest-dev |
| 01:45 |
|
ID joined #minetest-dev |
| 02:10 |
|
paramat joined #minetest-dev |
| 02:49 |
|
AndroBuilder_ joined #minetest-dev |
| 02:53 |
|
AndroBuilder joined #minetest-dev |
| 03:58 |
paramat |
merging #7164 |
| 03:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/7164 -- Mapgen: Remove unused mgv7 code and some unused biometypes by paramat |
| 04:02 |
paramat |
merged |
| 04:03 |
paramat |
#7169 is tested and ready, 10% mapgen time optimisation |
| 04:03 |
ShadowBot |
https://github.com/minetest/minetest/issues/7169 -- Mgcarpathian: ZYX -> ZXY mapgen loop optimisation by paramat |
| 04:50 |
|
Warr1024 joined #minetest-dev |
| 05:25 |
|
Warr1024 joined #minetest-dev |
| 05:41 |
nerzhul |
rubenwardy: i don't see your point for 7131, it's the mod loader, not mod themselves |
| 05:41 |
rubenwardy |
Huh? |
| 05:42 |
rubenwardy |
Does it not add the ability to make Lua unit tests? |
| 05:42 |
rubenwardy |
Well, the ability to load mods to then unit test |
| 05:42 |
rubenwardy |
No framework yet |
| 05:45 |
|
Warr1024 joined #minetest-dev |
| 05:47 |
nerzhul |
absolutely nto it's a refactor which should permit to help to add CSM mod manager server side for sending mods |
| 05:48 |
rubenwardy |
Where did you add the ability to run mods during unit tests? |
| 05:48 |
nerzhul |
i never did that |
| 05:48 |
nerzhul |
i don't see where did you read that :o |
| 05:48 |
rubenwardy |
Oh right, thought you did |
| 05:49 |
nerzhul |
we can add a specific registration and call it from unittests if you need it, but testing mods is as complicated as testing Server or Game class :( |
| 05:49 |
rubenwardy |
I read about a change which runs a mod in minimal |
| 05:49 |
rubenwardy |
Not testing mods |
| 05:49 |
nerzhul |
oh you are right, this load minimal in the unittest phasis |
| 05:49 |
rubenwardy |
What for? |
| 05:50 |
nerzhul |
hmm not loading minimal |
| 05:50 |
nerzhul |
but preparing minimal for load |
| 05:50 |
nerzhul |
testing the mod loader, but not running it. Then it read the whole game and list all MT needs and verify it's good coreside for loading the game, but it doesn't load it, and cannot as we currently need a complete server for that |
| 05:51 |
rubenwardy |
Ah right, so the main purpose isn't to add Lua API tests |
| 05:52 |
rubenwardy |
I mean, still good |
| 05:54 |
nerzhul |
i hope at a point the core will be sufficiently refactored to add it, but currently it's not possible |
| 05:54 |
nerzhul |
i take this PR opportunity to test the mod loader without loading :) |
| 05:56 |
nerzhul |
i hope we can continue to increase code coverage, we regularly see regression (generally client side), with a good coverage they can be catched before merge |
| 05:57 |
rubenwardy |
Agreed |
| 08:48 |
|
proller joined #minetest-dev |
| 10:04 |
|
Gael-de-Sailly joined #minetest-dev |
| 10:35 |
|
troller joined #minetest-dev |
| 11:34 |
|
Fixer joined #minetest-dev |
| 11:58 |
nerzhul |
wow i just setup MT on my new laptop and the font size is crazy... 2px xD |
| 12:05 |
rubenwardy |
high DPI? |
| 12:12 |
nerzhul |
maybe yes |
| 12:12 |
nerzhul |
seems to be a problem with some android devices too |
| 12:12 |
nerzhul |
at least i have a testing hardware it seems :p |
| 12:13 |
nerzhul |
i just pushed #7172 , it's fairly trivial dep update, nothing special to review |
| 12:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/7172 -- Update jsoncpp to 1.8.4 by nerzhul |
| 12:13 |
nerzhul |
if someone can add approval :) |
| 12:16 |
|
IcyDiamond joined #minetest-dev |
| 12:29 |
|
Darcidride joined #minetest-dev |
| 12:35 |
|
Beton joined #minetest-dev |
| 12:39 |
|
Darcidride joined #minetest-dev |
| 12:51 |
|
Darcidride joined #minetest-dev |
| 12:59 |
|
Darcidride joined #minetest-dev |
| 13:17 |
nerzhul |
sfan5, rubenwardy, Krock |
| 13:17 |
rubenwardy |
busy, 1 sec |
| 13:17 |
nerzhul |
np |
| 13:20 |
rubenwardy |
here |
| 13:21 |
* rubenwardy |
reads the logs |
| 13:22 |
rubenwardy |
oh right |
| 13:22 |
rubenwardy |
this looks fine |
| 13:23 |
rubenwardy |
what was the json-related issue people had with compiling Minetest though? |
| 13:23 |
rubenwardy |
does this affect it at all? |
| 13:30 |
nerzhul |
no it's just a minor update, currently we are on 1.8.3 |
| 13:31 |
nerzhul |
the people related issue is just non C++11 compliant compiler or system jsoncpp problem with C++11 compiler |
| 13:31 |
nerzhul |
as Debian 9 has now near 1 year the compiler and system issue should disappear as it's related to Debian |
| 13:31 |
nerzhul |
Debian 8 |
| 13:32 |
nerzhul |
and as you see in gitlab CI pipeline, debian 8 build works well : https://gitlab.com/minetest/minetest/pipelines/19473379 |
| 13:33 |
|
troller joined #minetest-dev |
| 14:01 |
|
Darcidride joined #minetest-dev |
| 14:29 |
|
YuGiOhJCJ joined #minetest-dev |
| 14:36 |
|
Wuzzy joined #minetest-dev |
| 14:50 |
|
Maxou56800 joined #minetest-dev |
| 15:07 |
|
Krock joined #minetest-dev |
| 15:15 |
|
antims joined #minetest-dev |
| 15:31 |
Krock |
Will merge #7149 #7167 #7172 in 10 minutes |
| 15:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/7149 -- macOS: don't require X11 libraries during compilation by timcu |
| 15:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/7167 -- guard sound manager initialization with enable_sound by nOOb3167 |
| 15:31 |
ShadowBot |
https://github.com/minetest/minetest/issues/7172 -- Update jsoncpp to 1.8.4 by nerzhul |
| 15:38 |
|
Gael-de-Sailly joined #minetest-dev |
| 15:39 |
|
proller__ joined #minetest-dev |
| 15:43 |
Krock |
Merging... |
| 15:43 |
nerzhul |
ty Krock |
| 15:47 |
IcyDiamond |
I was wondering if it's possible to make a chest that keeps its contents when broken |
| 15:53 |
Krock |
yes, see minetest-mods/technic/wrench |
| 15:53 |
Krock |
the wrench allows picking up chests with contents. after placing them, the items are restored |
| 15:54 |
Krock |
in theory the same could be done with our chests in MTG, but I'm not sure if people would welcome that behaviour, so it's maybe better to use a mod which adds that |
| 15:54 |
IcyDiamond |
Alright, I use technic but I guess I missed the wrench. Thanks |
| 15:55 |
Krock |
np ;) |
| 15:55 |
Krock |
!next |
| 15:55 |
ShadowBot |
Another satisfied customer. Next! |
| 16:13 |
|
proller__ joined #minetest-dev |
| 16:41 |
|
Warr1024 joined #minetest-dev |
| 17:07 |
|
Darcidride_ joined #minetest-dev |
| 18:59 |
Fixer |
Krock: actually I will welcome that, since, IRL we move our stuff in chests and boxes! |
| 19:01 |
Krock |
Fixer, yes but it's recursive. You could put a filled chest into a chest into a chest into a chest |
| 19:01 |
Fixer |
Krock: forbid that |
| 19:01 |
Fixer |
Krock: because size requirements or smth silly |
| 19:08 |
|
proller__ joined #minetest-dev |
| 19:25 |
sofar |
on ITB, the node creator can create functional node creators |
| 19:26 |
sofar |
**mind blown** |
| 19:40 |
|
proller joined #minetest-dev |
| 21:28 |
Fixer |
? |
| 21:45 |
|
proller joined #minetest-dev |
| 22:15 |
|
Gael-de-Sailly joined #minetest-dev |
| 22:44 |
|
Miner_48er joined #minetest-dev |
| 23:16 |
|
Cornelia joined #minetest-dev |
| 23:52 |
|
paramat joined #minetest-dev |
| 23:53 |
paramat |
can anyone give #7169 a +1? well tested and i 100% know what i'm doing :] |
| 23:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/7169 -- Mgcarpathian: Mapgen loop optimisations by paramat |
