Time Nick Message 07:56 nerzhul hello, i pushed a little PR improving some performance and style in one mod function (i'm continuing slowly the CSM mod PR), and i backport some changes here 07:56 nerzhul https://github.com/minetest/minetest/pull/7108 09:15 Megaf Greetings gentlemen 09:15 Megaf and ladies 10:05 Megaf I like the way you are wiriting you cpp in minetest. I find it easy to understand and clear. 10:05 Megaf Most of the time that is 10:37 Megaf I support #7104 10:37 ShadowBot https://github.com/minetest/minetest/issues/7104 -- Spawn level: Add 'get_spawn_level(x, z)' API by paramat 10:40 Megaf Isnt there a better way of implementing #2052 ? 10:40 ShadowBot https://github.com/minetest/minetest/issues/2052 -- Update czech translation by JakubVanek 10:40 Megaf Instead of adding lots and lots of textures, just shift the colours or use some sort of layering? 10:40 Megaf ops 10:40 Megaf minetest_game#2052 10:41 Megaf that https://github.com/minetest/minetest_game/pull/2052 13:43 nerzhul yeah clang 6 released :) i should check if clang-tidy has been updated with missing features we need in indent 13:43 nerzhul i think i should re-work on the clang-tidy PR to ensure we have a good code quality and performance 18:10 nerzhul rubenwardy, Krock can you review the tiny https://github.com/minetest/minetest/pull/7108 please ? 18:38 Krock nerzhul, #7108 looks good. only 1 trivial comment 18:38 ShadowBot https://github.com/minetest/minetest/issues/7108 -- mods.cpp/h: little performance improvement in getModsInPath (+ codestyle) by nerzhul 18:39 nerzhul Krock and i fixed it :) 18:39 nerzhul if you are okay i will merge after travis pass in some time :) 18:39 Krock sure 19:03 nerzhul merging #7108, ty Krock 19:03 ShadowBot https://github.com/minetest/minetest/issues/7108 -- mods.cpp/h: little performance improvement in getModsInPath (+ codestyle) by nerzhul 19:04 Krock np 21:11 nerzhul wow i didn't realize in server class we did some tests which should be asserts in many setter + packet senders 21:11 nerzhul and i find an API wrong return :) 21:11 nerzhul i will push a cleanup PR in some minutes 21:28 nerzhul Krock if you get more time, here is one more PR: https://github.com/minetest/minetest/pull/7113 21:31 nerzhul oh nice Krock i miss this one too :) 21:36 Krock nerzhul, the other code looks good. I didn't test it but the functionality seems to be right (the same) 21:36 nerzhul yeah it's exactly the same :) 21:36 Krock paramat, I totally forgot that the docs were missing for the biome limit PR. good that you've added them :D 21:37 paramat i'll probably merge that tonight 21:37 nerzhul Krock i fixed the last point, if you can add your approval on GH could be nice, if it's okay i will merge after travis pass 21:42 nerzhul ty :) 22:00 nerzhul merging #7113 (unsquashed for clarity) 22:00 ShadowBot https://github.com/minetest/minetest/issues/7113 -- Various code cleanups (bugfix, cleanups, code quality) by nerzhul 22:01 rubenwardy nice 22:06 nerzhul ty rubenwardy for the review 22:06 nerzhul i got some minutes and i'm analysing the current server class, it's not easy to split i don't find on which way we can start currently, but some things to cleanup :p 22:07 rubenwardy I usually find it's best to work out and define a current system, with drawings 22:07 rubenwardy so what does server and the surrounding classes do 22:08 rubenwardy IMO server should have nothing but packet sending/receiving, like Client 22:08 nerzhul generally it's the case, but sometimes not due to the fact that Server is also an inventory manager for example 22:08 rubenwardy tbh, I've mostly looked at the client code and lua API 22:09 rubenwardy well, it would be good for server to pass on events (which can just be function calls) to an inventory manager which can then be tested 22:09 nerzhul yeah event based client & server are necessary for some scaling issues 22:10 nerzhul client should be event based between GUI (irrlicht) & client 22:10 rubenwardy agreed - rendering shouldn't be tied to logic 22:10 rubenwardy for a project as big as this anyway 22:10 nerzhul this will permit to keep FPS very high without being slowed by client code 22:10 nerzhul it's not easy to cleanup all of this hehe 22:11 nerzhul i need to work on CSM mod sending but i need to have more cleaner server on which to work 22:15 rubenwardy there's going to be a mod store in 0.5.0, btw 22:15 rubenwardy hopefully 22:16 nerzhul oh ? i didn't see any PR 22:16 nerzhul at a point we should release the 0.5 heh 22:16 nerzhul more than 9 months without any release 22:16 rubenwardy https://forum.minetest.net/viewtopic.php?f=14&t=19766 22:18 nerzhul why not doing it in golang instead of flask ? doing restful API with golang is as easy as flask, faster and lighter 22:18 rubenwardy frankly, our lecturer would not like that 22:18 rubenwardy and how about getting it done rather than arguing about technologies 22:19 nerzhul you already know i have the CSM server part :p 22:19 rubenwardy nice 22:19 rubenwardy look forward to seeing the result 22:19 nerzhul it's why i work on some cleanup 22:20 nerzhul currently it's near zero but i need to cleanup some server parts, and yes some PR will be unrelated due to my search :p 22:37 rubenwardy #7099 22:37 ShadowBot https://github.com/minetest/minetest/issues/7099 -- Add formspec theming using prepended strings by rubenwardy 23:00 paramat ugh please can we re-lock #6806 this person is insulting and very irritating. Shara 23:00 ShadowBot https://github.com/minetest/minetest/issues/6806 -- Hide or discourage mods in main menu based on mapgen choice 23:32 paramat meh typical that 4w tries to take the sneak issue in the worst possible direction 23:36 VanessaE 4w? 23:38 VanessaE oh. 23:40 paramat linuxdirk / dsohler 23:41 paramat very close to being considered 'bannable' =) 23:43 paramat aw i wanted to see kilbiths comment 23:43 paramat was it bad? 23:43 VanessaE I missed it. 23:43 paramat they need to be recorded before deleting 23:44 paramat he alway joins in when i'm involved in an argument 23:44 rubenwardy A remark about Ezhh being a core dev, with a meme of Michael from the office, and a remark about throwing peanuts 23:45 paramat ok counts as a nasty personal attack? 23:45 paramat c55 and i are counting 23:45 paramat i'll count it 23:46 paramat he's at roughly 7 or 8 out of 10 23:46 paramat for repo ban 23:48 paramat he obviously wants to hit 10 an ddoesn't care 23:49 rubenwardy Kilbith should have been banned immediately after c55 gave the 11 thing 23:49 rubenwardy as he said he would not follow them 23:49 paramat yes the be nice rule 23:51 rubenwardy it's 7