Time  Nick      Message
14:37 paramat   #7067 is updated tested and ready
14:37 ShadowBot https://github.com/minetest/minetest/issues/7067 -- SAO limits: Allow SAOs to exist outside the set 'mapgen limit'. CollisionMoveSimple: Collide with 'ignore' nodes by paramat
14:39 paramat   please can we merge this so it can be backported to 0.4.17 as a help against server attacks? =)
16:42 red-001   put that in #6746?
16:42 ShadowBot https://github.com/minetest/minetest/issues/6746 -- Backport 0.4 by sfan5
16:48 Krock     paramat, how about players that fall down a mine with a pond at the bottom?
16:49 Krock     if ignore is detected as a collision, that will cause damage
16:57 paramat   hmm
16:58 paramat   damage may depend on walkable being true, not sure
16:58 paramat   players already hit ignore and stop on long falls, i'll test
17:04 paramat   no damage luckily
17:04 paramat   players actually already collided with ignore somehow due to code elsewhere
17:06 paramat   i guess that falling damage doesn't happen for nodes that are walkable = false, like ignore
17:08 Krock     paramat, works for me but I'd like to have celeron55's option about the new approach
17:09 Krock     ... before merging
17:10 paramat   yeah me too
17:10 celeron55 well i was the one who suggested the latest changes, right?
17:11 celeron55 if it tests ok it's good to me
17:13 paramat   ok thanks
17:16 paramat   and yes i ran all the tests again
17:20 paramat   merging now
17:30 paramat   merged, good this will be very useful for servers, will add to backport todo
18:37 paramat   due to that the recent boats code is now not needed, so game#2061 (tested, trivial)
18:37 ShadowBot https://github.com/minetest/minetest_game/issues/2061 -- Boats: Remove now unnecessary 'ignore' node behaviour by paramat
18:38 paramat   theres 4 game PRs i'll merge later
18:40 paramat   will do a revert instead of game2061
18:41 paramat   so i've never done a commit revert before, how do i do this?
18:41 sfan5     git revert <commit hash>
18:43 paramat   after 'git clone', then 'git push'?
18:44 paramat   and a 7 character hash is enough?
18:44 Krock     6 chars might do too but the more, the more on the safe side you are
18:45 paramat   ok will use full hash
18:45 Krock     * after "git revert", then "git log" to check and "git push" if it's fine
18:46 paramat   ok
18:46 paramat   will try now
18:47 paramat   ok looks good
18:50 paramat   done and thanks
18:58 Krock     !next
18:58 ShadowBot Another satisfied customer. Next!