Time  Nick        Message
16:16 Megaf       Guys, one more aproval here please #6838
16:16 ShadowBot   https://github.com/minetest/minetest/issues/6838 -- Fix ambient occlusion by numberZero
16:16 Megaf       If you happy with it of course
16:17 sfan5       >Since i don't understand the code changes the 2nd approval should be from a dev who does.
16:17 sfan5       heh
16:17 Megaf       That made me lol too
16:18 Megaf       #6803 also seems quite ready for merging, from the same guy
16:18 ShadowBot   https://github.com/minetest/minetest/issues/6803 -- Optimize wieldmesh by numberZero
16:20 Megaf       And I'm not sure about #6660
16:20 rubenwardy  paramat: don't approve PRs you don't understand, even if tested
16:20 ShadowBot   https://github.com/minetest/minetest/issues/6660 -- Remove caching from getTextureDirs by numberZero
16:21 Megaf       rubenwardy: eh. https://github.com/minetest/minetest/pull/6455#pullrequestreview-66153867
16:21 Megaf       Sometimes you are not familiar either
16:21 * Megaf     giggles
16:21 rubenwardy  didn't approve
16:24 Megaf       I will leave my request for just those 3 PRs to be merged today. They seem ok to me
20:50 paramat     ShadowNinja !
20:50 paramat     please rebase #3827 it's an easy rebase
20:50 ShadowBot   https://github.com/minetest/minetest/issues/3827 -- Fix and clean up NCursesW finder by ShadowNinja
20:51 paramat     already approved
21:02 ShadowNinja paramat: The original bug was fixed in a different way (decbd39 and 27ee8d8), so it's mainly a cleanup now.  My version is much nicer, but this part of code is very platform-dependant, so I'd like some testing on various platforms to be sure it doesn't preak anything.
21:06 ShadowNinja Looks like that was the only commit, so a rebase would just involve choosing my version of the file.
21:09 ShadowNinja I'll rebase it.
21:10 paramat     oh ok
21:13 paramat     reopened
21:20 ShadowNinja paramat: Rebased, haven't compiled it yet though (I just did this in a relatively fresh VM that doesn't have everything set up for compiling yet).
21:24 Megaf       ShadowNinja: I'd like to say that is fantastic seeing you around again.
21:24 numzero     Why is ack_block_to_server passed through mesh generation?
21:28 ShadowNinja Megaf: Thanks :-)
21:42 ShadowNinja paramat: I compiled and made a tweak (seems like we aren't using libform, so I removed it).  It can be merged once it's tested on more platforms (I tested on debian 9, and Travis is on Trusty, I'd like to see a test from a more "unique" system).
21:43 paramat     ok
21:44 paramat     thanks for that
22:37 paramat     will merge game#1988 game#1997 game#2001 game#2003 in a few mins
22:37 ShadowBot   https://github.com/minetest/minetest_game/issues/1988 -- Fix furnace being able to cook items without enough fuel. by Ekdohibs
22:37 ShadowBot   https://github.com/minetest/minetest_game/issues/1997 -- Add use_textures_alpha to xpanes by MarkuBu
22:37 ShadowBot   https://github.com/minetest/minetest_game/issues/2001 -- Biomes: Make coastal grassy dune biomes larger by paramat
22:37 ShadowBot   https://github.com/minetest/minetest_game/issues/2003 -- Dry shrub: Use plantlike meshoption for bushy appearence by paramat
22:55 paramat     done