Time Nick Message 00:05 Hijiri could someone review #6688 and maybe tell me how to fix the build issue 00:05 ShadowBot https://github.com/minetest/minetest/issues/6688 -- Custom particle generators for particle spawners by raymoo 00:05 Hijiri or maybe just how to fix the build 00:09 sfan5 sounds like you forgot to include some c++ math header 00:09 Hijiri it's included 00:09 Hijiri problem happens at link time 00:11 Hijiri I feel like it's a cmake-related issue 00:14 Hijiri I noticed that before my change it doesn't look like anything in server.cpp depended on things in particles.cpp, though it included particles.h, but after my change it calls some functions that are defined in particles.cpp 00:15 Hijiri and also that particles.cpp is not being built before server.cpp 00:15 Hijiri I mean 00:15 Hijiri I mean that it isn't being built before minetestserver is linked 00:15 Hijiri Because it builds the ordinary minetest executable normally 00:22 rubenwardy so, about http://dev.minetest.net/Merging_core_pull_requests_to_upstream 00:23 rubenwardy quickly threw together this: https://i.rubenwardy.com/WobUQ3mWMJ.png 00:23 rubenwardy yay or nay? 00:24 rubenwardy celeron55 ^ 00:24 rubenwardy also changed the order, as code style should not be above good code 00:27 celeron55 the original format in the list in the wiki has been ordered easiest to check to hardest to check, not according to importance 00:27 rubenwardy ahh 00:27 rubenwardy I see 00:27 celeron55 anyway, "Good protocols and APIs" should read "Good protocols, serialization formats and APIs" 00:28 celeron55 or at least put that middle one somewhere, it's very important 00:28 celeron55 and one of the hardest 00:29 celeron55 i think i prefer the easiest to hardest order; it makes the checklist easy to approach 00:30 rubenwardy done 00:30 rubenwardy do agree on principal to having this on every new PR? 00:30 celeron55 i'm fine with trying it 00:47 rubenwardy updated the image 01:14 paramat i don't have any 'goals' for MT beyond what i'm currently working on =) 01:15 paramat apart from my todo list, but that's short term 01:31 paramat hm i guess there are some things i could say about simplicity 02:19 ThomasMonroe o/ celeron55 04:09 rubenwardy merging #6797 in 5 minutes 04:09 ShadowBot https://github.com/minetest/minetest/issues/6797 -- Adjust default console height by Ezhh 04:10 rubenwardy closed #3482 04:10 ShadowBot https://github.com/minetest/minetest/issues/3482 -- Add a command to toggle auto save of world 04:11 paramat i support the close 04:11 rubenwardy :) 04:12 rubenwardy so, 100 PRs before new years>? 04:12 rubenwardy :D 04:14 paramat yes, there are many with 1 approval that need reviews 04:14 paramat that should close a few 04:38 rubenwardy oops 04:38 rubenwardy merging now 04:48 rubenwardy paramat, what do you think about #5828 now? 04:48 ShadowBot https://github.com/minetest/minetest/issues/5828 -- Change default maxlevel to zero by CasimirKaPazi 05:00 paramat erm 05:00 paramat haven't thought enough about it yet 05:01 rubenwardy no worries 05:01 rubenwardy there's also this thing #6348 05:01 ShadowBot https://github.com/minetest/minetest/issues/6348 -- [WIP] Add NPC API by Dumbeldor 05:01 rubenwardy > The aim of the PR is to open the discussion to a unified API, and to identify the needs of such an API. 05:01 rubenwardy that's what issues are for... 05:01 paramat 6348 seems to be a co-op wth nerz, so is stalled at the mo 05:03 paramat hm yeah, seems an experiment maybe best in an issue 05:03 paramat or could be closed until it gets developed further 05:04 paramat hm no progress for 3 months 05:05 paramat maybe wait for a response, then consider a close 05:06 paramat i'll go through PRs again soon 05:06 rubenwardy yay 05:06 rubenwardy I'm almost done going through, would be nice to have a second pair of eyes 05:07 paramat ok will do 05:30 rubenwardy done reviewing 05:45 paramat will go over within a day or so 06:51 paramat red-001 you have a lot of open PRs that need work, please could you attend to them or let us know you've abandoned them? the 'adoption needed' label is only due to your absence, if you work on them it will be appreciated 15:11 rubenwardy merging #6188 in 10... 15:11 ShadowBot https://github.com/minetest/minetest/issues/6188 -- Allow 'default' parameter in 'settings:get_bool' function by AntumDeluge 15:26 Krock rubenwardy && rubenwardy->trigger(); 15:27 Krock sfan5, https://github.com/minetest/minetest/pull/5268/commits/8de5eebc 15:27 rubenwardy oops 15:27 rubenwardy I always do this 15:27 rubenwardy merging... 15:28 rubenwardy done 15:28 sfan5 Krock: looks good 15:29 Krock still pretty much code just to prevent sending private (for the client unchanged) meta packets 15:45 rubenwardy #6401 15:45 ShadowBot https://github.com/minetest/minetest/issues/6401 -- Add check to pause game on lost window focus by rubenwardy 15:46 rubenwardy seems to have a high approval rating in terms of emojis 15:46 rubenwardy I asked a few gamer friends, they say it's pretty standard 15:48 sfan5 agree 16:02 Krock +1. merge it. 16:02 Krock ..right after initializing https://github.com/minetest/minetest/pull/6401/files#diff-18513665750ef5adf42b5ec29e14162eR1490 16:03 rubenwardy that's safer I guess :D 16:05 rubenwardy ah thanks 16:05 sfan5 wait no 16:05 sfan5 ¯\_(ツ)_/¯ 16:05 rubenwardy didn't know how to do that :D 16:05 sfan5 note to self: don't type without thinking 16:06 rubenwardy sfan5 sets ban on *!*@* 16:06 sfan5 heh 18:18 Megaf Krock: Not sure I like that 18:19 Megaf I quite like having the game running in background 18:19 Krock we have a setting for this 18:20 rubenwardy it only pauses if no window is open 18:20 rubenwardy so I imagine you open the inventory to take your cursor away without pausing 18:20 Megaf And damage from falling nodes is a tricky one too 18:20 Megaf Like, it makes sense 18:21 Megaf but it changes gameplay and I'm not sure if the performance wouldn't be affected 18:21 Megaf rubenwardy: by window you mean, windows inside minetest? 18:21 rubenwardy yes 18:21 Fixer best part is its conserves the energy lowering fps down to 25 or so 18:23 Megaf If the game its paused I think 3 settings could be made, 1- Low FPS, down to 10 FPS even. 2- draw distance, set to 1, no need to render and see things far away. 3- somemthing about the cache? Stop using disk cache and cache only in RAM maybe? 18:25 rubenwardy the real question is will this be useful to more people than it's not? 18:25 Fixer no idea 18:26 Megaf The auto pause? I don't really know. 18:26 rubenwardy and people that will find it useful may not notice it if it's off by default 18:26 Fixer good luck with that, minecraft had it 18:26 rubenwardy however if it's on by default then people who are annoyed by it will look for a setting 18:26 Fixer sometimes it is pissing me off in mc, but not always, i want it configurable 18:28 Megaf Ì'd say let's merge it and make it default to on 18:28 Megaf with settign to turn it off 18:28 Megaf It makes sense and saving power on laptops will be very welcome 18:29 Fixer sometimes you want to just afk in background, without pausing the game, to farm, etc 18:29 Fixer default off 18:29 Megaf That's why I say I'm not sure I like that 18:29 Megaf It's complicated 18:30 Fixer i was certainly annoyed by that autopausing thing in minecraft modded, there was way to cirumvent it by opening some formspec 18:31 Fixer circumvent 18:31 Fixer * 18:34 Megaf can we add a checkbox somewhere visible? Name Auto Pause perhaps 18:34 Megaf or a push button 18:35 Megaf just to let players know there is this option 18:38 Krock Megaf, I'd have some settings suggestions for that mainmenu page too but there's too less space if checkboxes are used 18:39 Megaf We need a menu like the menu in Duke3D 19:55 Hijiri how do I build minetestserver? 19:56 Hijiri also where in the makefiles is minetestserver's dependencies specified? 19:57 Krock depends on irrlicht, sqlite3 and curl 19:57 Krock cmake -DBUILD_SERVER=1 -DBUILD_CLIENT=0 19:58 Hijiri Krock: if the first thing was your answer to my second question, I'm looking for where it specifies what source files to build before linking minetestserver 19:58 Hijiri Krock: If I have -DBUILD_SERVER=1 and -DBUILT_CLIENT=1 will it still built minetestserver? 19:58 sfan5 1) src/CMakeFiles.txt 2) yes 19:59 Hijiri I don't have a src/CMakeFiles.txt 19:59 Krock if you specify both, it will build both 19:59 Krock git checkout src/CMakeFiles.txt 19:59 sfan5 uh 19:59 sfan5 src/CMakeLists.txt then 20:00 Hijiri Krock: git checkout just said that file does not match anything known to git 20:00 Krock oh lol. Somehow I copied that mistake while I'm looking at the source online right now 20:00 Hijiri sfan5: I found it, but I can't find "minetestserver" with a text search 20:00 Krock Hijiri, * CMakeLists.txt 20:01 sfan5 look for add_executable(${PROJECT_NAME}server 20:01 Hijiri sfan5: Found that, also the place where they specify common sources 20:02 Hijiri which is where I guess I will need to add the file 20:02 sfan5 depends on whether your file is client-only, server-only or both 20:03 Hijiri It's particles.cpp, which used to only need to be compiled for the client, now it's needed for btoh 20:03 sfan5 then remove it from client_SRCS and add it to common_SRCS 20:03 Hijiri yep, building it now 20:04 Hijiri thanks for the help sfan5 Krock 20:05 Krock !next 20:05 ShadowBot Another satisfied customer. Next! 22:26 onk415 ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ DID YOU GUYS KNOW TODAY WAS NIGGERS DAY?? SAY HI TO YOUR FAVORITY NIGGER IN #FREENODE!! quicktalkeh676te.onionnkqpvajskn: TC01 exio4 Kray thePalindrome Warr1024 Calinou thatgraemeguy Guest50361 Lunatrius shivajiva Megaf silwol red-001 Raven262 Foz ^v Xio ShadowNinja Wayward_One garywhite ircSparky fireglow[m] torgdor dmu 22:26 onk415 ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ DID YOU GUYS KNOW TODAY WAS NIGGERS DAY?? SAY HI TO YOUR FAVORITY NIGGER IN #FREENODE!! quicktalkeh676te.onionzxcsh: nyuszika7h shivajiva thatgraemeguy Thomas-S Sockbat dzho Lunatrius TC01 ShadowNinja thePalindrome whitephoenix FourFire Lone-Star bigfoot547 Hijiri Warr1024 sofar exio4 loggin 22:27 whitephoenix that's how I know I'm connected to freenode still 22:28 Kray nice 22:33 fireglow happened on other nets aswell 22:33 fireglow anyway, time to detach 22:38 sfan5 why do i never get a highlight 22:46 whitephoenix Idk they have some weird nickname select system, everytime I've seen the message I've been pinged 23:18 red-001 huh didn't know we were big enough to get that spam 23:22 rubenwardy we're not a small project, as FOSS projects go 23:26 red-001 I guess, they probably just pick random channels that are within a certain size 23:26 Fixer that is crosschannel spam, was highlighted in other one 23:28 Calinou it's even cross-server, as that bot also has been striking a channel I'm in on OFTC