Time  Nick        Message
04:48 lhofhansl   Going to merge #6723 later tonight. Made one small change to ensure alpha is set on all vertices of a mesh.
04:48 ShadowBot   https://github.com/minetest/minetest/issues/6723 -- Allow Irrlicht caching of animated meshes by lhofhansl
05:06 lhofhansl   Still could use a review of #6721 (yes, I sound like broken record) :)
05:06 ShadowBot   https://github.com/minetest/minetest/issues/6721 -- Limit active object step time budget by lhofhansl
06:29 lhofhansl   Merged 6723
07:27 basicer     lhofhansl; it looks good to me for what thats worth.
07:30 basicer     Also I can't wait to try out the mesh caching patch you made on Pi, I think its going to be a huge perf win as mobs were a huge performance downfall last time I tested.
07:36 lhofhansl   basicer: Cool. Please let me know how it goes. I used to play around with nssm, but then it was so slow and laggy that I gave up on it. Now it's playable, at least on my machine.
07:37 nerzhul     !tell paramat i will re-do your CSM disable mod PR to include also the CSM sent mods if you agree
07:37 ShadowBot   nerzhul: O.K.
07:39 lhofhansl   6721 is last in the set of three of PRs to do that.
09:18 nerzhul     nore, there is already rate limits server side
09:18 nerzhul     i added it in 0.4.16 or 0.4.15
09:18 nerzhul     they just need to configure it
09:18 nerzhul     it's 8 messages on 10 sec by default
09:22 nerzhul     nore: https://github.com/minetest/minetest/blob/master/src/defaultsettings.cpp#L340
09:23 nore        nerzhul: ah, interesting
09:24 nerzhul     nore there is max_size, limit for 10 secs, and auto kick when too many message on 10 secs
09:24 nerzhul     https://github.com/minetest/minetest/blob/f470cb7270560a26afff0a0eadfc69070236c109/builtin/settingtypes.txt#L1032
13:30 nerzhul     sfan5, approved #6741
13:30 ShadowBot   https://github.com/minetest/minetest/issues/6741 -- Auth handler: Player deletion & Iterator by sfan5
13:45 sfan5       nerzhul: thanks
14:50 Wayward_One for the third time in a row, on a different machine, compiling with "-DRUN_IN_PLACE=1" still creates a .minetest folder..
18:12 Krock       sofar, #6745 , reverting the revision scheme changes. According to the changes, this will revert the version of backport-0.4 to 0.4.16 stable, which isn't quite what backport-0.4 is
18:12 ShadowBot   https://github.com/minetest/minetest/issues/6745 -- Inventory: Restrict access from too far away by sofar
18:13 Krock       but that only seems to be a left-over from the current stable branch..
18:13 sofar       wrong branch?
18:16 Krock       backport-0.4 is based on the stable one, which makes backporting this commit logical - but which isn't correct, as the backport branch is a in-development state, pretty much
18:16 sofar       you've lost me
18:16 Krock       ok
18:16 sofar       frankly, I was lost when I made the PR :)
18:17 Krock       In general the PR looks good. backports what's necessary with some salt in it
18:18 Krock       rubenwardy, "it's probably better to backport and fixes before this". what exactly do you mean? Delay this PR in favour of other bugfixes?
18:18 rubenwardy  no
18:18 rubenwardy  like the changelog
18:18 rubenwardy  if there's fixes in master before that commit, it's best to add those before that commit
18:18 rubenwardy  so they're not lost
18:19 Krock       alright I see. Not quite sure if that happened with the previous commits too but is indeed helpful to not miss a commit
18:21 Krock       the render engine rewrite also seems missing
19:49 sfan5       rubenwardy: are you fine with forcepushing the `backport-0.4` branch?
19:49 sfan5       (the only acceptable answer is yes, there's severe complications otherwise)
19:49 rubenwardy  sure
19:49 rubenwardy  what's the reason though?
19:50 sfan5       need to remove a commit & add a few older ones
20:04 Krock       "the only acceptable answer is yes". sfan5, when why do you even ask? :P
20:04 Krock       *then
20:04 sfan5       the git guidelines are unclear on whether they apply to all branches (and they usually do)
20:05 sfan5       so just to prevent anyone from complaining about rule violations later
20:05 Krock       that branch is new, not officially announced or used yet. so force pushing sounds fine
20:23 rubenwardy  > goes under 120 PRs
20:23 rubenwardy  > more openend
20:23 rubenwardy  such is mt dev
20:23 rubenwardy  at least most of our PRs were opened this year now
20:24 rubenwardy  !math calc 35/121
20:24 ShadowBot   rubenwardy: 0.2892561983471074
20:24 rubenwardy  like 71% are from this year
21:11 Fixer       and some of big ones just rott