Time Nick Message 00:07 paramat #6717 is fine will merge later with 6686 00:07 ShadowBot https://github.com/minetest/minetest/issues/6717 -- Fix lua_api.txt version numbers inconsistency and typos by Ezhh 01:14 paramat rubenwardy if you rebase #6670 i'll merge it later 01:14 ShadowBot https://github.com/minetest/minetest/issues/6670 -- CSM: Revert "[CSM] Add send_chat_message and run_server_chatcommand" by rubenwardy 01:15 rubenwardy I think it should wait a bit longer for discussion, don't want it being reverted again 01:24 paramat ok 01:28 paramat ~tell Krock "no need for all the rangelim if you adjust the one in camera.cpp to the real limits" actually the limits are different for client-set and server-set, so i think the PR is ok 01:28 ShadowBot paramat: O.K. 01:28 paramat #6650 is ready 01:28 ShadowBot https://github.com/minetest/minetest/issues/6650 -- Zoom: Set zoom FOV per-player using a player object property by paramat 05:34 paramat merging #6686 #6717 05:34 ShadowBot https://github.com/minetest/minetest/issues/6686 -- CAO/SAO: Nicer velocity-controlled, interpolated rotation by SmallJoker 05:34 ShadowBot https://github.com/minetest/minetest/issues/6717 -- Fix lua_api.txt version numbers inconsistency and typos by Ezhh 05:55 paramat done 07:25 ashtrayoz If I have a unit test for minetest (specifically for builtin), what is the best way for it be integrated and run? 07:26 sofar `make check` makefile target would be preferred 07:26 sofar there's also some testing code in the server 07:30 ashtrayoz make: *** No rule to make target 'check'. Stop. 07:30 ashtrayoz I must be looking in the wrong place. 07:31 ashtrayoz I can only see cmake_check_build_system 07:33 sofar yeah, I don't think `make check` is implemented 07:33 sofar forget I said it 07:33 sofar --run-unittests 07:38 ashtrayoz It looks like all of these are testing C++ code. Is there any infrastructure for testing lua code? 08:25 nerzhul merging #6695 in ~ 5 mins 08:25 ShadowBot https://github.com/minetest/minetest/issues/6695 -- Documentation for auth handler by sfan5 08:33 nerzhul done 11:10 rubenwardy ashtrayoz, there's unit tests in builtin.lua which are run when the server starts 11:11 rubenwardy I'd love to see proper lua unit tests though 11:58 ashtrayoz rubenwardy: I can see a few lines in common/serialize.lua - is that what you are referring to? 11:58 ashtrayoz I have written a test (https://gist.github.com/ashtrayoz/7f4304019614a7703d35337d4baa72bd) for #6604. 11:59 ShadowBot https://github.com/minetest/minetest/issues/6604 -- Preserve node metadata as item metadata. by ashtrayoz 11:59 ashtrayoz If I can integrate it somehow, then the PR is probably ready for review (perhaps by you). It has docco, it has had some people test it interactively, and it will have at least one unit test. 14:59 Wuzzy "ERROR[Server]: An unhandled exception occurred: Couldn't save env meta" 14:59 Wuzzy ↑ this just appeared in the log of an user of my subgame (MineClone 2) 14:59 Wuzzy is this an engine bug? 15:19 Wuzzy WTF. one of my users just had the weirdest crash ever. 15:19 Wuzzy https://hastebin.com/raw/amoresunat 15:20 Wuzzy relevant code: http://repo.or.cz/MineClone/MineClone2.git/blob/5fb9b8bad79fad0b5f047cf7235b375295167a16:/mods/MAPGEN/mcl_dungeons/init.lua#l80 15:20 Wuzzy "ServerError: AsyncErr: Lua: finishGenRuntime error from mod 'mcl_dungeons' in callback environment_OnGenerated(): Must only be called in a mapgen thread!" 15:20 Wuzzy the user got the crash on the first time of creating the world. but not when creating the second world. 15:21 sfan5 something is very wrong as mt believes that on_generated is not inside a mapgen thread 15:21 Wuzzy The error message also doesnt make sense. i have looked at my cod, but the function is definitely called in the register_on_generated 15:21 Wuzzy sfan5: my feelings, exactly! 15:32 Wuzzy sfan5: should i make issues about these 2 things? seems like not trivial :( 15:32 Wuzzy im just not sure what to write yet... 15:32 sfan5 sure, though i doubt there's going to be any meaningful results 15:33 Wuzzy any idea bout the "env meta thing"? 15:33 Wuzzy i got a better error message for that now 15:33 Wuzzy /home/stefan/buildbot/64/minetest/src/server.cpp:73: run: A fatal error occured: Couldn't save env meta 15:33 Wuzzy in 0.4.16 15:33 Wuzzy server.cpp:73 is BaseException(s) 15:34 Wuzzy hmm oops. no actually now 15:34 Wuzzy not* 15:34 Wuzzy https://github.com/minetest/minetest/blob/0.4.16/src/server.cpp 15:39 sfan5 writing the file failed for whatever reason, not much more to say 15:48 FourFire sfan5, this couldn't be related to OS file system issues could it? 15:49 sfan5 it could be related 15:49 FourFire My system seems to be entirely stable, it is installed on a RAID5 15:49 FourFire I'll try to duplicate the error on my laptop 16:02 FourFire Yep, same error 16:37 sofar the simplest explanation would be that the disk is full, or the person running the server doesn't have permissions to write to the folder (wrong user id, basically) 16:43 Wuzzy @FourFire: ↑ 17:00 FourFire Client: HexChat 2.12.4 • OS: Microsoft Windows 10 Pro (x64) • CPU: Intel(R) Core(TM) i5-5675C CPU @ 3.10GHz (3.10GHz) • Memory: 15.9 GiB Total (8.3 GiB Free) • Storage: 366.4 GiB / 465.2 GiB (98.9 GiB Free) • VGA: AMD Radeon HD 7700 Series, Intel(R) Iris(TM) Pro Graphics 6200 • Uptime: 1d 3h 33m 34s 17:00 FourFire so my disk isn't full. 20:25 paramat perhaps it's a good idea that server-provided CSM is developed in a new branch, due to the security issues and the careful testing needed? red-001 20:54 Krock paramat, the object property version change was done correctly. the network version could be raised too, but is not required as we're breaking the backwards compatibility and clients will get an error when connecting to the server 21:03 sofar can we do a bit better to separate "lua sandbox" concerns from "omg players are sending my server bad packets" concerns? 21:04 sofar treating one like the other is not just unfair, it's grotesquely irresponsible imho 21:05 paramat ok 21:07 paramat i'll just add a comment in networkprotocol 21:09 paramat my 'new branch' idea is a random thought, possibly not needed 22:15 paramat hmm dsohler is becoming a problem, warning given