Time Nick Message 08:10 hisforever Hi I like to build on flat world but I'd like to have a lake. How do I go about this? 10:19 paramat hisforever i'll answer in 'minetest' channel 10:26 paramat 2 minute attention span? ;] 18:41 VanessaE has anyone else had problems with minetest just randomly deleting auth.txt? 18:42 Shara VanessaE: Yup. Lost mine a few weeks back. 18:42 VanessaE and it's not an out-of-space issue? 18:42 Shara Definitely not. 18:42 VanessaE ok 18:42 VanessaE because it just hit two of my servers last night. 18:43 VanessaE (and I'm fairly sure it's not running out of space) 18:43 Shara Any idea of the size of the files? 18:43 VanessaE what should have been 679kB and around 2000 entries was down to 6kB and half a dozen or so entries. 18:44 sfan5 oh so it was losing entries? 18:44 VanessaE no, it's more like it deleted the whole file 18:44 VanessaE because what was there in the remaining file was clearly NEW accounts 18:44 Shara It was the same for me, but a much bigger file when it hapened. 18:45 Shara (thankfully I had a backup) 18:45 sfan5 hm i don't think the file saving code was changed recently 18:45 Shara sfan5: for me it was on current stable 18:45 nerzhul sfan5, no 18:45 VanessaE I keep backups, but space IS at a premium for me, so only the past day's worth 18:46 VanessaE this is 0.4.16 release 18:46 VanessaE (I don't track git) 18:47 VanessaE wasn't there some change just before 0.4.16 went out to default player accounts to sqlite? 18:48 sfan5 but that's not related to auth.txt 18:48 sfan5 filesys::safeWriteToFile() wasn't touched in over 2 years 18:48 VanessaE erm... player accounts ~= passwords and privs? :) 18:48 sfan5 wait the auth handler is in lua anyway 18:48 VanessaE I was thinking more along the lines of a migration bug actually 18:49 sfan5 VanessaE: what? there is no support for sqlite auth.txt nor has there ever been 18:49 VanessaE oh good. 18:49 sfan5 what you're thinking of is player metadata (pos, inventory, attributes) 18:49 VanessaE right. 18:49 Shara It happened on my server at a time when there'd been no recent changes at all 18:49 VanessaE In any case, it's happened to three of my servers (two last night, one some weeks ago), and Shara's, and fwiw the files in players/ were all still there 18:50 sfan5 well this is terribly open to corruption https://github.com/minetest/minetest/blob/master/builtin/game/auth.lua#L45 18:50 VanessaE the only thing I noticed that was questionable was a couple of invalid entries in auth.txt when I restored from backup 18:50 Shara I assumed in my case it was because the auth file got ridiculously big, and text files of that size aren't great 18:50 VanessaE but that gets caught at bootup. 18:50 sfan5 it should be doing create new + rename instead of rewriting the file in-place 18:51 sfan5 hm there's no lua api for safeWriteToFile() 18:52 sfan5 who thought this was a good idea? 18:54 VanessaE holy fuckballs 18:54 VanessaE root@daconcepts:/home/minetest/.minetest/worlds/Survival_World# ls -lah rollback.sqlite 18:54 VanessaE -rw-r--r-- 1 minetest minetest 160G Nov 1 19:53 rollback.sqlite 18:54 VanessaE um, excuse me? 18:54 VanessaE can we PLEASE get something done about that? 18:55 VanessaE technic machines and mesecons stuff, and other automated activities get recorded into the rollback log and there's no way to prevent it 18:55 nerzhul disable it or purge it yourself ? :p 18:55 * VanessaE sighs and disables rollback 18:56 sfan5 the problem with rollback is that it was never maintained in any way 19:00 VanessaE nerzhul: I used to purge them via a script but for whatever reason, it either quit working right or it was extremely slow, so I stopped doing it (and even if I had, it was set to purge >1 month entries, and I still ended up with massive multi-gig logs) 19:00 nerzhul lol sqlite, 160GB database... => slow 19:01 nerzhul i think you don't have indexes on what your query for deletion 19:01 nerzhul don't expect good performance for sqlite over 1GB 19:01 VanessaE # echo "DELETE FROM action WHERE timestamp < `expr \`date +%s\` - 604800`;" | sqlite3 rollback.sqlite 19:01 VanessaE you were saying? 19:01 nerzhul is there any index on timestamp in rollback db ? i don't think 19:02 nerzhul then sqlite will look at all records for remove some 19:02 VanessaE and, again, the root problem is there is no way to prevent actions from being recorded into the rollback, else technic and mesecons and the like would use such, and the log would be managable. 19:02 VanessaE manageable* 19:03 VanessaE I asked for this like 2 years ago 19:03 sfan5 nerzhul: i think sqlite automatically creates indexes, not sure 19:03 nerzhul sfan5, absolutely not 19:03 sfan5 maybe only in some cases ¯\_(ツ)_/¯ 19:03 nerzhul no 19:03 nerzhul it's like every relational db 19:04 nerzhul primary keys are indexed (normal), other fields are not 19:04 nerzhul sfan5, hopefully, imagine sqlite indexing mapblocks themselves :p 19:04 sfan5 that would be stupid indeed 19:36 Fixer looks like critical bug, file a bug 19:36 shivajiva Vanessa: you could try sauth and if you use sqlite for the player data you have an easy way of cleaning orphaned entries 19:38 Fixer VanessaE: vote here https://github.com/minetest/minetest/issues/6525 19:40 VanessaE I'll let Shara do it. 19:40 VanessaE (to file the bug I mean) 19:42 Shara I've already moved one server to sauth and will move the other over as well. 19:42 Shara Don't know why we're using a text file for this. 19:43 Fixer Shara: can you file a bugreport for that file corruption? 19:43 Shara I don't really know what to say about it, beyond "auth.txt ate itself" 19:44 Fixer Shara: describe the stuff you described here, that will be enough 19:46 Shara Sure, give me a moment 19:51 Shara VanessaE / Fixer: https://github.com/minetest/minetest/issues/6576 19:51 Fixer ty 19:51 VanessaE simpel and to the point. 19:51 VanessaE simple* 19:58 asl97 Since nobody brought up anything in the last few days, I squashed the latest commit, #6544 19:58 ShadowBot https://github.com/minetest/minetest/issues/6544 -- Middle drag + Left drag by asl97 20:02 Fixer asl97: nice job on that, minetest inventory management needs improvement, and that one is big step forward 20:22 Krock asl97, I just hope there won't be conflicts with my "reduce magic" PR 20:23 asl97 which pr would that be? 20:28 asl97 found it #6520 20:28 ShadowBot https://github.com/minetest/minetest/issues/6520 -- Selected ItemStack: Reduce black magic by SmallJoker 20:30 asl97 oh, i know that bug, it's cause it doesn't use the location thingy of the selected item 20:55 asl97 !tell Krock it does conflict from the look of it. 20:55 ShadowBot asl97: O.K.