Time  Nick       Message
00:23 Hijiri     sfan5: ok, thanks
01:40 paramat    lhofhansl hm actually i agree that settings should be changeable in main menu without a program restart, luckily we can use 'static thread_local' now
02:32 Hijiri     I shouldn't do the m_whatever member naming convention in new code right?
02:34 paramat    that's fine as far as i know
02:36 red-001    Hijiri, I honestly don't know
05:56 exio4      https://github.com/minetest/minetest/pull/6532
06:09 exio4      #6532
06:09 ShadowBot  https://github.com/minetest/minetest/issues/6532 -- Don't try to craft a non-existent item by EXio4
06:09 exio4      oh, it works with pull requests too :)
07:32 nerzhul    hello
07:32 nerzhul    merging #6530
07:32 ShadowBot  https://github.com/minetest/minetest/issues/6530 -- Cache server config settings. by lhofhansl
07:33 nerzhul    and #6105
07:33 ShadowBot  https://github.com/minetest/minetest/issues/6105 -- Real global textures by numberZero
09:33 red-001    #6528 is ready for review
09:33 ShadowBot  https://github.com/minetest/minetest/issues/6528 -- Make setting files per-world. by red-001
10:44 Krock      isn't it possible to simply set an override settings object for g_settings?
10:46 red-001    Krock, that would override the client settings as well
10:47 red-001    so we would basically be back where we started
10:48 Krock      why? that wouldn't write anything to the main minetest.conf
10:50 red-001    but client settings would also be saved to the server config then
10:52 red-001    tbh the settings the game sets at runtime aren't very important, but still
10:53 Krock      I see.. and a g_settings_server isn't a possibility either?
10:53 red-001    I could have implemented it like that
10:53 red-001    just though it would be cleaner this way
10:55 red-001    I would have needed to add a method for detecting if code is running on a server to a lot of stuff if I did that
10:57 Krock      okay
11:13 red-001    sqaushed the PR into 3 diffrent commits to make it easier to review
12:42 red-001    anyone working on #258?
12:42 ShadowBot  https://github.com/minetest/minetest/issues/258 -- Make it clearer that the first login to a server is also a registration
15:14 CalebDavis I noticed that you can only climb climable nodes if the lower half of the player is inside it is there a reason that it is like this?
20:47 Fixer      text on signs in 0.5.0, anyone brave?
20:50 red-001    can't say I am
20:53 rubenwardy not enough time :/
20:53 rubenwardy 0.5.1 though!
21:38 exio4      what is the standard procedure to add a new setting? (just saw there is a Settings tab in the main menu)
21:38 exio4      adding the default, using it with getU16 (giving an example) everywhere, and that's it?
21:39 red-001    exio4, what settings are you adding?
21:39 exio4      red-001: trying to tackle https://github.com/minetest/minetest/issues/6096
21:39 paramat    also add to builtin/settingtypes.txt
21:39 red-001    usually add to default settings.cpp
21:39 red-001    and settingstypes
21:39 paramat    that enables use in the advanced settings menu
21:39 red-001    optionally regenerate the example file
21:39 exio4      oh, was just checking src/, builtin/settingstypes.txt is the file I was missing :)
21:40 exio4      red-001: regenerate?
21:40 sc__       hi all, i'm going to pick up https://github.com/minetest/minetest/pull/2382 unless anyone has any objections
21:40 sc__       ie bind mouse buttons like any other key
21:40 red-001    exio4, minetest.conf.example is an auto generated file
21:40 red-001    from settingstype.txt
21:40 paramat    you can manually add the setting to minetest.conf.example if you want, but we often auto-generate that
21:41 red-001    huh did minetest get on front page of ycombinator or something?
21:41 paramat    sc__ good, appreciated
21:41 exio4      oh, I have missed this stuff (I haven't checked MT's source code for a few years)
21:42 exio4      red-001: Hacktoberfest, I guess :)
21:42 red-001    ah
21:42 red-001    don't follow that sort of stuff
21:43 exio4      red-001: Digitalocean gifts t-shirt(s) to people which make 4 pull valid requests (where a pull request is defined as invalid if marked as spam or invalid by the project)
21:43 red-001    what people wouldn't do for t-shirts?
21:44 exio4      everything!
21:45 exio4      how is the config file regenerated? / where can I find this info?
21:45 red-001    check the advance settings dialog
21:45 red-001    builtin/mainmenu
21:46 paramat    oh crumbs, 'hacker news'
21:46 sfan5      https://github.com/minetest/minetest/blob/master/builtin/mainmenu/generate_from_settingtypes.lua
21:46 sfan5      why exactly isn't that in util/ ?
21:47 exio4      I was look at it in util/, for what it is worth :)
21:47 red-001    sfan5, because it's needs to be executed by the main menu?
21:47 red-001    s/it's/it
21:48 red-001    paramat, huh?
21:48 sfan5      >file = assert(io.open("src/settings_translation_file.cpp", "w"))
21:48 sfan5      surely not
21:48 paramat    (that's what it says on the ycombinator MT article)
21:49 paramat    btw i can never get the translation file auto generate to work
21:50 red-001    sfan5, pretty sure the settings are phrased by the advanced dialog
21:50 sfan5      have you even looked at the file i linked?
21:50 red-001    yes
21:50 rubenwardy isn't it commented out by default?
21:50 red-001    notice `settings`
21:50 rubenwardy the dofile that includes generate_from_settingtypes.lua
21:50 red-001    rubenwardy, it is
21:51 sfan5      oh
21:51 red-001    if you looked at the advance settings dialog you would see it stores the settings in a variable of the same name
21:52 sfan5      thought you meant that it would be executed by default on startup to parse stuff (which it obviously doesn't)=
21:52 rubenwardy it makes much more sense to me to have it be a bash file which you could run with CI
21:52 sfan5      ^
21:52 rubenwardy and warn if a setting was forgotten
21:52 red-001    althrough I don't know why someone hasn't just coiped the phraser and made CI do this
22:55 paramat    #6519 is mostly done and testable now
22:55 ShadowBot  https://github.com/minetest/minetest/issues/6519 -- Biome API: Add underground decorations by paramat
22:57 red-001    can someone review #6067?
22:57 ShadowBot  https://github.com/minetest/minetest/issues/6067 -- [CSM] Add basic HUD manipulation. by red-001
23:12 Hijiri     how do I exponentiate an f32?
23:14 Hijiri     ok, found it to be powf
23:16 exio4      how are you supposed to actually regenerate the settings?
23:18 exio4      err, not the settings, the .example file
23:19 red-001    exio4, uncomment that last line of the advance settings dialog
23:20 exio4      ah, ok
23:20 red-001    dlg_settings_advanced.lua
23:21 exio4      a bunch of stuff was regenerated while doing that :P
23:22 red-001    yeah it regenrates the settings file and the translation file
23:23 exio4      it seems like it had not been regenerated for a few commits
23:38 exio4      just implemented #6096
23:38 ShadowBot  https://github.com/minetest/minetest/issues/6096 -- Make number of maximum displayed chat messages configurable
23:38 exio4      in #6535
23:38 ShadowBot  https://github.com/minetest/minetest/issues/6535 -- Configurable recent chat by EXio4
23:38 exio4      I came up with a config name on the spot, open to changes :)