Time  Nick       Message
10:22 nerzhul    sfan5, is this okay for you on #6515 ?
10:22 ShadowBot  https://github.com/minetest/minetest/issues/6515 -- Thread: fix a crash on Windows due to data race condition on Thread::m_start_finished_mutex by nerzhul
10:22 sfan5      yes it's fine
10:22 nerzhul    ty, merging in 5 minutes
10:22 nerzhul    it's nice i can build MT on VS2017 i can debug my network PR haha
15:11 red-001    can anyone review #6087?
15:11 ShadowBot  https://github.com/minetest/minetest/issues/6087 -- [CSM] Don't load the IO library. by red-001
15:40 paramat    nerzhul or anyone +1 for #6483 ?
15:40 ShadowBot  https://github.com/minetest/minetest/issues/6483 -- Retrieve extra speed-directed, narrow view cone to load blocks the player will encounter soon. by lhofhansl
15:41 nerzhul    sorry i'm busy
15:41 nerzhul    red-001, yes it should be review like all your CSM PR
15:44 paramat    i'll merge #6490 and #6514 later
15:44 ShadowBot  https://github.com/minetest/minetest/issues/6490 -- Correct smooth lighting at covered corners by DTA7
15:44 ShadowBot  https://github.com/minetest/minetest/issues/6514 -- Simple decorations: Make 'place_offset_y' usable with simple decorations by paramat
17:26 nerzhul    i will push a warning fix since recious merge
17:33 nerzhul    done
17:37 paramat    good thanks
18:18 paramat    can anyone review the formspec stuff in #6399 ? that PR just needs another +1
18:18 ShadowBot  https://github.com/minetest/minetest/issues/6399 -- Change the settings interface for noise_params, noise_params_group, flags, and v3f by srifqi
18:33 paramat    will merge #6490 #6514 in a few mins
18:33 ShadowBot  https://github.com/minetest/minetest/issues/6490 -- Correct smooth lighting at covered corners by DTA7
18:33 ShadowBot  https://github.com/minetest/minetest/issues/6514 -- Simple decorations: Make 'place_offset_y' usable with simple decorations by paramat
18:38 Krock      6399 processed
18:39 Krock      6490 seems to be less heavy than expected - I tried to compare the MapBlockMesh initializing code execution (which does everything). before/afterwards performance difference wasn't noticeable for me
18:43 paramat    good
19:00 paramat    merging
19:05 nerzhul    does someone experience a such problem ? "A fatal error occured: on_user_limitcheck must return a boolean"
19:07 paramat    merged
19:07 paramat    not me
19:08 Krock      someone warned you, nerzhul https://github.com/minetest/minetest/pull/6369#discussion_r136715913
19:08 paramat    120 PRs =O
19:09 Krock      a mod returns nil, that's the problem
19:10 nerzhul    Krock, strange the only callback i have in my tree is builtin
19:10 nerzhul    return privs["server"] or privs["ban"] or privs["privs"] or privs["password"]
19:11 Krock      this means all of them are nil
19:11 nerzhul    oh strange i'm with mtg
19:12 Krock      just remove that fatal error and interpret a non-"true" value as false
19:14 Krock      I guess this wasn't noticed earlier is because the script callback only gets executed when the limit is actually reached.
19:19 nerzhul    we can interpret nil
19:20 nerzhul    !lua_isnil
19:23 Krock      we could it treat like on_respawnplayer
19:23 Krock      same return value
20:01 Krock      Some testing results available for game#1914  (server owners?)
20:01 ShadowBot  https://github.com/minetest/minetest_game/issues/1914 -- Creative: Cache inventory items on load by SmallJoker
20:19 paramat    ^ Shara
20:19 paramat    game#1912 is finally ready, screenshot added
20:19 ShadowBot  https://github.com/minetest/minetest_game/issues/1912 -- Add kelp to cool and temperate shallow ocean by paramat
20:30 paramat    i'll add the shift override
20:32 paramat    .. then merge
20:33 paramat    the override is not done for waterlily either
20:54 paramat    ok that works
20:55 paramat    i always try to overrise with 'shift' and wonder why it doesn't work, then realise i have 'sneak' keymapped to X =)
20:55 paramat    *override
20:56 paramat    it gets called 'shift-rightclick' so much
20:59 paramat    will merge in a moment
21:01 paramat    please can anyone +1 #6483 ?
21:01 ShadowBot  https://github.com/minetest/minetest/issues/6483 -- Retrieve extra speed-directed, narrow view cone to load blocks the player will encounter soon. by lhofhansl
21:03 paramat    oh and game#1881 can i merge it? almost identical to the map mod
21:03 ShadowBot  https://github.com/minetest/minetest_game/issues/1881 -- Add binoculars mod with binoculars item to allow zoom by paramat
21:07 paramat    i'll merge game#1903 (+1)
21:07 ShadowBot  https://github.com/minetest/minetest_game/issues/1903 -- TNT: add tnt.boom defaults by tenplus1
21:09 paramat    game#1229 is approved but just needs testing
21:09 ShadowBot  https://github.com/minetest/minetest_game/issues/1229 -- Bones: Iterate player inventory lists dynamically. by t4im
21:13 paramat    i'll merge some game PRs in 20 mins, if anyone can +1 binoculars that would be great
21:45 nerzhul    FYI #6485 is nolonger a POC it's production ready (some last details needs to be enhanced before merge but PR is totally working)
21:45 ShadowBot  https://github.com/minetest/minetest/issues/6485 -- Rewrite the whole network stack to use ASIO by nerzhul
21:52 paramat    will merge game#1903 game#1912 in a moment
21:53 ShadowBot  https://github.com/minetest/minetest_game/issues/1903 -- TNT: add tnt.boom defaults by tenplus1
21:53 ShadowBot  https://github.com/minetest/minetest_game/issues/1912 -- Add kelp to cool and temperate shallow ocean by paramat
21:59 paramat    merging
22:07 paramat    done
22:12 paramat    underground decorations next i think
22:28 Fixer_     !tell nerzhul new crash: https://pastebin.com/raw/EEnpF1PL
22:28 ShadowBot  Fixer_: O.K.
22:51 Fixer      storing your items in crafting area feels cheesy enough?
23:05 VanessaE   I do that all the time, Fixer. :P
23:08 VanessaE   in a more on-topic comment, is there a list of what's planned for 0.4.17 (as opposed to 0.5.x) ?
23:10 paramat    not yet
23:10 VanessaE   ok.
23:11 paramat    but, devs are just beginning to think about it
23:12 VanessaE   fair enough.  you remember that colored itemstack stuff that Unified Dyes was waiting on.  I know that stuff's in master now, just curious if what I need will be in 0.4.17
23:12 rubenwardy only bug fixes, so no
23:12 rubenwardy afaik
23:12 VanessaE   feh.
23:15 VanessaE   when I last checked, the only thing missing was inheritance for drops
23:17 VanessaE   missing from 0.4.16that is.
23:42 Fixer      paramat: string is obsolete in mtg for now?
23:48 Fixer      without the use*