Time  Nick          Message
00:47 Hijiri        is get_pos() for players still at their feet? Or is it at their midsection?
01:34 Hijiri        Will you review #5819 now that it is a fix for a critical bug?
01:34 ShadowBot     https://github.com/minetest/minetest/issues/5819 -- Fix default item callbacks to work with nil users by raymoo
09:02 Krock         Pushing fix for game#1910 in 15 minutes: https://pastebin.com/raw/Ka1DUpL1
09:02 ShadowBot     https://github.com/minetest/minetest_game/issues/1910 -- Taking the last itemstack from bones node removes it without giving the bones node to the taker.
09:11 nerzhul       Krock, nice :)
09:14 Megaf         That's a new bug on 05 isnt it?
09:14 Megaf         I didnt see this bug on 0.4.17
09:18 Krock         it's new, yes.
09:21 Krock         ^ me, thinking about the wrong issue/context. Megaf: this bones "bug" exists for a long time
09:21 Krock         just nobody noticed it
09:21 Megaf         Oo
09:22 Megaf         but I died two days ago and I managed to get my bone box
09:23 Megaf         "I died two days ago and managed to get my bone box." <- Normal things in Minetest
09:48 jas__         +100 BEST COMMIT MESSAGE EVER
09:48 jas__         (sorry, didn't mean caps)
09:49 nerzhul       jas__, i think you are on the wrong chan
15:32 ThomasMonroe  hey paramat
15:44 paramat       Krock or anyone #6440 ? very simple. i searched for a cause for the volume imbalance (see thread) but it seems a simple gain multiplier is needed
15:44 ShadowBot     https://github.com/minetest/minetest/issues/6440 -- CAO footstep sounds: Reduce gain to balance volume by paramat
15:50 Krock         well then, looks good
16:05 paramat       ok
16:43 paramat       #5293 any comments? i feel it would be a big mistake to do damage in lua when large amounts of falling nodes are already very intensive
16:43 ShadowBot     https://github.com/minetest/minetest/issues/5293 -- Add damage from falling nodes by tenplus1
16:52 paramat       merging #6440 in a moment
16:52 ShadowBot     https://github.com/minetest/minetest/issues/6440 -- CAO footstep sounds: Reduce gain to balance volume by paramat
16:55 paramat       merging
17:05 paramat       done
18:28 Dumbeldor     Hi, can you check my PR pliz ? :) #5793
18:28 ShadowBot     https://github.com/minetest/minetest/issues/5793 -- [CSM] Add callback on open inventory by Dumbeldor
18:29 nerzhul       can you rebase it?
18:30 Dumbeldor     Yes i forget sorry x)
18:35 Dumbeldor     Yeah it's done nerzhul :)
18:38 nerzhul       Dumbeldor, i wait CI and will merge before going to bed if good
18:39 nerzhul       sfan5, are you okay with #6486 ?
18:39 ShadowBot     https://github.com/minetest/minetest/issues/6486 -- ParticleSpawner::step cleanup and rotation fix by SmallJoker
18:39 sfan5         yes
18:40 nerzhul       nice merging then
18:40 Dumbeldor     Ty
19:58 thePalindrome oin #gentoo
19:58 thePalindrome er...
20:09 nerzhul       merging #5793
20:09 ShadowBot     https://github.com/minetest/minetest/issues/5793 -- [CSM] Add callback on open inventory by Dumbeldor
20:17 paramat       rubenwardy don't forget game#1229 :] already approved but seems to need testing
20:17 ShadowBot     https://github.com/minetest/minetest_game/issues/1229 -- Bones: Iterate player inventory lists dynamically. by t4im
20:22 paramat       merging game#1877
20:22 ShadowBot     https://github.com/minetest/minetest_game/issues/1877 -- Minimap: Add 'map' mod with mapping kit item to enable minimap by paramat
20:23 rubenwardy    🎉
20:32 paramat       done
20:35 paramat       opinions on game#1569 please
20:35 ShadowBot     https://github.com/minetest/minetest_game/issues/1569 -- Generate dyes based on html color strings using a base and overlay texture. by treytomes