Time Nick Message 00:33 Hijiri 999 loop in lua is way less than 0.05 seconds 00:38 Hijiri running under normal (non luaJIT) lua, doing a 999 loop a million times took about 10 seconds, which means 0.00001 second per 999 loop 00:38 Hijiri I won't bother with luaJIT because it will probably optimize more than would actually happen since you wouldn't normally run the loop a million times 00:38 KaadmY Hm, that's faster than I remember 00:38 KaadmY Python is probably gonna be a lot slower 00:39 Hijiri actually I lied, I just tried luaJIT just because I was curious how it would perform 00:39 Hijiri it took 1.3 seconds to do all the loops 00:39 Hijiri so like an order of magnitude better than normal lua 00:40 Hijiri the functions called inside the loops will probably dominate in cost rather than loop overhead 09:48 paramat simple improvement for brightness detection #6117 needs another +1 09:48 ShadowBot https://github.com/minetest/minetest/issues/6117 -- Better defaults for background brightness detection by lhofhansl 09:49 nerzhul i don't like approve a PR with a FIXME comment :p 09:50 paramat i tested the customisable lighting curve, the default is very good and an improvement https://github.com/minetest/minetest/pull/5279#issuecomment-318880501 09:50 paramat hehe 09:50 paramat that #5279 also needs a +1 09:50 ShadowBot https://github.com/minetest/minetest/issues/5279 -- New lighting curve by numberZero 12:13 Krock hmm.. Minetest starts to throw a flood of errors: ERROR[Main]: FileCache: Can't write to file at /data/Minetest/run/bin/../cache/media/ 12:13 Krock last time this was fixed by simply clearing the cache directory manually.. I wonder why it pops up again 12:35 paramat btw what's the correct way to clear the cache? do i delete the media and tmp folders? 12:38 paramat weird, in tmp folder i only have 'tmp.ogg' which is the sound of TNT being ignited 12:38 sfan5 seems like the engine writes sounds to a file to load them or something similar 12:41 paramat guess it makes sense, the TNT mod is alphabetically the last with sound files in MTG 12:42 paramat and tnt_ignite is alphabetically last in the mod sounds folder 12:54 Krock but sounds are cached like any other media too 13:56 paramat yes, now cleared my cache, will see if that tmp folder happens again 15:01 paramat does anyone approve #6117 if i fix the comment on merge? simple PR 15:01 ShadowBot https://github.com/minetest/minetest/issues/6117 -- Better defaults for background brightness detection by lhofhansl 15:03 Krock The code is tested (rather) successful, thus, looks good to me 15:15 paramat ok will merge with #4929 #6175 #6185 soon 15:15 ShadowBot https://github.com/minetest/minetest/issues/4929 -- Make direct item selection keys freely bindable by Wuzzy2 15:15 ShadowBot https://github.com/minetest/minetest/issues/6175 -- GenericCAO: Fix dark model below y = 0 by paramat 15:15 ShadowBot https://github.com/minetest/minetest/issues/6185 -- Dungeons: Use biome 'node_stone' if normal stone types not detected by paramat 17:21 paramat will merge 4929 6117 6175 6185 over the next few mins 17:32 nerzhul #4929 #6117 #6175 #6185 17:32 ShadowBot https://github.com/minetest/minetest/issues/4929 -- Make direct item selection keys freely bindable by Wuzzy2 17:32 ShadowBot https://github.com/minetest/minetest/issues/6117 -- Better defaults for background brightness detection by lhofhansl 17:32 ShadowBot https://github.com/minetest/minetest/issues/6175 -- GenericCAO: Fix dark model below y = 0 by paramat 17:32 ShadowBot https://github.com/minetest/minetest/issues/6185 -- Dungeons: Use biome 'node_stone' if normal stone types not detected by paramat 17:43 paramat merging 17:51 paramat done 17:58 Krock Little improvement patch for the carts, taken from my recent boost_cart commit: https://pastebin.com/raw/KaqunAvW 17:59 Krock any +1s or shall I create a PR for this little fix? 18:15 Krock assuming this is trivial enough - merging it in 15 minutes if there are no objections 18:18 paramat +1