Time Nick Message 00:13 paramat i'm going to make a PR to reduce the load from the lavacooling ABM, it doesn't need to run every second 00:20 paramat game#1856 00:20 ShadowBot https://github.com/minetest/minetest_game/issues/1856 -- Lava cooling: Increase interval to 2 by paramat 05:37 nerzhul hello, merging #6176 in ~30 mins, thanks sfan5 for the review 05:37 ShadowBot https://github.com/minetest/minetest/issues/6176 -- Massive performance improvement on correctBlockNodeIds + various performance fixes by nerzhul 05:55 nerzhul if someone can take 5 mins to review #6177 05:55 ShadowBot https://github.com/minetest/minetest/issues/6177 -- Add LuaEntity on_death callback by nerzhul 09:19 nerzhul mergingh #6177 in ~15 mins 09:19 ShadowBot https://github.com/minetest/minetest/issues/6177 -- Add LuaEntity on_death callback by nerzhul 10:05 nerzhul can someone check #6179 ? 10:06 ShadowBot https://github.com/minetest/minetest/issues/6179 -- Move the nametag back to the top of the player by TeTpaAka 13:06 Fixer !tell paramat v7 mapgen seems broken, flatness everywhere 13:06 ShadowBot Fixer: O.K. 13:20 Fixer https://github.com/minetest/minetest/issues/6184 13:20 Fixer #6184 13:20 ShadowBot https://github.com/minetest/minetest/issues/6184 -- Mapgen v7 breakage 14:07 nerzhul Fixer, another user reported this to me today 14:07 nerzhul Fixer, do you get time for a bisect ? 14:07 nerzhul i didn't notice valleyz breakage on my today tests 14:07 Fixer nerzhul: it is just v7 breakage 14:11 Fixer nerzhul: i will check suspects 14:12 Fixer without bisect 14:14 nerzhul ok 14:24 lisac Fixer, sure that isn't a feature? It looks kinda nice 14:24 lisac um.. aside from those high edges 14:53 nerzhul sfan5, pushing the fix 14:53 Fixer nerzhul: ok, new suspect: Noise::perlinMap2D,3D: replace a loop init with a single memset call 14:53 nerzhul Fixer, oh 14:54 nerzhul okay it's me 14:54 nerzhul let me a second i push a warn fix i don't have in my compierl 14:54 Fixer nerzhul: i checked paramat last v7 commit and was fine 14:55 Fixer nerzhul: fault is between 0c99da4 and bc1654fe. 14:56 Fixer nerzhul: i will do one more compile to verify 14:57 nerzhul let me some minutes to understand why this commit can cause problem 14:57 nerzhul but thanks for bisecting 14:58 Fixer i have archive of compiled builds, so bisecting is easier for me 14:59 Fixer i did not really bisect this time, just selected 1 suspect, checked before/after and then checking before next suspect, since suspect one is already in compiled archive 14:59 Fixer 3rd compile will confirm it is that noise commit 14:59 Fixer in a few minutes 15:04 nerzhul okay i nderstand je problem i think 15:10 nerzhul okay i should revert it 15:10 nerzhul i wasn't careful about memset, char is okay but more than 1 byte initializer are not good 15:12 nerzhul reverting it 15:12 nerzhul pushing the warn fix + reverting bc1654feedc90caa8c26328ca6f0fc59fbe5b76c 15:15 Fixer yes, confirm it is that noise3d commit 15:16 rubenwardy would be good to have unit tests for this 15:17 rubenwardy how isolated is the mapgen code? 15:17 rubenwardy could you test it provides the exact same heightmap? 15:21 nerzhul rubenwardy, i agree some things required unittests 15:21 nerzhul a singlemapblock content or 100 nodes should be sufficient with perlin noise 15:22 rubenwardy has anyone ran minetest through lcov? Would be interesting to see the results 15:22 rubenwardy though likely unsurprising 15:22 nerzhul lcov is crazy to configure but if you can make it work having it on travis can be nice 15:23 nerzhul i didn't added cppcheck to travis because there are false positives on references, when cppcheck doesn't know in some rare case we need to modify the value or modify outside copy 15:26 rubenwardy interesting 15:26 rubenwardy I managed to get lcov working for another project in TeamCity 15:26 rubenwardy can travis display a tab like this? https://i.rubenwardy.com/dg7iiiPQrN.png 15:27 nerzhul travis doesn't display anything 15:27 nerzhul but gitlab can if needed 15:28 Fixer rubenwardy: is not something did run icov, and output was multipage long 15:28 rubenwardy yeah, given that it's all in one folder it would be 15:29 rubenwardy you also have to exclude stdlib 15:29 rubenwardy wait, the top level is directories 16:39 paramat phew thought i had broken mgv7 16:41 paramat please can anyone review #6175 ? important bugfix, tested and seems fine 16:41 ShadowBot https://github.com/minetest/minetest/issues/6175 -- GenericCAO: Fix dark model below y = 0 by paramat 16:41 lisac !seen cheapie 16:41 ShadowBot lisac: I saw cheapie in #minetest-dev 7 weeks, 6 days, 19 hours, 41 minutes, and 1 second ago saying "I don't know how it differs from position[], as neither is documented." 16:42 lisac oh no 16:42 lisac who'll develop chat6 16:42 lisac its like the best CSM there is 16:45 paramat game#1856 is very simple, sofar reported a constant excessive load from this ABM 16:45 ShadowBot https://github.com/minetest/minetest_game/issues/1856 -- Lava cooling: Increase interval to 2 by paramat 16:45 paramat game#1854 also simple 16:45 ShadowBot https://github.com/minetest/minetest_game/issues/1854 -- Increase the maximum level of the diamond axe to 3 by elinor-s 16:46 paramat game#1850 for close? 16:46 ShadowBot https://github.com/minetest/minetest_game/issues/1850 -- rename junglewood to rosewood by DS-Minetest 16:47 Krock agree 16:47 Krock approved the diamond axe PR 16:48 Krock increasing the interval of lava cooling will only spread the load - surely not reduce it 16:49 Krock however, it indeed reduces the amount of lookups when there's no cooling to do 16:50 Krock paramat, how about replacing the lava cooling with a VManip function? https://github.com/SmallJoker/minibase_game/blob/master/mods/default/functions.lua#L208 16:51 Krock the function gets triggered by short intervals of the called cooling function 16:53 paramat ok will look at that 16:54 paramat the lava PR will halve the load of node searching 16:56 paramat so useful for now 16:57 paramat oh and game#1849 is ok with a small fix rubenwardy 16:57 ShadowBot https://github.com/minetest/minetest_game/issues/1849 -- Separate player code into new mod by rubenwardy 16:58 rubenwardy oh oops 16:59 rubenwardy turns out s/player./players./g doesn't just catch variables :) 16:59 KaadmY Hehe 17:00 paramat i'll merge that later if no-one else has 17:01 rubenwardy so, I'd like to test it doesn't break a mod that uses the API (doubt it will) 17:01 rubenwardy also: what do you think about the name "players"? There's quite a high chance of variable shadowing 17:02 rubenwardy ie: local players = minetest.get_connect_players(); for player in players do players:set_anim(player,...) end 17:02 rubenwardy could be confusing 17:02 Krock why not player_models 17:02 Krock but that wouldn't include the attachments 17:04 KaadmY pl8yr 17:04 KaadmY Won't overlap any existing names 17:04 Krock thanks for your helpful contribution 17:05 KaadmY You're welcome 17:05 * KaadmY runs 17:05 paramat soon i might try to add a separate HUD flag for minimap radar mode 17:05 paramat 'plateyer' 17:05 KaadmY paramat: that's possible to overlap 17:05 KaadmY Due to typos 17:05 * KaadmY has misspelled player as platyer too many times 17:06 rubenwardy he's typing out how pl8yr is pronounced 17:06 rubenwardy I believe 17:06 KaadmY Ah 17:07 paramat yeah 17:07 paramat erm player_api? 17:08 paramat player_mod 17:09 rubenwardy ok, tested 17:09 rubenwardy hmmm 17:10 Krock player_api would be my fav 17:10 Krock pl-eight-er /me doesn't get it 19:16 paramat can anyone approve game#1856 ? also any objections to me merging this bugfix later? #6175 < rubenwardy sfan5 nerzhul 19:16 ShadowBot https://github.com/minetest/minetest/issues/6175 -- GenericCAO: Fix dark model below y = 0 by paramat 19:16 ShadowBot https://github.com/minetest/minetest_game/issues/1856 -- Lava cooling: Increase interval to 2 by paramat