Time Nick Message 00:25 benrob0329 rubenwardy: but semvar 00:49 KaadmY benrob0329: Minetest doesn't use anything remotely resembling semver in how it acts 00:53 benrob0329 KaadmY: well no, thus the point 02:05 KaadmY I think my lighting is PR-ready 02:05 KaadmY How do you rebase with a fork in a seperate branch? 02:25 KaadmY Thoughts on https://github.com/minetest/minetest/pull/6165? 02:36 octacian #6165 :P 02:36 ShadowBot https://github.com/minetest/minetest/issues/6165 -- Shading by kaadmy 02:37 KaadmY Thanks :D 06:25 nerzhul hello, i'm pushing a trivial loop cleanup in LBM 14:08 shalmezad So many header files.... feel bad for whoever reviews the merge once I'm done... XD 15:41 shalmezad Don't suppose anyone knows offhand how to run the linter locally? 15:50 sfan5 take a look at the travis scripts 15:52 shalmezad Found it, thanks (required setting LINT=1). 15:57 nerzhul merging #6164 in ~ 5 mins 15:57 ShadowBot https://github.com/minetest/minetest/issues/6164 -- Clouds API: change speed from 'y' to 'z', ColorSpecs in Lua docs by bendeutsch 16:02 nerzhul shalmezad, you mean the problem on the pragma once header PR you published ? 16:03 nerzhul if it's that, run clang-format (3.9 verison minimum) on all problematic files (clang-format -i ) when you are at the project root directory 16:03 nerzhul it will fix errors you added 16:04 shalmezad Nice, thanks. Also, does travis only run the linter on modified files, or the entire project? (noticed running it showed problems in files I didn't touch) 16:04 nerzhul yes only the modified files 16:04 nerzhul and non whitelisted files 16:06 shalmezad Alright. Will finish it up after work then. Shouldn't take too long. Thanks for helping getting my feet wet with this project. 16:06 nerzhul take your time :) 16:06 nerzhul i don't understand why you are angry against the ifndef define endif in every header but pragma once is far more better 16:08 shalmezad Not angry at all. Just pointed out it wasn't technically standard and wanted to make sure it was ok to make the switch. :) 16:09 shalmezad That, and it's been a few years since I touched C++ so #pragma once is new to me. 16:10 nerzhul pragma once is not standard but commonly agreed by eC++11 compilers, then it's standard by usage not by norm :p 16:18 shalmezad As for changing all the headers, figured if I were doing 8, might as well do the rest for consistency, especially since it's fairly easy once a couple quick vim recordings are defined (one to find first #ifndef to verify it is a headerguard, second to remove current line, next line, insert #pragma once, find last occurrence of #endif, remove). :P 19:51 KaadmY nerzhul: what about the code styling changes for #6165? 19:51 ShadowBot https://github.com/minetest/minetest/issues/6165 -- Shading by kaadmy 22:42 paramat #6167 22:42 ShadowBot https://github.com/minetest/minetest/issues/6167 -- Mgv7: Add 'mount_zero_level' parameter by paramat