Time Nick Message 05:54 nerzhul hi 05:54 nerzhul merging #5976 in ~10 mins 05:54 ShadowBot https://github.com/minetest/minetest/issues/5976 -- Update list of installed files concerning server and non-RUN_IN_PLACE builds by sfan5 07:17 Calinou red-001: note, that PR was poorly done, it doesn't cover all edge cases 07:18 Calinou like, if your camera hits a wall, it will suddenly become closer 08:02 red-001 oh Calinou 08:02 red-001 I meant 08:02 red-001 game#1772 08:02 ShadowBot https://github.com/minetest/minetest_game/issues/1772 -- Add nil value checks to the book formspec handler. by red-001 12:31 nerzhul hi sfan5 , can you look at #5968 and validate it please ? 12:31 ShadowBot https://github.com/minetest/minetest/issues/5968 -- Fix no sound bug by Rui-Minetest 12:34 sfan5 nerzhul: the changes to ItemDefinition::deSerialize are interesting 12:35 sfan5 since the comment says // If you add anything here, insert it primarily inside the try-catch 12:35 sfan5 that implies a version bump is not needed, but it actually is needed for some reason 12:37 nerzhul sfan5, yeah, i don't know exactly why it's done like this because it's totally wrong 12:37 nerzhul exception is sent only for strings 12:42 sfan5 each itemdef is always contained in a string: https://github.com/minetest/minetest/blob/master/src/itemdef.cpp#L549 12:42 sfan5 so a version increase is not needed 12:43 sfan5 which error does readF1000 return when there are not enough bytes available? 12:44 nerzhul it just crash no ? it's a low level reading if i remember 12:45 nerzhul NetworkPackets are protected against reading outside packets but i don't think ti's the case for Itemdefs 12:45 sfan5 std::istream will protect against this too 12:46 sfan5 https://github.com/minetest/minetest/blob/master/src/util/serialize.h#L334 it should probably check is.gcount() no? 12:46 sfan5 i'm pretty sure is.read() does not raise exceptions for this kind of problem 12:47 sfan5 here's what the string methods do https://github.com/minetest/minetest/blob/master/src/util/serialize.cpp#L127 12:52 nerzhul yes strings are okay, but F1000 => https://github.com/minetest/minetest/blob/f2f9a923515386d787a245fac52f78e815b3a839/src/util/serialize.h#L116 12:52 nerzhul F1000 -> S32 -> U32 13:00 nerzhul erf sorry network problem 13:20 sfan5 nerzhul: those are the functions for u8* data, the std::istream wrapppers are the ones i linked before 13:21 sfan5 celeron55: is it intended that the stream wrappers for readU32() / etc do not check whether enough bytes are available in the stream? 14:08 celeron55 sfan5: probably not 14:21 nerzhul sfan5, can i push the following diff (unused legacy file with empty function...) 14:21 nerzhul https://pastebin.com/kvAsqepM 14:22 sfan5 sure 14:22 nerzhul okay pushin it 15:12 nerzhul merging #5968 in ~10 mins 15:12 ShadowBot https://github.com/minetest/minetest/issues/5968 -- Fix no sound bug by Rui-Minetest 15:23 sfan5 nerzhul: that should be fixed properly instead of this way 15:23 sfan5 we don't need a version bump 15:24 nerzhul if you ahve an idea to cleanup this fix don't hesitate, it unlock current master but don't hesitate to enhance it 15:48 nerzhul if someone can take 5-10 mins to review #5984 it's a simple an boring C++11 conversion in part of our code 15:48 ShadowBot https://github.com/minetest/minetest/issues/5984 -- C++11 patchset 9: move hardcoded init parameters to class definitions (part 1) by nerzhul 15:49 Bobr2 i would but i have no idea about anything like that so i wouldnt be mmuch use sorry 16:06 glut32 hi 16:06 glut32 hi all 16:06 Bobr2 hello 16:07 glut32 I would like to hide error on the screen of minetest. How to do that? 16:08 Bobr2 may i ask what error it is 16:08 glut32 in code or in a minetest.conf 16:09 glut32 irrlicht image size 16:09 glut32 irrlicht image size something : i dont remember 16:10 Bobr2 i think u have to change the size of the images or something however i am not famlar so i cannot be sure 16:11 glut32 I would like to use minetest in a school and I would to remove all non-mandatory messages 16:11 glut32 I would like 16:12 glut32 Do you think that --quiet arg is ok? 16:13 glut32 / Quiet mode, print errors only 16:14 glut32 I would like the inverse of quiet mode : print only info 16:15 sfan5 that would be a good addition 16:18 glut32 how could you call this feature? 16:18 glut32 *name 16:19 glut32 --onlyinfomessages ? 16:22 sfan5 --quiet sounds fine 16:34 Bobr2 welcome back 17:13 Bobr2 wb krock 17:26 sfan5 this is not the channel to say hello to people 17:27 Bobr2 ok im sorry 17:27 red-001 wait we accually do other stuff her? 17:27 red-001 here* 17:27 red-001 there* 17:27 red-001 somewhere* 17:36 paramat rubenwardy sfan5 Krock nore ShadowNinja if possible could you consider game#1740 and game#1758 (i'll agree to 1740 if 1758 goes ahead)? also your opinion on my suggestion here https://github.com/minetest/minetest_game/issues/475#issuecomment-306005299 17:36 ShadowBot https://github.com/minetest/minetest_game/issues/1740 -- Use slabs and stairs to craft full blocks again by Wuzzy2 17:36 ShadowBot https://github.com/minetest/minetest_game/issues/1758 -- Stairs: Use one recipe matching inventory appearence by paramat 17:37 VanessaE paramat: you have a /msg 17:38 paramat ok just seen it 17:39 VanessaE someone earlier informed me of a similar crash. that /msg may be the same thing, I don't know. 17:39 paramat i have a restriction on PMs, trying to see how to accept 17:40 Krock well, for the red dye thing.. just make dyes optional. If the red dye wasn't found, use the white textures and craft recipe 17:41 VanessaE paramat: figure it out? 17:42 paramat ugh sorry, i accepted you but can't see how to see the message 17:42 Krock also, I'm fine with both PRs 17:42 red-001 paramat, if you have the mode flag set that I think you have set you need to accept people before they send you the pm 17:43 VanessaE ok screw it 17:43 red-001 otherwise the message just gets droped 17:43 VanessaE that's all it was. 17:44 paramat ok, i'll stop using the mode then 17:44 paramat too much trouble 17:45 glut32 sfan5, --quiet already exists 17:46 paramat back in a moment 17:48 nerzhul VanessaE, i want to see where is this f*****g facedir : 2, i never found where it was generated in code :p 17:48 VanessaE ? 17:48 nerzhul i looked at your log and see facedir: 2 which was triggered from... nowhere in code :p 17:49 rubenwardy it's possible that crash is my fault, VanessaE 17:49 nerzhul inable to find it with grep and to find where does it come from 17:49 rubenwardy if it's book serializaion thus meta related 17:49 paramat ok, msg restrictions removed 17:50 paramat (it's obvious who's to blame for me needing that :]) 17:52 red-001 paramat, set the flag for blocking unlogged in users 17:52 paramat ok 17:52 red-001 oh and if this is that someone /ingore *!~root@* 17:52 red-001 ignore* 17:53 paramat thanks 17:54 Bobr2 or u could just set it so unregistered users cant contact you 17:54 rubenwardy Bobr2, paramat, set the flag for blocking unlogged in users 17:55 Bobr2 i thought that mode was +R 17:55 paramat yes i'll use R 17:58 paramat for beds i was planning to just 'register' a 'simple white bed' using 3 white wool 17:58 ShadowBot https://github.com/minetest/minetest/issues/1775 -- Random segfault at fetching server list 17:58 red-001 :/ 17:58 nerzhul red-001, ? 17:59 ShadowBot https://github.com/minetest/minetest/issues/1775 -- Random segfault at fetching server list 17:59 nerzhul game#1775 17:59 ShadowBot https://github.com/minetest/minetest_game/issues/1775 -- Limit the size of the book. by red-001 18:00 sfan5 can you stop using [off] for no reason, thanks 18:00 red-001 well I guess I can 18:00 VanessaE and someone just crashed my server again with the same exploit 18:00 red-001 the people abusing this already know about it 18:02 red-001 so I suggest that we limit the size of the book unless someone has a better idea about how to stop this from crashing servers 18:02 Bobr2 i agree with red 18:03 red-001 unless someone has a valid reason for storing all of romeo and juliet in a book which I somehow doubt 18:03 VanessaE PR applied to my servers. 18:05 paramat restricted book size is a good idea anyway 18:05 paramat i'll merge that later 18:06 paramat along with 1740 rebased 1758 1772 1774 18:12 red-001 VanessaE, do note the fix will only stop new bugs from being created that could crash the server 18:12 red-001 if they already have such books they can still use them 18:14 VanessaE already covered. 18:14 Plebs exisiting "hacked" books can be found with: .minetest/worlds/*worldname*/find players/ -size +100k 18:15 VanessaE btw, it's the test from a Harry Potter novel. 18:16 VanessaE text* 18:16 VanessaE looks to be the first of the series. 18:17 * red-001 is disapointed 18:17 red-001 the last time they used shakespears romeo and juilet 18:17 red-001 I was hoping for hamlet 18:17 Bobr2 lol 18:18 red-001 and if they were going for magic they should have went for the clearly better lord of the rings trilogy 18:33 Krock paramat, well done. /s https://github.com/minetest/minetest/issues/5970#issuecomment-308274440 18:33 Krock the bug already existed before. it's only visible now because the damage is handled in the sneak code 18:39 paramat ok, part of the bug existed before 18:40 paramat nerzhul #5972 updated as requested 18:40 ShadowBot https://github.com/minetest/minetest/issues/5972 -- Mgv6 mudflow: Avoid floating stacked decorations by paramat 18:43 nerzhul good names, we can understand the variable usage in function :p 18:43 nerzhul i'm okay with code if feature is okay merge 18:46 paramat ok, retesting .. 19:11 paramat ok i'll merge a lot of game PRs later 19:13 nerzhul sfan5, can you review #5984 please ? i need to continue this cleanup :) 19:13 ShadowBot https://github.com/minetest/minetest/issues/5984 -- C++11 patchset 9: move hardcoded init parameters to class definitions (part 1) by nerzhul 19:20 paramat will merge games 1740 1758 1772 1772 1774 1775 now 19:41 paramat merged, but i forgot game#1543 will merge that now 19:41 ShadowBot https://github.com/minetest/minetest_game/issues/1543 -- Add 'creative' privilege for survival servers by tenplus1 19:51 Fixer hmmmmmmmmmmmm 19:52 nerzhul wtf 19:52 nerzhul 1543 is a little bit hacky 19:52 nerzhul why not have a good privilege name instance of mixing creative/survival word ? 19:52 Fixer bunch of entities after explosion scattered near walls @ new TNT explosion pushes some iron entity completely into sand 19:52 paramat merged 19:53 Fixer during testing of #5973 19:53 ShadowBot https://github.com/minetest/minetest/issues/5973 -- LuaEntity: Depend collision on entity size by SmallJoker 20:32 red-001 game#1776 20:32 ShadowBot https://github.com/minetest/minetest_game/issues/1776 -- Book: Also limit the max size of the title. by red-001 20:33 red-001 I forgot that the title isn't trimed when making the previous PR 21:06 paramat ok 21:14 VanessaE updated my servers and added that ^ 21:38 paramat game#1777 21:38 ShadowBot https://github.com/minetest/minetest_game/issues/1777 -- Crafting: Remove duplicate reversed recipes by paramat 21:40 paramat i'll merge #5972 later 21:40 ShadowBot https://github.com/minetest/minetest/issues/5972 -- Mgv6 mudflow: Avoid floating stacked decorations by paramat 23:35 paramat merging #5972 23:35 ShadowBot https://github.com/minetest/minetest/issues/5972 -- Mgv6 mudflow: Avoid floating stacked decorations by paramat