Time  Nick       Message
03:27 paramat    will merge game#1742 in an hour
03:27 ShadowBot  https://github.com/minetest/minetest_game/issues/1742 -- Settings: Use new settings object by paramat
03:29 paramat    can anyone approve #5798 ? bugfix for release
03:29 ShadowBot  https://github.com/minetest/minetest/issues/5798 -- Mgv6 mudflow: Remove decoration if 'dirt with grass' below flows away by paramat
05:26 nerzhul    hello ! merging #5808 & #5809 in ~10 mins
05:26 ShadowBot  https://github.com/minetest/minetest/issues/5808 -- Add formspec escaping to subgame list in create world dialog by rubenwardy
05:26 ShadowBot  https://github.com/minetest/minetest/issues/5809 -- Minimal: Add river water nodes by paramat
05:27 paramat    ok
05:27 paramat    how about #5798 too?
05:27 ShadowBot  https://github.com/minetest/minetest/issues/5798 -- Mgv6 mudflow: Remove decoration if 'dirt with grass' below flows away by paramat
05:28 Raven262   SO river water in minimal? xD
05:28 Raven262   *SO
05:28 Raven262   *So
05:28 Raven262   sry for spam
05:29 paramat    yes unfortunately it's essential for mgvalleys
05:30 Raven262   Is it now required for aliasing in new biomes?
05:30 Raven262   i mean for aliasing when making all new biomes
05:30 paramat    erm, any subgame must provide the 'mapgen alias' (as in default/mapgen.lua)
05:31 Raven262   Yes, now for river water too?
05:31 paramat    as it is a base terrain node required by core mapgen
05:31 Raven262   Ah.
05:31 paramat    yes
05:31 Raven262   Okay
05:32 paramat    so, it's as important as air, stone, water, which are the other 3 base terrain nodes
05:33 paramat    but no need to define it in each biome, if undefined, 'default river water' is used as the fallback
05:34 Raven262   So there is a possibility that mapgen would place river water even though my biome is eg. desert?
05:35 paramat    yes, this happens in MTG, but you could define your desert biome to replace river water with air, or mud
05:35 paramat    or sand
05:35 Raven262   Ah, yes, sorry didn't think of that.
05:35 Raven262   That is actually a very good idea.
05:42 Raven262   Btw, i found that sometimes a layer of stone generates at the surface of the biome, i found this to be in v7 only.
05:43 Raven262   Here is a screenshot of this in lott subgame: http://i.imgur.com/LVTUiD5.png
05:43 paramat    that happens if there is air under the surface node
05:43 paramat    thanks for merge
05:44 paramat    hmm that's something different
05:44 paramat    i bet that's at y = 47
05:44 paramat    or, i suspect it is
05:45 Raven262   I think i could find this world to confirm, moment.
05:45 paramat    a lot of work went into avoiding that so i don't know what is causing that. maybe biome definitions
05:46 nerzhul    both pr merged (with fix on 5808 which include a wrong file
05:46 nerzhul    hi Zeno`
05:46 paramat    but, it is avoidable
05:46 Raven262   I found that when nodes are unaliased in mapgen.lua i get void layers at those positions.
05:49 nerzhul    paramat, #5568 needs also your attention
05:49 ShadowBot  https://github.com/minetest/minetest/issues/5568 -- place_param2 not accounted for in client side placement prediction.
05:49 paramat    no idea how to do this yet, was hoping sofar might appear as he says it's trivial
05:50 nerzhul    lol sofar seems very busy :(
05:50 nerzhul    #5807
05:50 ShadowBot  https://github.com/minetest/minetest/issues/5807 -- minetest.register_on_placenode not working w/ trees
05:51 Raven262   paramat, it was y=47, i just found the place.
05:54 paramat    yeah
05:55 paramat    just seen LOTT doesn't use the biome API, it uses a version of my own code that adds biomes to a stony mgv7 using lua, so not an engine bug, a subgame bug :]
05:56 paramat    5807 is related to another issue, will find
05:56 paramat    game#656
05:56 ShadowBot  https://github.com/minetest/minetest_game/issues/656 -- You can place items like tree trunks, etc without it being noted in the log, or calling registered_on_placenodes functions
05:57 nerzhul    guys, in next release we should move privs to player instead of auth (using SQL backends for both), privs are not intended to be linked to an account but a player :)
05:57 paramat    it's due to trunks having 'minetest.rotate_node' i suspect
05:58 paramat    also related #1338
05:58 ShadowBot  https://github.com/minetest/minetest/issues/1338 -- after_place_node() not called when on_place() defined
05:59 Raven262   paramat, thanks for the info, i'll notify Amaz about this.
05:59 paramat    ok
05:59 paramat    if lott uses the biome API mapgen will be much faster
05:59 nerzhul    after_place_node is a pure lua callback, eerf
06:00 paramat    and is much easier to use
06:00 Raven262   This might also be the cause of some of that lag then?
06:00 paramat    yes that lua code will cause lua lag
06:01 paramat    just do what MTG does and define lott biomes and decorations
06:01 nerzhul    do you talk about after_place_node ?
06:02 nerzhul    the ShadowNinja comment on 1338 is totally exact
06:02 nerzhul    if we want to fix this, after_place_node should be called from engine directly
06:02 paramat    yes after_place_node
06:03 nerzhul    or the user should use after_place_node in its on_place to solve the issue, because it override the whole item_place_node function
06:05 nerzhul    i don't think we can fix it for this release
06:09 paramat    tree nodes have 'on_place = minetest.rotate_node'
06:10 nerzhul    rotate should include the after callback then
06:17 paramat    wil merge game#1742 in a moment
06:17 ShadowBot  https://github.com/minetest/minetest_game/issues/1742 -- Settings: Use new settings object by paramat
06:19 paramat    merging
06:19 nerzhul    nice, are there any blockers on MTG before release ?
06:22 paramat    merged. none. i have snow footsteps marked as a milestone, because i thought sounds would be harmless to add during freeze, but not essential
06:23 paramat    i'll let other mtg devs decide whether those could be added during freeze
06:33 nerzhul    merging #5806 in ~20 mins ty Zeno` for the review
06:33 ShadowBot  https://github.com/minetest/minetest/issues/5806 -- Revert 1469424 and fix wrong char position when doing mouse selection on intlGUIEditBox by nerzhul
06:57 Zeno`      updated credits
06:57 Zeno`      #5800
06:57 ShadowBot  https://github.com/minetest/minetest/issues/5800 -- Update credits by Zeno-
06:59 paramat    hehe
07:00 Zeno`      I removed the "listens to ABBA"
08:30 nerzhul    !tell paramat if you can help me to reproduce the bug fixed by #5798 could be nice to make it approved :)
08:30 ShadowBot  nerzhul: O.K.
08:36 nerzhul    VanessaE, can you try to revert abd68d3466b7f2155cf0f1c4172a254f10c1f02e and verify if network cause problems or not ?
09:00 glut32     hi all
09:00 glut32     I have a question
09:01 glut32     where is the log file in minetest?
09:01 Raven262   debug.txt?
09:01 Raven262   Depends on your OS
09:02 Raven262   in linux its in ~/.minetest
09:02 Raven262   in windows it should be your minetest's installation dir
09:02 Raven262   or the place where your minetest.exe is.
10:09 VanessaE   nerzhul: ok.
10:14 VanessaE   nerzhul:  reverted and running.
10:17 VanessaE   nerzhul:  reverted and running.
10:18 nerzhul    okay, tell us if it's better it's the only fix i found who can have some problems
10:20 VanessaE   I'll let you know
10:20 VanessaE   (you know I will ;) )
10:22 Zeno`      VanessaE, don't call nerzhul perverted
10:22 Zeno`      oh... reverted. nvm. carry on
10:22 VanessaE   heh
10:23 VanessaE   nothing wrong with being perverted anyway :)
10:26 VanessaE   nerzhul: no such luck
10:26 VanessaE   still getting timeouts
10:26 VanessaE   of 7 connect attempts, three made it in, the remaining four timed out
10:27 VanessaE   and it definitely ain't the server
10:27 VanessaE   because one of the 'good' ones, I can walk around just fine, everything responds normally
10:28 VanessaE   I'm almost certain it's the server losing track of which username gets which packets
10:28 VanessaE   if two or more usernames are on the same IP as in this case - I have five client instances open
10:29 VanessaE   they get all the way through the connection process usually, only to time-out after receiving a grey screen with black HUD elements
10:29 VanessaE   I see a brief "Shutting down" message, just for half a second, before the client reports the time-out
10:29 VanessaE   but that's not the server saying it, it's the client
10:31 nerzhul    server doesn't do that because connection threads doesn't know what is a user, they just know what is a session with ID
10:32 VanessaE   now one of the "good" instances just timed out for no reason, yet I can move around and see the world loading ahead of me
10:32 VanessaE   when that one timed out, one of the other instances that couldn't get in, got in
10:33 VanessaE   "yet I can move around" <-- as in, using one of the other instances that got in
10:34 VanessaE   it's as though the server's trying to limit me to 2-3 connections
10:34 VanessaE   well there, a fourth instance got in.
10:35 VanessaE   offhand I'd say this is an 80% failure rate :(
10:46 nerzhul    WTF
10:46 nerzhul    i never saw that shit
10:46 nerzhul    celeron55, ...
10:46 nerzhul    bool RecursiveDelete(const std::string &path)
10:46 nerzhul    pid_t child_pid = fork();
10:46 nerzhul    and
10:46 nerzhul    strcpy(argv_data[0], "/bin/rm");
10:46 nerzhul    strcpy(argv_data[1], "-rf");
10:46 nerzhul    strncpy(argv_data[2], path.c_str(), 10000);
10:46 nerzhul    WTF
10:46 VanessaE   ^ related?
10:46 nerzhul    absolutely not
10:46 VanessaE   ok.
10:47 nerzhul    i searched where MT forked, and found that by side effect lol
10:47 nerzhul    easier than coding its own recursion but... what :(
10:47 VanessaE   anyway I imagine you just never tried connecting several clients at once :)
10:49 celeron55  it's funny how different people find that code and everyone is equally freaked out until they realize it's prefectly safe and reliable and they don't want to copy an rm -rf implementation into minetest
10:50 nerzhul    lol
10:50 nerzhul    it's not very difficult to do a recursive removal... it take just a little bit more lines but ... wtf :(
10:50 celeron55  well do it then
10:51 celeron55  make sure you handle symbolic links and all that properly
10:51 nerzhul    too late feature freeze (haha good time for that)
10:51 celeron55  and make sure it's posix compliant so that it works on mac and android and whatever
10:51 nerzhul    C is portable for that
10:51 nerzhul    haha
10:52 celeron55  i'm placing my bets on nothing being changed this time either
10:52 nerzhul    :p
10:53 VanessaE   nerzhul:  [05-21 11:48] <Fixer> could be this? https://github.com/minetest/minetest/commit/ce9802266ef1def339ec2e119c59090d0fd07c90
11:32 Zeno`      VanessaE, I've removed the ABBA reference
11:34 Zeno`      #5800
11:34 ShadowBot  https://github.com/minetest/minetest/issues/5800 -- Update credits by Zeno-
11:34 Zeno`      all quite normal now
11:36 Zeno`      no more "listens to ABBA" comment. That was silly
11:37 VanessaE   aw
12:07 nerzhul    VanessaE, do you build with C++11 support ?
12:11 VanessaE   I don't think so?
12:12 VanessaE   how would I know?
12:13 nerzhul    first, do you use standard compiler or do you select it yourself ?
12:13 VanessaE   standard compiler
12:14 nerzhul    type "cc -v"
12:14 nerzhul    and give me the compiler & version
12:14 nerzhul    and "c++ -v"
12:14 VanessaE   gcc version 4.9.2 (Debian 4.9.2-10)
12:14 nerzhul    okay
12:14 nerzhul    it's a compatible C++11 compiler but it's not enabled by default
12:15 nerzhul    but to be sure, can you add this line into main.cpp just after migrate_map_database line for example "auto i = 100;"
12:15 nerzhul    and compile
12:15 nerzhul    if it compiles you are using C++11 else no
12:16 VanessaE   shortly
12:16 VanessaE   busy now
12:16 nerzhul    no problem i'm at work
12:16 nerzhul    hi est31
12:18 VanessaE   you mean right after the "static bool migrate_map_database ..."  ?
12:30 nerzhul    yes
12:30 VanessaE   ok
12:30 VanessaE   trying....
12:31 VanessaE   failed
12:32 VanessaE   http://pastebin.ubuntu.com/24643592/
12:32 nerzhul    then you build in C++03
12:33 nerzhul    that's what i thought
12:33 nerzhul    then the PR mentionned by fixer has no effect for you
12:36 VanessaE   what now? :)
12:45 VanessaE   any ideas, nerzhul ?
12:48 nerzhul    now we just need to find another commit because it's not this
12:48 VanessaE   right.  want me to take out the 'auto' line?
12:49 nerzhul    oh you can remove it, it was added to ensure your compiler doesn't build using C++11 API
12:49 VanessaE   just making sure, in case you had a secondary purpose for it.
12:50 nerzhul    nono
12:51 * VanessaE hopes for an "oh shit, no wonder it broke" moment :)
12:51 VanessaE   <nerzhul> wait, what idiot coded this?  I can't... this is bullshit
12:51 VanessaE   :)
12:52 nerzhul    ?
12:52 nerzhul    lol
12:52 VanessaE   kidding :)
12:52 VanessaE   often when there's a "no wonder this broke" moment, it's usually in the form of ^^^ that (though most often, c55 says it :) )
12:55 glut32     I have a question : how to use intlib?
12:56 nerzhul    gettext you mean ?
12:56 glut32     for localisation
12:56 nerzhul    gettext("string")
12:56 glut32     for modding translation in lua
12:56 nerzhul    oh
12:56 nerzhul    i don't know about this part
12:56 * red-001  shrugs
12:56 red-001    it's a mod not part of the engine
12:57 red-001    does it not come with documention?
12:58 glut32     po files are used : https://github.com/minetest-mods/intllib/blob/master/gettext.lua#L217
12:59 nerzhul    run updatepo.sh to generate updated po files
12:59 nerzhul    and  then translate
12:59 nerzhul    i think it scan the lua code too to find strings to translate, just test to be sure
13:08 glut32     I found an exemple how to write a po file : https://github.com/minetest-mods/intllib/blob/master/intltest/locale/es.po
15:55 est31      hi nerzhul
15:55 VanessaE   greetz, est31
15:56 est31      from how I can see it, minetest is having progress?
15:56 est31      minetest still looks alive in any case
15:56 est31      that's a good sign
15:57 VanessaE   progress depends on who you ask, but I think so.
15:57 VanessaE   very much alive.
15:57 rubenwardy yeah, it's been good
15:57 rubenwardy we have client-side scripting now (not sure when you left / if you're aware)
15:57 est31      yeah seen it
15:57 rubenwardy cool cool
16:05 est31      in any case, good luck
18:15 nerzhul    Krock, ignore my comment on the 100, i'm drunk :p
18:15 nerzhul    https://github.com/minetest/minetest/blob/master/.clang-format#L19
18:15 * Krock    slaps nerzhul
18:16 nerzhul    i wrote that when i wasn't drunk :p
22:45 red-001    #5811
22:45 ShadowBot  https://github.com/minetest/minetest/issues/5811 -- Close formspec on client shutdown. by red-001
23:18 Fixer_     oh, tin does not have a slab and a stair