Time  Nick           Message
00:51 hfranqui       Hi, the other days I asked how to merge PR locally, and I wasn't able to thank you all paramat, nore, Fixer and nerzhul who helped me
00:51 hfranqui       Thanks
04:25 Zeno`          #5781
04:25 ShadowBot      https://github.com/minetest/minetest/issues/5781 -- Fix mem leak in mesh cache by Zeno-
06:13 nerzhul        hello, merging #5772 in ~5 mins
06:13 ShadowBot      https://github.com/minetest/minetest/issues/5772 -- Various code cleanup & little performance improvement on HTTP download by nerzhul
06:15 nerzhul        nice Zeno`
06:15 nerzhul        i missed it
06:15 nerzhul        merging #5781 too
06:15 ShadowBot      https://github.com/minetest/minetest/issues/5781 -- Fix mem leak in mesh cache by Zeno-
08:12 nerzhul        just pushing a trivial fix for https://github.com/minetest/minetest/commit/a4a377ecad6f1732cc54e7ac329fdef9949f9bf7 (x = cur +1 instead of x = cur) it works as intended
08:16 Krock          another trivial fix: https://hastebin.com/azupabewag.patch
08:17 Krock          fixes https://github.com/minetest/minetest/commit/e25a38e#commitcomment-22215004
08:17 nerzhul        Krock, i was working on it :p
08:17 Krock          ninja'd :P
08:17 Krock          pushing in 10 mins
08:18 nerzhul        okay :p i prefer having if not minimap then
08:18 nerzhul        return
08:18 nerzhul        end
08:18 nerzhul        in the preview_minimap function
08:18 Krock          that's also a possibility
08:24 nerzhul        it permit to prevent error if calling multiple times this function :)
08:26 Krock          k.. whatever, changed it
08:26 Krock          print,  return
08:28 nerzhul        nice
08:28 nerzhul        can you review tiny #5775 it's a wrong test done in our legacy code crashing server on wide chars
08:28 ShadowBot      https://github.com/minetest/minetest/issues/5775 -- [needs testing] Potential fix for chat/csm related crash by red-001
08:29 Krock          k, so 5746 and 5775 testing together. let's see if that works
08:32 nerzhul        today it's time to merge and test the last remaining features. feature freeze will start just after our meeting (there is a meeting, right ?)
08:33 Krock          I hope there's one planned. if not, we'll need luck to get the devs online.
08:36 Krock          I'm afraid paramat is right and the sn*ak pull won't make it into this release
08:36 nerzhul        yeah, 3 or 4 dev is sufficient to make PR merged before feature freeze
08:36 nerzhul        what do you mean ?
08:37 Krock          talking about PR #5533, where it seems as nobody wants to give a real feedback
08:37 ShadowBot      https://github.com/minetest/minetest/issues/5533 -- Sneak: Strip down version by SmallJoker
08:38 Krock          nobody with the exception of paramat himself who keeps testing it :)
08:40 Krock          red-001, how can I reproduce the bug for #5775?
08:40 ShadowBot      https://github.com/minetest/minetest/issues/5775 -- [needs testing] Potential fix for chat/csm related crash by red-001
08:40 nerzhul        it's very very difficult, but the fix is lgtm as we don't compare the good char types
08:41 Krock          ah, one of these crashes that happen once in a few days of playing. the fix looks good
08:42 nerzhul        yeah isspace & iswspace are standard functions i'm pretty confident it helps
08:43 nerzhul        could be nice to have a unittest on this function but it's not easy
08:43 nerzhul        (note: i also think we should change our unittest framework to use standard unittest framework cppunit which is great, but we will see this later
08:44 nerzhul        hmmm lol
08:44 nerzhul        if (word_end < m_line.size() && isspace(word_end))
08:44 nerzhul        i think we have a problem on this function
08:44 nerzhul        isspace(int)
08:44 nerzhul        word_end is a position...
08:44 nerzhul        not the char itself
08:45 nerzhul        there is same problem in many places
08:46 nerzhul        i'm looking for cpp doc
08:48 nerzhul        okay it's really a char type mismatch
08:48 nerzhul        merging this fix, i need it to provide the next patch
08:50 Zeno`          hmm
08:51 Zeno`          there is really that problem in places?
08:51 nerzhul        what do you mean Zeno` ?
08:51 Zeno`          <nerzhul> if (word_end < m_line.size() && isspace(word_end))
08:52 Zeno`          checking that the end "index" is a space or not?!
08:52 nerzhul        / Last nick completion start (index into m_line)
08:52 nerzhul        it's the variable initing word_end
08:52 Zeno`          link to code?
08:52 nerzhul        isspace(index) doesn't mean anything, it's an index
08:52 Zeno`          correct
08:53 nerzhul        chat.cpp L541
08:53 Krock          eeks
08:53 nerzhul        you will find this problem, u32 word_end = prefix_end; and u32 prefix_end = m_nick_completion_end; & previous comment :p
08:53 Krock          that's horrible
08:53 Zeno`          yikes
08:53 Zeno`          how did that happen?!
08:54 nerzhul        it's kahrl :p
08:54 Zeno`          nah, I'm sure kahrl could not have made that elementary mistake
08:55 nerzhul        sorry Zeno` => https://lut.im/HsENk2sfZL/t9zQGHPtxp5woajh.png
08:56 Krock          https://github.com/minetest/minetest/commit/967f2546diff-845c1df7811b52248eace7e5b209e757R534
08:56 Krock          s/diff/#diff/
08:57 nerzhul        very very old file :p
08:57 nerzhul        minetest was a baby
08:57 Krock          yeah
08:57 nerzhul        i don't know if a static analysis can find this, i hope yes
08:59 Zeno`          I don't it would because technically there is nothing wrong with that call to isspace (apart from it being nonsense)
09:00 nerzhul        isspace looks for 1 byte, is wspace look for 2 bytes, it's different when you use unicode chars
09:07 nerzhul        Zeno`, Krock #5783
09:08 ShadowBot      https://github.com/minetest/minetest/issues/5783 -- chat.cpp fix wchar_t isspace -> iswspace & wrong isspace on an index by nerzhul
09:08 nerzhul        tested on autocompletion on MFF it works great
09:11 Krock          any other check to be fixed?
09:14 red-001        unicode in setting  files crashes minetest
09:16 nerzhul        no i searched over all files
09:27 Zeno`          #4810
09:27 ShadowBot      https://github.com/minetest/minetest/issues/4810 -- Unittests crash on Release build
09:27 Zeno`          sofar's suggested fix does absolutely nothing, so there is no point merging it
09:28 nerzhul        yeah
09:28 Zeno`          see my new comment (where the exception really is happening)
09:29 Zeno`          it could be the compiler using more than 32 bits (for some kind of optimisation reason)
09:32 Zeno`          I really don't want to read the academic papers regarding that algorithm used so maybe the fix can be found another way
09:32 nerzhul        PCg random ?
09:32 nerzhul        when switching to C++11 we can remove this part to use std::mt15539
09:32 nerzhul        :p
09:34 Zeno`          well hmmmm seemed to think pcg was better than mt
09:34 Zeno`          mt is easily implemented even now (I did it years ago) so no need to even wait for c++11
09:37 Zeno`          personally I dunno why we don't just use MT
09:37 Zeno`          I mean it's a game
09:37 Zeno`          surely the distribution it generates is good enough for a game heh
09:38 Zeno`          plus it's understood a lot better
09:41 nerzhul        lol irony powa
09:43 red-001        could someone review #5757?
09:43 ShadowBot      https://github.com/minetest/minetest/issues/5757 -- Improve password change menu by red-001
09:44 red-001        it's mostly a bug fix
09:45 Krock          I'm not really a fan of having passwords in variables
09:45 Krock          hello paramat
09:45 nerzhul        not me, but this object is detroyed after formspec close
09:45 Krock          s/not/neither/  ?
09:46 red-001        Krock, no way around it
09:47 red-001        resizing in Irrlich or at least the way minetest uses it requires recreating the whole interface from scratch
09:47 Krock          grabbing patch
09:49 nerzhul        red-001, can you explain us #5779
09:49 ShadowBot      https://github.com/minetest/minetest/issues/5779 -- Fix CSM crash by red-001
09:49 Krock          ^
09:50 red-001        the client has no objectref
09:50 nerzhul        yeah, it's just a typo .? because server side we said it's ref whereas it's an id, exact ?
09:50 red-001        so trying to return one crashes minetest
09:51 paramat        i have a suggestion: since freeze is planned for tomorrow (21st) and since the weekend is when more devs are present and active, it makes good sense to freeze at the end of tomorrow to get more stuff done first. rubenwardy sofar Zeno` nore and all
09:52 red-001        nerzhul, object refs are stored in a lua table on the server-side and the client doesn't have access to it
09:52 nerzhul        we can delay it to tomorrow, but we really should use this evening meeting to merge the last features
09:53 nerzhul        red-001, okay, it's just the name ref on server side which is not really consistent with the stored id, i find that strange (not especially your code)
09:53 nerzhul        i approved #5757
09:53 ShadowBot      https://github.com/minetest/minetest/issues/5757 -- Improve password change menu by red-001
09:56 Zeno`          oh, don't freeze today
09:56 Zeno`          there is still much to be done I think
09:56 nerzhul        Zeno`, it was planed since months ago and we can keep features for a next release :p
09:56 nerzhul        but okay for delayed to tomorrow
09:57 Zeno`          I'm sure a day is not going to make a huge difference
09:57 Zeno`          (in fact it probably won't make any difference at all LOL)
09:57 nerzhul        sufficient, released is planed in june, in 3 or 4 weeks (look at forum post)
09:58 Krock          if we move the feature freeze phase to next week, there's a higher risk of having bugs in the stable version
09:58 Zeno`          well at least the major bugs are fixed I guess
09:58 Krock          but 4 weeks? that's more than enough
09:58 nerzhul        feature freeze is for bugs, yes
09:58 Zeno`          (or getting close to being fixed)
10:09 nerzhul        merging #5757 #5746 & #5777 in 10 mins
10:09 ShadowBot      https://github.com/minetest/minetest/issues/5757 -- Improve password change menu by red-001
10:09 ShadowBot      https://github.com/minetest/minetest/issues/5746 -- Cleanup in content_mapblock by numberZero
10:09 ShadowBot      https://github.com/minetest/minetest/issues/5777 -- Fix shift key producing space in console by davisonio
10:10 nerzhul        and maybe #5783 is Zeno` or Krock looks at :D
10:10 ShadowBot      https://github.com/minetest/minetest/issues/5783 -- chat.cpp fix wchar_t isspace -> iswspace & wrong isspace on an index by nerzhul
10:13 nerzhul        Zeno`, i was wrong, 2 weeks of feature freeze
10:14 nerzhul        and i delayed the FF from 0:00 to 23:59 paramat
10:14 paramat        nice
10:30 nerzhul        the 3 pr are merged
10:34 nerzhul        okay second patchset to merge in 10 mins: #4994 & #5783 (ty for review Zeno`
10:34 ShadowBot      https://github.com/minetest/minetest/issues/4994 -- Clear Inventory Chatcommand (/clearinv) by octacian
10:34 ShadowBot      https://github.com/minetest/minetest/issues/5783 -- chat.cpp fix wchar_t isspace -> iswspace & wrong isspace on an index by nerzhul
10:34 nerzhul        (after that less than 150 PR)
10:35 paramat        wow
10:40 paramat        #5766 is ready for merge, retested by 2 people
10:40 ShadowBot      https://github.com/minetest/minetest/issues/5766 -- Particle spawner: Do not spawn particles distant from player by paramat
10:56 nerzhul        merging done
11:55 Krock          Edge case of feature/bugfix: #5784
11:55 ShadowBot      https://github.com/minetest/minetest/issues/5784 -- [CSM] Correct the log destination of print() by SmallJoker
12:24 Krock          merging game#1739 in 5 mins
12:24 ShadowBot      https://github.com/minetest/minetest_game/issues/1739 -- shorter and better abm's by theFox6
12:25 paramat        ok
13:39 nerzhul        we really should do a pass on issues and close the unneeded issues
13:39 nerzhul        840 issues is impossible to manage, i think there are duplicates issues
13:41 nerzhul        Krock, is #664 fixed ?
13:41 ShadowBot      https://github.com/minetest/minetest/issues/664 -- Jumping on a node higher than you will make you slowly fall until you land
13:43 Krock          too bad the video is gone
13:43 nerzhul        Calinou, ^
13:43 red-001        #2989
13:43 ShadowBot      https://github.com/minetest/minetest/issues/2989 -- Can't serialize data of type userdata
13:43 red-001        ^ doesn't seem like an issue
13:44 Krock          ^ can't fix
13:44 nerzhul        we cant fix 2989 it's just bad implementation
13:44 nerzhul        #1106 is fixed no ?
13:45 ShadowBot      https://github.com/minetest/minetest/issues/1106 -- Codepages support (utf-8) for all platforms
13:45 red-001        it doesn't even sound like something that can be fixed
13:45 nerzhul        paramat, #1404 is fixed no ?
13:45 ShadowBot      https://github.com/minetest/minetest/issues/1404 -- water opacity bug with irrlicht 1.8.x
13:46 paramat        no idea
13:46 nerzhul        i don't encounter this problem since a long time
13:46 nerzhul        Krock, #1460 ?
13:46 ShadowBot      https://github.com/minetest/minetest/issues/1460 -- Sound repeats on ladders
13:47 Krock          still present
13:47 paramat        but minor, happens in several situations
13:47 nerzhul        okay
13:48 nerzhul        #1508 and #1959 are obscure i think we should close them
13:48 ShadowBot      https://github.com/minetest/minetest/issues/1508 -- ERROR[main]: WARNING: updateListener: invalid value
13:48 ShadowBot      https://github.com/minetest/minetest/issues/1959 -- Public serverlist causes Minetest to freeze on client tab
13:49 paramat        ah 1404 may be fixed now that i have removed the duplicate water surface shader, only water top tiles were sent to that
13:49 nerzhul        yeah i think it's this thing
13:49 nerzhul        Krock, #2231 fixed ?
13:49 ShadowBot      https://github.com/minetest/minetest/issues/2231 -- Unit test fails
13:50 Krock          can refresh with a new error
13:52 nerzhul        i think #2283 can be closed too, we massively improve shader performance, i always play with shaders enabled and i don't notice any performance drop due to them
13:52 ShadowBot      https://github.com/minetest/minetest/issues/2283 -- Bad render performance based on shader data
13:53 Krock          well, the test fail ratio got better - at least that :D
13:53 Krock          1 / 13  vs  6 / 87
13:53 nerzhul        paramat, #2399 does the flowing commits helps ?
13:53 ShadowBot      https://github.com/minetest/minetest/issues/2399 -- Lava doesnt flow correct
13:53 nerzhul        lol
13:54 nerzhul        Krock, #2659
13:54 ShadowBot      https://github.com/minetest/minetest/issues/2659 -- Deleting blocks - unable deactivate deleted objects
13:54 paramat        664 still happens, but only in rare cases, keep open i think but low priority
13:55 nerzhul        #3389 should be easily fixed, why we can't do it now ?
13:55 ShadowBot      https://github.com/minetest/minetest/issues/3389 -- Unknown items don't dropping on minetest 0.4.13-dev (18.11.2015)
13:56 Krock          is that even a bug? unknown stuff shouldn't lay around
13:58 nerzhul        i don't know but you should have the possibility to remove them from your inventory no ?
13:58 paramat        i doubt 2399 is fixed, i think it's inevitable behaviour caused by 2 liquids fighting to enter a node
14:00 paramat        Krock see my comment in 1508 the actual issue here may be teleport to 'inf' co-ordinate
14:03 Krock          or a mod that somehow managed to get in a calculation a inf value
14:03 paramat        i agree to closing 2283
14:03 red-001        #3389 is a really annoying bug
14:03 ShadowBot      https://github.com/minetest/minetest/issues/3389 -- Unknown items don't dropping on minetest 0.4.13-dev (18.11.2015)
14:03 paramat        closed 2283
14:03 Krock          checking against being valid positions would help there
14:04 nerzhul        pushing a typo fix for #4293 (in README.md, case sensitive PostgreSQL_INCLUDE_DIR variable
14:04 ShadowBot      https://github.com/minetest/minetest/issues/4293 -- POSTGRE_SQL_INCLUDE_DIR option doesn't work.
14:10 paramat        i agree with closing 1508 and commented
14:24 nerzhul        i don't know what to do with this amount of issues :p
14:24 nerzhul        many seems lgtm
14:24 nerzhul        we should do many fixed, especially on recent reports in the feature freeze
14:35 nerzhul        merging #5779 & #5784 in ~10 mins
14:36 ShadowBot      https://github.com/minetest/minetest/issues/5779 -- Fix CSM crash by red-001
14:36 ShadowBot      https://github.com/minetest/minetest/issues/5784 -- [CSM] Correct the log destination of print() by SmallJoker
14:38 paramat        #5766 ?
14:38 ShadowBot      https://github.com/minetest/minetest/issues/5766 -- Particle spawner: Do not spawn particles distant from player by paramat
14:39 Krock          seems to be tested, thus ok.
14:40 nerzhul        the particle object is just shit :p
14:40 nerzhul        look at this constructor..
14:40 nerzhul        braces are all wrong paramat fix it please
14:40 Krock          that's copypasta
14:40 nerzhul        yeah but our rules said fix :)
14:41 nerzhul        and it's good :p
14:41 Krock          uh.. where?
14:43 paramat        yes there are code style issues nearby, but i would like to fix those in a separate PR
14:43 paramat        the whole file has bad code style, i will fix this separately
14:44 Krock          the freeminer devs will cry
14:44 nerzhul        i can link a PR where some said, forks are not our problem, and i agree :p
14:44 paramat        the diff makes it appear i have added bad code style, but those added lines are mostly pre-existing lines
14:45 paramat        the diff is quite confusing actually
14:45 nerzhul        merging the 3 PR , but at a point we really should fix all those code style use clang-format define which rules to use with clang-format and conform to it and give end user the guidelines
14:45 nerzhul        merging the 3 PR then
14:46 paramat        i have only added a few lines, but indented a lot of existing code
14:47 paramat        wow thanks :]
14:47 nerzhul        but on next PR ensure it's consisten
14:47 nerzhul        t*
14:49 paramat        who approved 5766? just so that i can add the label
14:50 nerzhul        #5766
14:50 ShadowBot      https://github.com/minetest/minetest/issues/5766 -- Particle spawner: Do not spawn particles distant from player by paramat
14:50 nerzhul        me
14:50 paramat        ok
14:50 paramat        thanks
14:50 nerzhul        no better soluce without breaking things
14:50 nerzhul        the next release will need good C++ competences to review PR
14:50 nerzhul        i started a project about the C++11 conversion
14:51 nerzhul        https://github.com/minetest/minetest/projects
14:51 red-001        clangformat doesn't always generate the cleanest looking code
14:51 paramat        have we agreed to move to C++11?
14:51 nerzhul        yes
14:52 paramat        ok i missed that, thought it was just your suggestion at the moment
14:52 nerzhul        no, i suggest it at... first or second meeting and it was accepted, C++11 is supported since Windows Vista, and GCC 4.9/Clang 3.5 (we are now with GCC 7.1 and Clang 3.9/4.0
14:53 nerzhul        Debian 8 i just good, the only problematic thing is android i should test the NDK build with C++11 when flags will be set on project
14:53 nerzhul        i will essential work on this maintenance after release
14:54 nerzhul        on your C++ code parts, the randomgen will be converted to C++11 random generators which are better than our algorithm (STL quality :p)
14:54 Calinou        Krock: nerzhul: I need to check if this still occurs (Jumping on a node higher than you will make you slowly fall until you land)
14:55 nerzhul        but we have 2 weeks for finish this C++03 build
14:55 Krock          would be glad if you could refresh this issue :)
14:56 nerzhul        i think i will finish the chat protocol rewrite, and as it's a breakage version i will really make it good heh (compat is a pain, especially on lua api for this fix)
14:56 nerzhul        also i will work on long time request mod channels (sofar <-)
14:59 red-001        wasn't est31 working on utf-8 for chat or something?
15:00 Calinou        Krock, nerzhul: tested on latest Minetest Git commit (60baf81), still occurs
15:00 nerzhul        i can't remember, but i will ensure it uses wchat_t
15:00 Calinou        it's easy to test (works in both singleplayer and multiplayer, and any subgame)
15:00 nerzhul        wchar_t*
15:00 nerzhul        Calinou, ty
15:00 Calinou        jump on a node that's 1 node higher than you
15:01 Calinou        you will slowly sink into the ground (but it's a bit faster than before now), still noticeable
15:01 Calinou        well, not "into" but "onto"
15:01 Calinou        you'll never be stuck in the node
15:01 Calinou        but it still feels strange, no other game engine I know does this
15:01 Calinou        (including older versions of Minetest, and that other voxel game)
15:02 Calinou        nerzhul: should I comment on the issue to indicate this?
15:02 red-001        I wonder is this linking to the bug that lets you glitch into a node
15:03 nerzhul        Calinou, can be nice to have an update yes
15:03 Calinou        red-001: I don't think so
15:03 Calinou        I remember being able to fix this bug at the cost of another issue
15:03 Calinou        (related to step height or something?)
15:04 Krock          looks like it doesn't set the Y position to the surface and only resets the speed when almost touching the ground
15:04 Calinou        this doesn't seem to happen when sneak-jumping onto a node, too
15:06 Calinou        this occurs regardless of your horizontal speed, too (even if you're using fast mode, it can occur)
15:53 paramat        #5785
15:53 ShadowBot      https://github.com/minetest/minetest/issues/5785 -- Fix instant digging by HybridDog
15:54 paramat        new attempt to fix #5728
15:54 ShadowBot      https://github.com/minetest/minetest/issues/5728 -- Block instadig after tool switch
15:59 VanessaE       so am I to assume with the closing of #4459 that minetest will never get a dynamic view range again?
15:59 ShadowBot      https://github.com/minetest/minetest/issues/4459 -- Dynamic view range depending on frame rate
16:03 nerzhul        seems no atm
16:03 VanessaE       that sucks
16:03 Krock          "never" is quite a strong word. I'd say this won't be much a thing for the next few months until there are more players who want this
16:05 VanessaE       Krock: every time someone calls for auto view range, it gets closed or shouted down
16:05 VanessaE       the old algorithm WORKED
16:05 VanessaE       even if it was buggy
16:05 VanessaE       but nooooooo let's just remove it instead of improving it
16:05 Krock          buggy behaviour isn't really a desired feature
16:06 VanessaE       Krock: simple logic:  leave the buggy feature in, as long as it doesn't break.  those that don't like it can turn it off.  those who can deal with the bugs, turn it on.  but if you remove it, then NO one can turn it on.
16:11 red-001        #5554
16:11 ShadowBot      https://github.com/minetest/minetest/issues/5554 -- [CSM] Allow enabling and disabling mods. by red-001
16:13 paramat        it didn't work, and so was removed. we tried tuning it but it still had severe problems which many complained about, we have few complaints now about manual control
16:16 VanessaE       it DID work
16:16 VanessaE       it was just buggy
16:17 VanessaE       again, those who didn't like it could just disable it anyway
16:17 VanessaE       but now it's gone entirely, so even those of us who could tolerate the bugs have NO OPTION now
16:17 VanessaE       come on manm
16:17 VanessaE       -m
16:17 VanessaE       and fixed range DOES NOT WORK in a production environment
16:18 paramat        it's not fixed
16:20 VanessaE       um, yes it is.
16:20 paramat        maybe someone will come up with a much better implementation
16:20 VanessaE       it's "fixed" if the engine doesn't automatically adjust it
16:20 VanessaE       having to sit there on the +/- keys as you play kills immersion
16:21 paramat        manual control means not fixed
16:21 VanessaE       manual control
16:21 * VanessaE     grumbles both at the enter key and at paramat
16:22 VanessaE       manual control is still "fixed", the way we would use the term in American English
16:22 nerzhul        just wait
16:22 VanessaE       like a "fixed width font" can still be scaled up or down with manual controls.
16:23 VanessaE       nerzhul: bad advise....
16:23 VanessaE       advice*
16:23 paramat        in the UK we drive fixed gear cars with only one gear :]
16:23 VanessaE       not the same thing :P
16:26 Fixer          i wonder why in creative pickaxes are so slow?
16:27 paramat        erm i seem to remember some reason, just use your hand
17:12 kilbith_       > Dynamic view range
17:12 kilbith_       no, no, no and NO.
17:13 VanessaE       then.  turn.  it.  off.
17:13 VanessaE       (if it existed that is)
17:14 VanessaE       "oh, this feature doesn't work for me, let's just remove it from the engine entirely."
17:14 kilbith_       s/for me//
17:14 kilbith_       fuck this shit really
17:18 VanessaE       again, it worked for me
17:18 VanessaE       buggy or not, it DID work
17:18 kilbith_       re-add it in your fork
17:18 VanessaE       I ain't gonna fork for something stupid like that
17:21 VanessaE       it needs to be made a hard, fast, unbreakable rule in this project:  if a feature exists and works for some people, and doesn't break anything (read: crash, memory corruption, or the like), then it shall not, under any circumstances be removed from the engine/game unless something is immediately ready to replace it.
17:24 kilbith        there was basically only you and your mate cheapie that wanted to keep this shit
17:24 paramat        'for some people'.. . and inflexible rules are bad
17:26 VanessaE       then come up with a set of reasonable circumstances where it's okay to remove a feature.
17:26 paramat        that's also an inflexible rule
17:30 VanessaE       there have to be rules.
17:30 VanessaE       flexibility is fine but there needs to be a line we do not cross.
17:31 Fixer          https://github.com/minetest/minetest/pull/5777#issuecomment-302883704
17:31 Fixer          new bug?
17:31 ShadowNinja    nerzhul, rubenwardy, sfan5, sofar, Krock, nore, paramat: Meeting in 30 minutes.
17:31 sfan5          welp, i'll not be here
17:33 nerzhul        ShadowNinja, nice, will be there
17:33 VanessaE       I'll be here, if it matters.
17:33 paramat        flexible lines are best
17:34 paramat        today has been one big meeting really, no need to wait 30 mins
17:34 nerzhul        paramat, i go to lunch
17:34 nerzhul        it's lunch time for me :p
17:34 kilbith        *to dinner
17:36 Fixer          confirm unicode input bug
17:38 Fixer          some nonlatin symbols work, some not - broken since today, will check exact commit
17:39 Fixer          possibly broken by this https://github.com/minetest/minetest/pull/5777
17:39 kilbith        why would need to type unicode symbols anyway?
17:40 Fixer          i mean nonlatin symbols, for example cyrillic/etc
17:40 Fixer          people use it
17:41 VanessaE       kilbith: because some useful chars are only unicode.  X11_compose-o-o --> ° .... X11_compose-t-m --> ™  ....  X11_compose-o-r --> ®
17:42 VanessaE       and so on
17:42 VanessaE       (degrees, "TM", and (R), respectively)
17:43 red-001        kilbith, people that don't use english?
17:43 VanessaE       ^^^ those are routinely used by English speakers also
17:43 kilbith        or this one: âš¡âš¡
17:43 kilbith        very useful
17:44 red-001        I have no idea what you are arguing for
17:44 ShadowNinja    nerzhul: #5782: Isn't CSM disabled by default since it's still experimental?
17:44 ShadowBot      https://github.com/minetest/minetest/issues/5782 -- [CSM] Disable preview mod before release
17:53 nerzhul        Fixer, seems possible, testing in a few minutes
18:01 Krock          yes, CSM is off by default
18:02 rubenwardy     I feel like that release really needs abuse protection for minetest.get_node on the client side
18:02 rubenwardy     it's a blocker to me
18:02 rubenwardy     well
18:03 rubenwardy     meh, it makes it easier to ore detect, but doesn't make more cheating possible
18:03 nerzhul        CSM is off, but if user enable it prview mod will just disrupt his gameplay
18:04 ShadowNinja    Alright, the dev meeting starts now.
18:04 nerzhul        nice
18:04 nerzhul        it's the last meeting before feature freeze
18:04 ShadowNinja    Krock: Anything on inventory manipulation callbacks?
18:04 Krock          as soon we have a digging function in CSM, it's no longer required to build a cheater version of Minetest and simply run the oredetect mod :3
18:05 nerzhul        we will never add this Krock
18:05 ShadowNinja    sofar: You around?  Anything on list_predict?
18:05 nerzhul        ShadowNinja, we really should focus on new features, old business is not important on this meeting
18:05 ShadowNinja    web#78: Lets choose someone to handle this.
18:05 ShadowBot      https://github.com/minetest/minetest.github.io/issues/78 -- Add better screenshots, and more screenshots
18:06 Krock          ShadowNinja, haven't looked into it anymore. I'd be glad if there's someone around who could overtake this one.
18:06 rubenwardy     I vote Wuzzy :D
18:06 ShadowNinja    nerzhul: Patience, we'll get to all the blockers too :-)
18:06 Calinou        hmm
18:06 Calinou        beware, really
18:06 Calinou        screenshots should show a vanilla or vanilla-ish game, buildings are fine but please no "I have 500 nodes in my subgame" crap
18:07 Calinou        they probably should not have HUD too
18:07 Calinou        except for one maybe, but even then I'm not sure, our HUD is not something to be proud of today
18:07 rubenwardy     agreed. Any screenshots should have consistent contents
18:07 ShadowNinja    Calinou: I think it's fine to have a few that show what's possible.  Minetest is more than minetest_game.
18:07 Calinou        having occasional mods is OK, as I said
18:07 rubenwardy     I suggest different subgames, such as Pixture and Rpgtest
18:07 Calinou        that might just confuse people though
18:07 VanessaE       make some screenshots from one of my servers, there's lots of nice stuff to see there.
18:07 rubenwardy     they tend to look consistent, and show different game play
18:08 Calinou        the former has entirely different textures
18:08 ShadowNinja    Calinou: Also, 500 -> more like 10000 in some games :-P
18:08 rubenwardy     maybe point the different subgame stuff on the customise page though
18:08 rubenwardy     *put
18:08 Calinou        I don't know of any game whose official screenshots feature different base assets
18:09 rubenwardy     i think it's fine for the customise section
18:09 ShadowNinja    Calinou: Well, would you want to choose some screenshots and add them?  Something a bit more interesting than the cave that we've got now.
18:09 rubenwardy     plus, we're supposed to be an engine primarily
18:10 paramat        last time we discussed this it was strongly suggested to show off mods and other subgames, and i agree
18:10 nerzhul        agree variety of screens are important
18:10 rubenwardy     maybe we should have Godot style images on the homepage? Ie: showing lots of different games that are possible
18:10 Krock          a few multiplayer screenshots wouldn't be too bad either
18:11 nerzhul        Fixer, for the problem i see same problem as we fixed this morning...
18:11 nerzhul        isprint vs iswprint !!
18:11 nerzhul        i push directly the fix to master, the char is a wchar_t
18:11 Calinou        rubenwardy: we're both an engine and game, really
18:11 nerzhul        (just as code consistency), tell me if it's okay for you, i tryed é€@ĸ and it works for me
18:12 Calinou        don't fall into "we're an engine!!1!1" syndrome that has been plaguing projects like ioquake3 :(
18:12 paramat        but maybe sections for screenshots: vanilla MTG, mods, subgames
18:12 * VanessaE     hands ShadowNinja a gavel
18:12 Calinou        multiplayer screenshots make sense
18:12 ShadowNinja    Calinou: Can you pick a good mix of stock and moded screenshots for the site and install them?
18:12 Calinou        ShadowNinja: sure, but I'll probably retake the screenshots myself
18:12 Calinou        to make sure they all use the same settings
18:13 Calinou        anti-aliasing/anisotropic filtering are very important to turn on, and the view distance should preferably be the same on all
18:13 paramat        nah
18:13 Krock          would be nice to have but variety comes from different players
18:13 ShadowNinja    Calinou: Alright, make sure you show off what minetest can do.  Include things like large buildings, heavy games (dreambuilder) and action (TNT going off?).
18:13 Calinou        but design by committee sucks :)
18:14 Calinou        (c55 himself said that a lot back in the day)
18:14 Krock          indeed, it's less consistent
18:14 Calinou        ShadowNinja: yeah I'm fine with that; large mods are not a problem as long as it looks good
18:14 Calinou        a lot of mods have terrible textures, let's face it
18:14 ShadowNinja    Calinou: Exactly, that's why I want to assign one person :-)
18:14 Calinou        we could even have an official trailer, but that's for later
18:14 paramat        we don't want everything looking the same, and you then restrict yourself to what you can currently access, there is a huge variety of pre-existing screenshots
18:14 Calinou        Minecraft had awesome trailers back in the day
18:14 nerzhul        Fixer, https://github.com/minetest/minetest/commit/a2bb776ea81715a7b9eae4b2ea8aca032d42fb5e
18:15 Krock          ShadowNinja, dreambuilder is no longer a heavy subgame. it's now a very heavy modpack :P
18:15 ShadowNinja    Next: #5767
18:15 ShadowBot      https://github.com/minetest/minetest/issues/5767 -- Don't add damage flash while punch texture modifier is active by stujones11
18:15 Calinou        this is the post-1.0 one from Minecraft, https://www.youtube.com/watch?v=MmB9b5njVbA
18:15 Calinou        there was a Beta 1.0-1.8 one but I can't find it, it's made by the same person
18:15 nerzhul        i didn't get time to test it but the algorithm seems fine
18:15 ShadowNinja    Blocker, needs some review and merge.
18:16 Krock          didn't test but the code looks good
18:16 nerzhul        should be merged before release, we have two weeks for testing it
18:16 Calinou        https://www.youtube.com/watch?v=m_yqOoUMHPg
18:16 Calinou        that's the old one, found it!
18:16 Fixer          nerzhul: i'm checking that shift commit first, since someone mentioned it
18:16 rubenwardy     Mods suck
18:16 Calinou        obviously we're not able to reach that production quality
18:17 Calinou        but we should eventually try something
18:17 rubenwardy     the real power of Minetest is the subgames - being able to make your own consistent game
18:17 Calinou        we have cinematic camera, maybe we need a few more camera tools
18:17 Calinou        not all mods suck, plenty of them make sense
18:17 Calinou        the more a mod follows the UNIX philosophy, the better it is, usually
18:17 rubenwardy     do only one thing?
18:17 Fixer          beta 1.7.3 like gameplay is what you need :trollface:
18:17 Calinou        yeah, mostly
18:17 Calinou        "Write programs that do one thing and do it well."
18:18 rubenwardy     yeah agreed
18:18 * rubenwardy   looks at default
18:18 nerzhul        ShadowNinja, i suggest to delay 5767 to next meeting if not merged, letting us time to test it
18:18 ShadowNinja    For #5782, CSM is disabled so I don't think this is really a blocker.
18:18 ShadowBot      https://github.com/minetest/minetest/issues/5782 -- [CSM] Disable preview mod before release
18:18 Calinou        anyway I'll try putting some screenshots up soon
18:18 ShadowNinja    nerzhul: Yep, I'll wait for review on that one.
18:18 Calinou        I guess I'll hop on VanessaE's servers, try some mods/subgames locally
18:18 Calinou        may the block loading be with me!
18:19 Calinou        (I have to walk around quite a bit to make sure all blocks in view range are generated/loaded…)
18:19 ShadowNinja    Calinou: Yeah, uh, don't include the FPS counter :-P
18:19 nerzhul        5782 is a blocker as if a user enable CSM (accidentaly or not) preview mod will just do many unneeded things on gameplay
18:19 Calinou        I have a GTX 1080, I can get > 60 FPS literally anywhere
18:20 Calinou        all screenshots should be 1920×1080 I guess
18:20 Calinou        no need for more, and we can make smaller thumbnails
18:20 nerzhul        we should have this to permit CSM adoption and let modders start the CSM without problems (also it's basicly a refactor of the mod loading interface to make it more generic)
18:20 paramat        and a screenshot from each mapgen to show the variety
18:21 ShadowNinja    nerzhul: Well, if the user enables an experimental feature they can expect some things to change.
18:21 nerzhul        yeah but preview mod is not just a change, it can make the gameplay... unusable :p
18:21 nerzhul        preview contain all CSM calls , or nearly all
18:22 nerzhul        ShadowNinja, for disabling it, it's not the issue itself to merge
18:22 ShadowNinja    nerzhul: Well, still experimental so IMO it doesn't matter.
18:22 nerzhul        it's #5554
18:22 ShadowBot      https://github.com/minetest/minetest/issues/5554 -- [CSM] Allow enabling and disabling mods. by red-001
18:22 nerzhul        this PR merge solve the issue :)
18:24 nerzhul        without that you cannot disable any CSM mod (except if you remove it)
18:24 nerzhul        but anyway i'm okay for removing blocker if 5554 is merged
18:25 ShadowNinja    nerzhul: Alright, well I think we can merge 5554.  I looked over it and it looks pretty reasonable.  Any other comments on merging?
18:25 nerzhul        just merge :)
18:25 nerzhul        just factorize mod config code permitting to expose it to CSM engine :)
18:26 Fixer          nerzhul:  Fix shift key producing space in console (#5777) introduced that bug (https://github.com/minetest/minetest/commit/605599b6f150b89ba6539c4d088231b326adcb48)
18:26 ShadowBot      https://github.com/minetest/minetest/issues/5777 -- Fix shift key producing space in console by davisonio
18:26 nerzhul        Krock, rubenwardy ?
18:26 rubenwardy     #5554 ?
18:26 Krock          5554, +1 for the concept
18:26 ShadowBot      https://github.com/minetest/minetest/issues/5554 -- [CSM] Allow enabling and disabling mods. by red-001
18:27 nerzhul        y
18:27 paramat        uh but there is no description, how are we meant to judge this?
18:27 rubenwardy     I think that it's ultimately pointless, as the point of CSM should be to add client-side prediction, and make GUIs better
18:27 rubenwardy     not for users to change their own gameplay client-side
18:28 Krock          so just as extentions?
18:28 nerzhul        paramat, i did the descriptiong: move the Server mod configuration handling code to common interface permitting CSM to have the same interface :)
18:28 paramat        5782 is better
18:28 Fixer          nerzhul: oh, you already pushed a fix?
18:28 nerzhul        rubenwardy, both are important
18:28 nerzhul        Fixer, i pushed a fix on this PR
18:28 nerzhul        you should test it
18:28 Fixer          nerzhul: will check
18:28 kilbith        CSM is not usable for closed-source stuff, unfortunately
18:29 nerzhul        then let's go for 5554, can we look at next PR ?
18:29 rubenwardy     well, running GPL javascript in a web browser doesn't make the browser GPL, unless it's bundled with it
18:29 rubenwardy     ianal though
18:30 paramat        hmm so csm mods appear and are enabled just like all other mods?
18:30 nerzhul        Fixer, i close #5667 both paramat PR has been merged
18:30 rubenwardy     paramat, there's no GUI
18:30 ShadowBot      https://github.com/minetest/minetest/issues/5667 -- Particles rendered for everyone on server irregardless of distance/visibility
18:30 paramat        no description in a PR is unnacceptable
18:30 rubenwardy     just a config file
18:30 ShadowNinja    rubenwardy: We can't do that yet though, because the current snadbox is quite weak and we can't execute arbitrary remote code without a strong sandbox.
18:30 nerzhul        paramat, there is no formspec interface atm, it's just configuration, and they are not confused with other mods
18:30 Fixer          nerzhul: right, i will also close another issue if i confirm it is fixed
18:31 Fixer          lof fps bug*
18:31 Fixer          low*
18:31 rubenwardy     ShadowNinja, I'm not saying that we should start that now, I just worry that once we have this feature it'll never be removed
18:32 paramat        hmm ok, but i am very unimpressed by lack of description
18:32 nerzhul        both feature are important, prediction on formspec (example a craft guide seems good client side, and is not affected by lag), but for that in fact you need client GUI customization because your formspec is a client customization :D
18:32 rubenwardy     I think the best way for this is for clients to download client mods at the server's request from somewhere else than the server, ie: a mod store. For debugging, a secure setting is needed to allow unsecured mods
18:33 nerzhul        rubenwardy, yeah, it's not the purpose of this meeting, we can discuss about this after :)
18:33 nerzhul        this feature will not be added for tomorrow :p
18:33 ShadowNinja    nerzhul: I think you can go ahead and merge that PR after testing it now.
18:34 paramat        no description was what RBA did, irritating
18:34 nerzhul        ShadowNinja, nice, will re-verify if after meeting and merge
18:34 nerzhul        paramat, RBA did more complex PR :p
18:34 ShadowNinja    Next: https://github.com/minetest/minetest/issues/5728 Block instadig after tool switch
18:35 nerzhul        next issue is #5728, but there is no real PR associated
18:35 ShadowBot      https://github.com/minetest/minetest/issues/5728 -- Block instadig after tool switch
18:35 nerzhul        i tested one and it was worst
18:35 rubenwardy     I think you can merge #5554, as it's needed currently for testing - but you should accept that it can be thrown away at a later date when needed. Or at least the server should take priority
18:35 paramat        there is a new PR for that
18:35 ShadowBot      https://github.com/minetest/minetest/issues/5554 -- [CSM] Allow enabling and disabling mods. by red-001
18:35 paramat        #5785
18:35 ShadowBot      https://github.com/minetest/minetest/issues/5785 -- Fix instant digging by HybridDog
18:35 nerzhul        rubenwardy, priority can be done, but client should customize his game himself without server if needed, we will have an algo to determine this
18:36 nerzhul        okay this code move seems more reasonable
18:36 nerzhul        i'm testing it now
18:36 VanessaE       I need to remind you all of #5640 also...
18:36 ShadowBot      https://github.com/minetest/minetest/issues/5640 -- Automatic item and node colorization by juhdanad
18:38 paramat        yeah i notified reviewers of previous colour PRs, seems none are present
18:38 nerzhul        seems to fix the instadig bug
18:38 nerzhul        cannot reproduce it
18:38 nerzhul        5785 is fine for me
18:38 paramat        maybe we can get 5640 reviewed by end of tomorrow
18:39 nerzhul        if others are okay we can merge it
18:42 ShadowNinja    How about #5627?  I think it looks pretty good visually now.
18:42 ShadowBot      https://github.com/minetest/minetest/issues/5627 -- Menu: Merge singleplayer and server tabs by octacian
18:42 nerzhul        ShadowNinja, merge
18:42 nerzhul        Krock, are you okay with 5785 ?
18:42 nerzhul        Fixer has tested it and me too
18:42 paramat        well, 2 have tested 5785 and is simple, i'm sure we can merge this within a day
18:42 ShadowNinja    The file should probably be renamed too by whoever merges though.
18:43 nerzhul        ShadowNinja, which file ?
18:43 nerzhul        merging 5785
18:43 ShadowNinja    (and the tab name at the bottom)
18:43 Krock          nerzhul, if you're sure that it's fixed, all-ok.
18:43 ShadowNinja    nerzhul: tab_singleplayer -> tab_play
18:43 tenplus1       hi peeps
18:43 tenplus1       imma leave this here for devs: https://github.com/minetest/minetest_game/pull/1543
18:43 nerzhul        tenplus1, it's core meeting not game :)
18:43 VanessaE       ShadowNinja: imho that's a bad name
18:44 VanessaE       because what is "client" then, if not "playing" the game also?
18:44 tenplus1       ooh, meeting time :)
18:44 ShadowNinja    VanessaE: Maybe not an ideal name, but I don't want to bikeshed too much :-P
18:45 tenplus1       ?
18:45 VanessaE       maybe not, but the user has to understand it too
18:45 VanessaE       maybe "Local Game" for the "play" tab, and "Go Online" for the "client" tab?
18:45 Fixer          nerzhul: unicode bug fixed
18:46 nerzhul        Fixer, nice, if there is an issue, just close it :)
18:46 nerzhul        VanessaE, i proposed that but not very accepted :p
18:46 nerzhul        i proposed (online)
18:47 nerzhul        also Local Game permits to enable server mode with public list
18:47 VanessaE       that's the idea.
18:47 VanessaE       "Local Game" more easily encompasses both singleplayer and hosting, without implying that "client" ("whatever that is!") isn't also a "play" option.
18:48 paramat        client is not necessarily online
18:48 VanessaE       paramat: usually it is, I'd say.
18:48 paramat        and 'play' becomes hosting a server
18:49 paramat        .. which is not a local game
18:49 VanessaE       99% of the users who download this are going want to do two things:  play a singleplayer game, or go on some public server.
18:49 rubenwardy     as it's the day before the freeze, we can talk about MTG features that are wanted desperately
18:49 ShadowNinja    I think local game and play online are good.
18:49 rubenwardy     (and already have PRs for)
18:49 rubenwardy     game#1543
18:49 ShadowBot      https://github.com/minetest/minetest_game/issues/1543 -- Add 'creative' privilege for survival servers by tenplus1
18:49 paramat        many play LAN which is not really 'online'
18:50 VanessaE       paramat: from the standpoint of the computer running the client, it is.
18:50 tenplus1       why not simply "singleplayer" and "multiplayer" ?
18:50 ShadowNinja    tenplus1: Because local games can be multiplayer.
18:50 rubenwardy     heh, game#1543 is non-urgent
18:50 ShadowBot      https://github.com/minetest/minetest_game/issues/1543 -- Add 'creative' privilege for survival servers by tenplus1
18:50 paramat        yeah, technically
18:50 tenplus1       not urgent, but a damn good feature for servers
18:50 paramat        game 1543 is not critical
18:51 tenplus1       you realise how many owners will grant trusted players 'creative' to help out
18:51 Krock          well, there's "give"
18:51 ShadowNinja    Can we agree to merge with the tabs renamed "Local Game" and "Play Online"?
18:51 tenplus1       I wouldnt give 'give'... too paranoid they give themselves hidden/special nodes...  creative is much easier to regulate
18:52 tenplus1       sounds good shadow
18:52 paramat        i think you're rushing 5627, we have 24 hrs
18:52 nerzhul        ShadowNinja, seems good yeah
18:52 Krock          +1
18:53 VanessaE       +1
18:53 ShadowNinja    paramat: There's plenty of time for bugfixes after the freeze if there's an issue.
18:53 paramat        and i disagree with 'local game' and 'play online'
18:53 Krock          tenplus1: the creative priv looks good
18:53 nerzhul        paramat, yeah but having a consensus permit to ensure merging :p
18:53 tenplus1       thanks krock, and even sofar likes it...
18:53 ShadowNinja    paramat: Why?  You would prefer?  Is it that big of a deal?
18:54 Krock          paramat, how would you name them? Keep as-is?
18:54 VanessaE       ShadowNinja: one thing though, Jordach had a whole revamped menu he wanted to get in before 0.4.16.  might be worth checking with him first.
18:54 paramat        so 'local game' contains internet multiplayer? =/
18:54 VanessaE       "local game" refers to who hosts the server. :)
18:54 ShadowNinja    paramat: Yep, but hosted locally.
18:54 rubenwardy     no rewrite's getting into 0.4.16 at this point
18:55 paramat        we have 24 hrs, don't rush
18:55 paramat        but ok, it's borderline reasonable
18:55 VanessaE       paramat: or delay the freeze if needed
18:55 ShadowNinja    VanessaE: Eh, it's too late to merge it at this point, and this wouldn't conflict since he would just be replacing all of this.
18:55 VanessaE       ShadowNinja: ok, no worries.
18:56 Fixer          nerzhul: interestingly, i can't type one symbol i have... U+2116 â„– (Numero Sign) that was working before
18:56 ShadowNinja    paramat, rubenwardy: Does it seem mergable with "Local Game"/"Play Online"?
18:57 paramat        it's just a little weird you changing 5627 without the author knowing
18:58 Fixer          Local/Internet
18:58 Fixer          simple as that
18:58 VanessaE       Fixer: I can't type unicode chars at all in MT, either with X11-compose or shift-ctrl-u<digits>
18:58 paramat        discuss it with the author and we can merge it tomorrow
18:59 paramat        a problem with 'meetings' is the tendancy to rush things, it happened before
18:59 ShadowNinja    paramat: Well, the author isn't the one who has to approve it...  I'll take that as an approval.
18:59 kaeza          I can't type accents into the console either
19:00 paramat        ok -1
19:00 Fixer          kaeza: even before?
19:00 kaeza          things like áéíóú show as ´a´e´i etc
19:00 kaeza          Fixer, has been this way forever
19:00 Fixer          ah
19:00 kaeza          well, since MT ditched the chat "dialog"
19:00 paramat        please wait and discuss with the author
19:00 VanessaE       X11_compose-t-m should be " â„¢ " but is just "tm" in minetest.,
19:01 paramat        he'll probably be around tonight
19:01 paramat        i'll link him to this discussion
19:02 kaeza          those are probably because of dead keys; things like "ñ" (which is a separate key on spanish keyboards) work
19:03 ShadowNinja    paramat: See my comment.
19:03 paramat        5627 isn't even essential for release or a blocker, lets merge it tomorrow
19:03 ShadowNinja    Is it accurate?
19:04 nerzhul        yeah i agree we can delay before feature freeze. Next ?
19:04 paramat        sort of, i'm neutral
19:04 paramat        thanks
19:04 tenplus1       will this be an all format release ? (win, linux, android) ?
19:06 nerzhul        ?? we always release on all supports
19:06 nerzhul        except mac osx
19:07 tenplus1       I mean at the same time...  last few releases had android lagging behind
19:07 ShadowNinja    Anything else that's important we cover before the freeze?
19:08 nerzhul        #4206 closing
19:08 ShadowBot      https://github.com/minetest/minetest/issues/4206 -- Implement an LMDB backend by ERIIX
19:08 VanessaE       the only thing I had in mind was that "simple metals" idea (see #minetest)(
19:08 VanessaE       but it's too late now
19:08 nerzhul        #5589 PR before feature freeze can be nice
19:08 ShadowBot      https://github.com/minetest/minetest/issues/5589 -- Accommodate duplicate and empty world names automatically by metarmask
19:09 tenplus1       stu's #5767 would be nice but only noticable when using player textures
19:09 ShadowBot      https://github.com/minetest/minetest/issues/5767 -- Don't add damage flash while punch texture modifier is active by stujones11
19:09 Krock          from my side, the strip down sneak PR but that's too time consuming to process that one.
19:09 Krock          tenplus1, we already had this here
19:09 tenplus1       w00t
19:10 Krock          it's going to be tested and merged before release
19:10 ShadowNinja    It's basically the same as #4962 though, and that PR is more comprehensive.
19:10 ShadowBot      https://github.com/minetest/minetest/issues/4962 -- Save the name of the world in world.mt and remove invalid characters from the directory name by red-001
19:10 paramat        no it's not the same
19:12 nerzhul        Fixer, i want to tell a thing: encoding problems on each platform is just a pain ! :p
19:12 tenplus1       encoding?
19:13 nerzhul        keyboard issues :p
19:13 tenplus1       ahh
19:15 nerzhul        Fixer, for your character problem it just depend on your locale
19:15 nerzhul        http://en.cppreference.com/w/cpp/string/wide/iswprint
19:15 nerzhul        if your locale is wrong you cannot print some chars
19:16 Fixer          nerzhul: funnily it worked on yesterday build
19:16 Fixer          before that changes
19:16 nerzhul        but there was another problem... the char on mac osx
19:17 nerzhul        with the shift key
19:17 Fixer          yes
19:20 nerzhul        Fixer, can you test one thing for me
19:20 Fixer          yeah
19:20 nerzhul        replace iswprint condition with !iswcntrl
19:21 nerzhul        i think it's a better test :p
19:21 nerzhul        and yeah i can print € in chat now
19:21 nerzhul        seems to be the real fix
19:22 Fixer          will test
19:22 garywhite      Oh, 0.4.16 freeze is only about 28.5 hours away
19:23 tenplus1       hi gary
19:23 garywhite      hi ten
19:25 nerzhul        who does some MacOSX builds there ?
19:26 tenplus1       doesnt it still have to be jailbroken to run ?
19:28 nerzhul        lol
19:28 Calinou        no, not for macOS
19:28 Calinou        that'd be iOS
19:28 Calinou        I could do a macOS build but I'd need instructions :P
19:28 tenplus1       ahh
19:30 garywhite      isn't macOS kind of like Linux? (I know they're both UNIX-based)
19:31 nerzhul        no
19:31 nerzhul        Linux is not a UNIX based, it just has unix philosophy
19:31 Fixer          linux is not uni...
19:31 nerzhul        BSD is UNIX based, and MacOSX is built upon FreeBSD
19:37 GreenDimond    I'm just gonna leave this here in case any core devs (or anyone for that matter) is interested. https://forum.minetest.net/viewtopic.php?p=271095#p271095 Dunno if Exeter reported it already. Screenshots of it are further down posted by vita.
19:37 GreenDimond    I am rather concerned.
19:38 GreenDimond    If this is a Minetest bug not caused by mods, it better be fixed quick :o
19:38 tenplus1       oof, what mods he got running ???
19:38 paramat        looking
19:39 GreenDimond    yeah check servers.minetest.net for mod list
19:39 * VanessaE     's server is #2 on the list today :D
19:39 ShadowBot      https://github.com/minetest/minetest/issues/2 -- Burned wood
19:39 VanessaE       (was #1 earlier)
19:39 ShadowBot      https://github.com/minetest/minetest/issues/1 -- GlowStone code by anonymousAwesome
19:39 paramat        hehe
19:39 GreenDimond    lol
19:39 VanessaE       shit, wrong channel
19:40 GreenDimond    well derp nvm the server is off so you cant access it :/
19:40 GreenDimond    lemme see if the test server is up and Ill give you the list
19:40 GreenDimond    well, an older list.
19:40 paramat        mgv7 with floatlands enabled?
19:40 GreenDimond    nvm he has that one off too
19:40 VanessaE       paramat: with THAT much water?  no chance.
19:40 GreenDimond    mg7 yes
19:40 GreenDimond    dunno about floatlands (i think no)
19:41 paramat        floatlands are disabled by default in mgv7
19:41 paramat        and should not create unsupported water
19:41 GreenDimond    I sealed up a similar source yesterday that we thought was a WE hacker
19:41 GreenDimond    it wasnt growing tho
19:43 Fixer          nerzhul: yep, â„– works with your suggested function
19:43 nerzhul        i hope this works for mac osx too, waiting for input to merge
19:44 shivajiva      ^ +1
19:45 GreenDimond    off the top of my head he has default mods, vending machines, stairs+, a few custom mods, 3d_armor, colored wood, protector redo i think, bakedclay, homedecor... erm...
19:46 tenplus1       nothing that would generate water in mid air ?
19:46 GreenDimond    dont think so
19:46 GreenDimond    I could be entirely wrong tho
19:46 GreenDimond    I dont have the mod list in front of me :/
19:47 GreenDimond    he has mobs_redo aswell
19:47 GreenDimond    oh and WE ofc
19:48 shivajiva      possible injection via the exploit?
19:48 tenplus1       ya think anyone would have WE priv apart from admin ?
19:48 VanessaE       you don't need privs to use the exploit
19:48 VanessaE       (or didn't, anyway)
19:48 VanessaE       check all of your configuration files, GreenDimond
19:48 VanessaE       make sure none of them have code inserted
19:48 VanessaE       some mods use dofile() to load configs
19:49 VanessaE       and when you do that, you can also put code into the config
19:49 tenplus1       is /lua able to set water_level to a new height ? maybe causing this issue
19:49 VanessaE       also refresh all of your mods, the exploit can be used to rewrite a mod also
19:50 VanessaE       wait, why are we talking about this here?
19:50 VanessaE       --> #minetest
19:50 tenplus1       lol
19:51 GreenDimond    Not my server
19:52 GreenDimond    I posted it here because it could be a possible mapgen bug
19:52 GreenDimond    he uses latest
19:52 GreenDimond    and he updated it recently
20:04 Fixer          did I just evade fall damage again while _continiously_ falling from 2000 nodes high at huge speed?
20:05 Fixer          damage enabled
20:05 Fixer          fuck you and fuck me, it really does
20:06 Fixer          3 seconds cooldown? hmmm
20:06 Fixer          hmhmhmhmhm
20:11 Fixer          ok, I'm creating ANOTHER fall evasion bug, this is literally fucked up
20:17 Fixer          survived fall at 270 nodes/sec
20:29 nerzhul        merging trivial #5787 which really solve the mac osx char, confirmed by original PR owner
20:29 ShadowBot      https://github.com/minetest/minetest/issues/5787 -- Real control fix by nerzhul
20:29 Fixer          https://imgur.com/a/GuvtT ??? :D ??? :D ??? :D
20:30 Fixer          i'm speechless, i've seen everything now
20:31 Fixer          nerzhul: ty
20:32 paramat        doesn't look like you hit ignore on the way down, but can you reproduce it?
20:33 Fixer          paramat: yes, every time
20:33 Fixer          paramat: if you hit ignore - you will die at landing
20:33 Fixer          =) !
20:33 Fixer          paramat: the key is preload the area by falling at least once and then go back to that place, wait for cooldown, or 10 sec to be sure, jump off...
20:34 Fixer          easily reproducable
20:34 paramat        yeah
20:35 Fixer          don't ask me, why I did fall 2000 nodes down in the first place, I wanted to check for water places, and decided to fall through... I did not die...
20:46 Fixer          https://github.com/minetest/minetest/issues/5788
20:47 Fixer          btw, i've noticed another bug
20:48 Fixer          something with chat dropdown... sometimes it is not dropped down to usual... depth
20:54 red-001        paramat, added a description to #5554
20:54 ShadowBot      https://github.com/minetest/minetest/issues/5554 -- [CSM] Allow enabling and disabling mods. by red-001
20:54 paramat        thanks
21:58 red-hunter-002 why was #5554 merged in such a strange way?
21:58 ShadowBot      https://github.com/minetest/minetest/issues/5554 -- [CSM] Allow enabling and disabling mods. by red-001
22:00 red-hunter-002 see #90808a4
22:03 red-hunter-002 https://github.com/minetest/minetest/commit/90808a4f34dca379e872074bdfd472faf1c48cf3
22:03 red-hunter-002 !title
22:03 ShadowBot      Real control fix (#5787) · minetest/minetest@90808a4 · GitHub
22:03 red-hunter-002 @90808a4
23:04 nerzhul        5554 is not merged