Time Nick Message 01:32 paramat sofar #5672 rebased, i will retest 01:32 ShadowBot https://github.com/minetest/minetest/issues/5672 -- Set sky: Add bool for clouds with custom skybox by paramat 01:40 paramat retested 02:03 paramat *=( looks like it might conflict with #5340 i may have to rebase it again if that is merged 02:03 ShadowBot https://github.com/minetest/minetest/issues/5340 -- Add fading sounds by SmallJoker 02:05 paramat well 5340 is older so higher priority, unfortunately 02:07 paramat i'll merge #5340 #5675 in a moment 02:07 ShadowBot https://github.com/minetest/minetest/issues/5340 -- Add fading sounds by SmallJoker 02:07 ShadowBot https://github.com/minetest/minetest/issues/5675 -- Sneak: Improve and fix various things by SmallJoker 02:20 paramat merging 02:29 paramat complete 02:31 paramat wow no new conflicts for 5672 02:32 paramat need to update lua_api though 02:38 paramat doing so 02:46 paramat sofar updated lua_api.txt in 5672 have to go eat now, please merge tonight if you can 02:51 sofar will do 04:24 paramat thanks 04:24 sofar looks fantastic, skybox mod updated with per-skybox cloud sets 04:24 sofar each skybox has different clouds 04:25 sofar tuned to the textures :) 04:34 sofar ohhh something broke in the protocol support 04:35 sofar this is really weird, I can connect 0.4.14 to the server, but not 0.4.15 04:36 sofar the message is also bizarro 04:36 sofar it says the server supports 13-24, and the client 25-28 04:58 paramat oops i would not be surprised if i did something wrong in that PR 05:00 sofar no, there is something else going on I think 05:13 sofar bisecting 05:24 sofar it's all nonsense on my box, because I have like 4 different versions fighting for files 05:24 sofar sigh 05:24 sofar wasted my time 11:50 sfan5 Krock: he's saying it results in a PacketError but the catch() has the wrong class in it 11:50 Krock yes, already seen it 11:50 Krock GitHub doesn't send the new message once it's edited 11:50 Krock https://hastebin.com/igesadefof.cpp 11:50 Krock s/cpp/diff/ 11:51 sfan5 (that counts as trivial fix, it's fine if you push it) 11:51 Krock does it look right for you? (just to make sure) 11:52 sfan5 if what the issue reporters says is correct, then yes 11:52 Krock NetworkPacket::checkReadOffset only seems to throw that exception 11:52 Krock no idea how this serialisazion stuff came in 11:52 Krock pushing in 1 min 11:56 nerzhul Krock, yeah the only Error is if you try to read outside of packet limits 11:56 Krock ah. It already has been used this way in other Client network packet handling functions. 11:57 Krock so they'd basically all throw an error when providing wrong data 12:06 Krock nerzhul, is there any chance to adjust LINT one more time to have a bigger tolerance for the code to check? Bundling one-liner functions into one line including the brackets isn't important to have IMO 12:09 nerzhul Krock => https://clang.llvm.org/docs/ClangFormatStyleOptions.html 12:09 nerzhul there is multiple styles for one liner, i hope at a moment we will just define the right code style and just check the code, and if code style is wrong, let end user run clang format on their pr 13:36 red-001 could someone review #5532 or #5613? 13:36 ShadowBot https://github.com/minetest/minetest/issues/5532 -- [CSM] Add tab autocompletion api by HybridDog 13:36 ShadowBot https://github.com/minetest/minetest/issues/5613 -- [CSM] Add function to get server info. by red-001 14:20 nerzhul red-001, for 5613 can you fix Krock points 14:20 nerzhul ? 14:27 red-001 sure 14:49 Wayward_One not sure if there's a regression, but i am now experiencing rather frequent 1+ second freezes that appear similar to those Fixer experiences, but i have never experienced them before on this system. 14:50 Wayward_One graph: https://lut.im/gallery#RW5HScYcs1/15Pq8k8hv0FsdmKa.png 14:53 Wayward_One idk if it's related, but client_recieved_packets jumps up at the same time, which i don't notice in Fixer's issues 15:23 celeron55 Wayward_One: if you have a 1-second freeze, everything will spike because the length of the frame is so long 15:25 celeron55 you can see the freeze happens when stuff is being rendered 15:27 celeron55 check if you're running out of RAM as swapping is a sure way to cause a 1-second freeze 15:36 Wayward_One ah, ok. i have 8gb, so i don't think that's it, but i'll check next time 15:40 Wayward_One what i find concerning is that the freezes are new on this device 15:43 red-001 is this some sort of werid typo? 15:43 red-001 https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L1891 15:43 red-001 shouldn't it be core.strip_colors? 15:45 sfan5 those look like typos yes 17:43 Fixer Wayward_One: when freeze happens, on what server, do you have lots of signs or other entities? 17:44 Fixer hmmmm 17:44 Fixer mainloop_other is small 17:44 Fixer this is different kind of freeze 17:49 Fixer Wayward_One: if you are pretty sure, post a detailed issue on github, describe your OS/hardware/minetest/config/howithappens/pics... 17:50 Fixer i already posted two stutter issues: 1) for mesh updates 2) for mainloop_other (unknown stuff, kaeza entities etc) 19:08 Wayward_One Fixer, i noticed it on Xanadu and TT-Survival, but not the MarsSurvive server. also, i don't get any freezes using my older linux installation which has a newer OpenGL version. i'll have to do some more testing, perhaps on windows as well 19:10 Wayward_One also, on Xanadu it was at spawn, so lots of signs, but on TT-S i was a considerable distance from spawn 20:57 red-001 updated #5613 20:57 ShadowBot https://github.com/minetest/minetest/issues/5613 -- [CSM] Add function to get server info. by red-001 21:06 paramat red-001 please could you test #5255 so we can merge it? 21:06 ShadowBot https://github.com/minetest/minetest/issues/5255 -- Add option to also check the center to `find_node_near` by red-001 21:33 red-001 paramat, done 21:35 paramat thanks, please add a comment that you tested and it's ok. 21:42 red-001 https://github.com/minetest/minetest/pull/5255#issuecomment-299044068 21:53 paramat thanks 21:54 paramat +1