Time  Nick      Message
02:01 paramat   nore +1 for #5373 , tested. i think we could merge it
02:01 ShadowBot https://github.com/minetest/minetest/issues/5373 -- Add the possibility to skip light update and fix light later by juhdanad
02:01 nore      paramat: ok, good
02:06 paramat   nore although i left 2 line comments about code style, but these could be fixed on merge if necessary
02:08 paramat   i'd like to merge it tonight to avoid a need to rebase it again, so will do so in 2 hrs if no-one else has
02:11 paramat   nore sofar game#1704 has concept approval but it would be good to have the code checked if you are able, easy review
02:11 ShadowBot https://github.com/minetest/minetest_game/issues/1704 -- Ores: Add tin ore, lump, ingot and block by paramat
03:33 nore      merging #5373
03:33 ShadowBot https://github.com/minetest/minetest/issues/5373 -- Add the possibility to skip light update and fix light later by juhdanad
03:33 nore      ^ is it ok if I don't squash the first commit with the others?
03:36 sofar     I'm fine with that, yes
03:38 nore      also fixing the two style issues paramat mentionned...
03:57 nore      does anyone know where the minetest.conf.example generator script is?
03:59 nore      nvm, found it
04:06 paramat   thanks
04:07 nore      merging https://github.com/Ekdohibs/minetest/commit/de5ecc9fa31d557e2d0ca638b1c98435707046b9 if no-one complains
04:10 nore      paramat: sofar: ^
04:10 sofar     +1
04:10 sofar     is that in the release checklist anyway?
04:12 nore      need to see
04:13 nore      nope, doesn't seem to be in http://dev.minetest.net/Releasing_Minetest
04:28 paramat   thanks +1 when i recently generated conf.example i was somehow unable to generate the translation file
06:16 sofar     #5619
06:16 ShadowBot https://github.com/minetest/minetest/issues/5619 -- Add on_flood() callback. by sofar
08:07 red-007   whats with everyone using [off] ?
08:07 red-007   or is my bnc doing something werid
08:08 nrzkt     ?
10:32 red-007   when is the feature frezze again?
10:35 red-007   nvm
10:37 nrzkt     next month
10:41 nrzkt     red-007: https://forum.minetest.net/viewtopic.php?f=18&t=17179&p=264828#p264828
10:41 nrzkt     on the main topic
14:41 Grandolf  erv identify JBG2000
14:41 Grandolf  oops
14:55 Hijiri    ded
14:55 Hijiri    (link)
16:25 Fixer     sneak and double jump is enabled by default newest, correct?
16:30 paramat   sneak ladder and double jump, yes
16:30 paramat   soon disabled by default
16:30 paramat   i'll make a PR
16:52 Hijiri    #5612
16:52 Hijiri    notice me shadowbot
16:52 ShadowBot https://github.com/minetest/minetest/issues/5612 -- Allow overriding tool capabilities through itemstack metadata by raymoo
16:52 Hijiri    https://github.com/minetest/minetest/issues/5612
17:30 nerzhul   paramat, i will look at cloud API this evening and answer your questions, if it's not very huge we can have a nice new remote API :)
18:44 paramat   will merge game#1597 game#1703 game#1704 in a few mins
18:44 ShadowBot https://github.com/minetest/minetest_game/issues/1597 -- Allow skeleton keys to be stacked by octacian
18:44 ShadowBot https://github.com/minetest/minetest_game/issues/1703 -- Doors: ignore permission check if player parameter is omitted by paly2
18:44 ShadowBot https://github.com/minetest/minetest_game/issues/1704 -- Ores: Add tin ore, lump, ingot and block by paramat
18:57 Krock     tin?!
18:57 Krock     I think that one should wait a little
18:57 Krock     the other two are fine
18:59 Krock     the reason is that I can't see any real opinion on it. No idea what players think about it
19:01 Krock     whatever
19:05 paramat   sorry, i had 3 concept approvals (linked) and sfan5 and nore approved a merge
19:07 Krock     yeah, some more player comments wouldn't hurt sometimes but that's a general problem *shrug*
19:07 sofar     ores were largely wanted by players anyway
19:08 Krock     right now they don't have a big use at all. Would be great to add some more items based on tin, but that can also happen later
19:09 paramat   (or rather, sfan 5 advised i merge it)
19:09 paramat   yes player comments are good but if none do and devs support that is good enough
19:10 paramat   merged
19:10 Krock     indeed
19:22 Fixer     adding another set of tin tools (shovel, axe, whatever) is just lame, metals should be used in automation and other stuff :}
19:30 sofar     does the PR do that?
19:30 sofar     we should remove tools, not add more
19:30 sofar     properly tier them, too
19:30 Fixer     no, that pr does not add tools
19:30 paramat   no tin tools don't worry
19:31 paramat   i would -1 that anyway
19:33 Shara     Meaningful tiering of tools would be wonderful to see.
19:34 paramat   well we need ideas on how to make bronze tools worth the effort
19:48 Hijiri    make something that costs lots of iron?
19:48 Hijiri    that isn't tools
19:49 Hijiri    realistically iron would be better than bronze for tools
19:49 Hijiri    and in-game iron is abundant so nobody ever uses bronze
19:50 Fixer     game already has tons of basic tools, time to move out of dumb sandbox imo
19:51 Hijiri    yes I agree
19:51 Hijiri    so we want some new mechanically interesting system?
19:52 Hijiri    maybe we can make it cost lots of bronze
19:52 Hijiri    not to imply I have contributed to Minetest Game
19:53 Warr1024  sounds like the sort of thing that should be out-of-scope for the base game, and something that should be added by mods or an alternative game...
19:54 Hijiri    the game currently doesn't have anything interesting though
19:54 Hijiri    is the game supposed to be boring without mods?
19:56 Warr1024  keeping it "boring" helps keep it compatible with 3rd-party mods.
19:58 Hijiri    Warr1024: are you implying with your scare quotes that it's not boring?
19:58 Warr1024  yes and no
19:59 Warr1024  I guess it depends on your standards for excitement.
19:59 Hijiri    I'm not interested in purely building
19:59 Hijiri    (and mining to build, etc)
20:00 Warr1024  me neither, but mods are already pretty good for that
20:01 Warr1024  I'd say the base game isn't exactly "boring" so much as "incomplete by design."
20:01 Hijiri    I don't see why the kinds of features added to the game can't be limited to ones that have minimal incompatibility risk
20:01 Hijiri    Warr1024: by whose design?
20:02 Warr1024  there are different kinds of compatibility issues, too.  You could add a steam engine to the base game, and it'd be thematically incompatible with some futuristic/sci-fi type mods, and force those mod devs to do awkward things to handle it...
20:02 Warr1024  it can be surprisingly hard for mod developers to selectively remove/change pieces of the upstream game they don't like without having to maintain a full fork.
20:04 Warr1024  the minimalism in _game means I spend more time working on content in my mods, as compared to time spent responding to upstream changes.
20:04 Hijiri    Additions could be thematically-neutral
20:04 Hijiri    or do you believe it would be exceptionally difficult to do that
20:06 Hijiri    Warr1024: There's also the issue with an alternative "full" game, if it's meant to avoid incompatibility like this, is going to be incompatible with mods for the base game (by your reasoning)
20:06 Warr1024  frankly, I don't even see why we have to have a "game" construct, which sort of implies that all these mods depend on each other (which they don't, strictly; some COULD be gracefully removable)
20:07 Hijiri    I guess Minetest could come with a collection of mods that aren't in a game or anything
20:43 Fixer     nonsence
20:44 Fixer     it can be very advanced, yet modular, where you can disable some parts, or use any mods along with it
20:44 sofar     maybe move the discussion to #-hub?
20:45 Fixer     yeah
21:40 sofar     nerzhul: since I'm a complete nub, can you confirm that this is what you meant:
21:40 sofar     -                       ServerEnvironment& env);
21:40 sofar     +                       ServerEnvironment *env);
21:41 sofar     and etc.
21:41 sofar     -                       if (env.getScriptIface()->node_on_flood(p0, n0, new_node_content))
21:41 sofar     +                       if (env->getScriptIface()->node_on_flood(p0, n0, new_node_content))
21:43 nore      sofar: I think that's what he meant, yes
21:57 nerzhul   yes
21:57 paramat   #5623
21:57 ShadowBot https://github.com/minetest/minetest/issues/5623 -- Sneak glitch: Set default to false by paramat
21:59 sofar     merge it!
22:02 sofar     I'll look at the on_flood param2 value issue tonight and see if we can get it totally 100% correct
22:02 sofar     I think we should be able to get the liquid level value in there as well
22:06 nerzhul   it's midnight, time to go to bed, not review for me, will look at this tomorrow :)
22:09 cx384     +
22:20 paramat   phew bug fixed in 5623 and tested